test suite reviews and discussions
 help / color / mirror / Atom feed
* RE: [dts] [PATH V1] framework/crb: optimization script
  2022-01-14 13:38 [dts] [PATH V1] framework/crb: optimization script Jiale Song
@ 2022-01-14  7:23 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2022-01-14  7:23 UTC (permalink / raw)
  To: Jiale, SongX, dts; +Cc: Jiale, SongX

> -----Original Message-----
> From: Jiale Song <songx.jiale@intel.com>
> Sent: 2022年1月14日 21:38
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATH V1] framework/crb: optimization script
> 
> the format of priv-flags may be like 'link-down-on-close: on', so regular
> expressions need to be optimized
> 
> Signed-off-by: Jiale Song <songx.jiale@intel.com>

Applied.
Btw, please don't add "PATH" in subject. The version is enough.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [dts] [PATH V1] framework/crb: optimization script
@ 2022-01-14 13:38 Jiale Song
  2022-01-14  7:23 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Jiale Song @ 2022-01-14 13:38 UTC (permalink / raw)
  To: dts; +Cc: Jiale Song

the format of priv-flags may be like 'link-down-on-close: on',
so regular expressions need to be optimized

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 framework/crb.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 mode change 100755 => 100644 framework/crb.py

diff --git a/framework/crb.py b/framework/crb.py
old mode 100755
new mode 100644
index bd4f565d..c33edf14
--- a/framework/crb.py
+++ b/framework/crb.py
@@ -900,7 +900,7 @@ class Crb(object):
         '''
         check_flag = "ethtool --show-priv-flags %s" % intf
         out = self.send_expect(check_flag, "# ", timeout)
-        p = re.compile('%s\s+:\s+(\w+)' % flag)
+        p = re.compile('%s\s*:\s+(\w+)' % flag)
         state = re.search(p, out)
         if state:
             return state.group(1)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-14  7:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-14 13:38 [dts] [PATH V1] framework/crb: optimization script Jiale Song
2022-01-14  7:23 ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git