test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Sun, QinX" <qinx.sun@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Sun, QinX" <qinx.sun@intel.com>
Subject: Re: [dts] [PATCH V1] tests/iavf_fdir: reload driver to reduce the interaction between cases
Date: Wed, 9 Jun 2021 07:16:06 +0000	[thread overview]
Message-ID: <114d3b0c78aa45e1a8e2f1e06c4f8176@intel.com> (raw)
In-Reply-To: <20210602104156.30955-1-qinx.sun@intel.com>

Reload driver is not a good idea, it will impact other devices which are not under test.

I think 'clear port stats' could help.

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Qin Sun
> Sent: 2021年6月2日 18:42
> To: dts@dpdk.org
> Cc: Sun, QinX <qinx.sun@intel.com>
> Subject: [dts] [PATCH V1] tests/iavf_fdir: reload driver to reduce the interaction
> between cases
> 
> some cases need to reload the driver to clear the packet count received by the
> network card, so as to avoid the verification failure caused by other cases
> 
> Signed-off-by: Qin Sun <qinx.sun@intel.com>
> ---
>  tests/TestSuite_iavf_fdir.py | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tests/TestSuite_iavf_fdir.py b/tests/TestSuite_iavf_fdir.py index
> 27f92f8..e1f7c28 100644
> --- a/tests/TestSuite_iavf_fdir.py
> +++ b/tests/TestSuite_iavf_fdir.py
> @@ -2986,6 +2986,9 @@ class TestIAVFFdir(TestCase):
>          create same rules on pf and vf, no conflict
>          """
>          self.dut.kill_all()
> +        self.dut.send_expect("rmmod ice", "# ", 15)
> +        self.dut.send_expect("modprobe ice", "# ", 15)
> +        self.setup_2pf_4vf_env()
>          self.session_secondary = self.dut.new_session()
>          self.session_third = self.dut.new_session()
> 
> @@ -3137,6 +3140,9 @@ class TestIAVFFdir(TestCase):
>          create same input set but different action rules on pf and vf, no conflict.
>          """
>          self.dut.kill_all()
> +        self.dut.send_expect("rmmod ice", "# ", 15)
> +        self.dut.send_expect("modprobe ice", "# ", 15)
> +        self.setup_2pf_4vf_env()
>          self.session_secondary = self.dut.new_session()
>          self.session_third = self.dut.new_session()
> 
> --
> 2.17.1


      parent reply	other threads:[~2021-06-09  7:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02 10:41 Qin Sun
2021-06-02 10:20 ` Sun, QinX
2021-06-09  7:16 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=114d3b0c78aa45e1a8e2f1e06c4f8176@intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=qinx.sun@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).