test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: "Dong, JunX" <junx.dong@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Tu, Lijuan" <lijuan.tu@intel.com>, "Sun, QingX" <qingx.sun@intel.com>
Subject: RE: [V1] framework/*: Replace framework texttable with third party library
Date: Wed, 30 Mar 2022 11:32:30 +0000	[thread overview]
Message-ID: <118469bbc9624400b219a7899cd3925e@pantheon.tech> (raw)
In-Reply-To: <DM5PR11MB1404AF7381FC72671B08A772EA1F9@DM5PR11MB1404.namprd11.prod.outlook.com>

> > > diff --git a/framework/test_result.py b/framework/test_result.py
> > > index
> > > 0231e769..abf8edb9 100644
> > > --- a/framework/test_result.py
> > > +++ b/framework/test_result.py
> > > @@ -32,7 +32,6 @@
> > >  """
> > >  Generic result container and reporters  """
> > > -import framework.texttable as texttable  # text format
> > >
> > >
> > >  class Result(object):
> > > @@ -445,9 +444,11 @@ class ResultTable(object):
> > >          rt.add_row(row)
> > >          rt.table_print()
> > >          """
> > > +        from texttable import Texttable
> > > +
> > >          self.results_table_rows = []
> > >          self.results_table_rows.append([])
> > > -        self.table = texttable.Texttable(max_width=150)
> > > +        self.table = Texttable(max_width=150)
> > >          self.results_table_header = header
> > >          self.logger = None
> > >          self.rst = None
> >
> > Is there a reason for moving the import statement? I'd prefer to have
> > it at the beginning of the file.
> 
>    Hi, Juraj Linkeš, thanks for your comments.
>    Sometimes, the trex will be used When execute performance suite,
>    And trex also used texttable that comes from  itself.
>    But, the third party library texttable wasn't full compatible with the trex's
> version,
>    If import texttable in global in DTS framework will effect trex which not import
> again,
>   So, import texttable locally in the DTS framework.
> 

Ah, okay. I guess that's a reasonable workaround. I'm fine with this then.

Acked-by: Juraj Linkeš <juraj.linkes@pantheon.tech>


      reply	other threads:[~2022-03-30 11:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-30  9:11 Dong, JunX
2022-03-30 11:32 ` Juraj Linkeš [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=118469bbc9624400b219a7899cd3925e@pantheon.tech \
    --to=juraj.linkes@pantheon.tech \
    --cc=dts@dpdk.org \
    --cc=junx.dong@intel.com \
    --cc=lijuan.tu@intel.com \
    --cc=qingx.sun@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).