From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60E9DA0509; Wed, 30 Mar 2022 13:32:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46B3640685; Wed, 30 Mar 2022 13:32:34 +0200 (CEST) Received: from mailgw02.pantheon.sk (mailgw01.pantheon.sk [46.229.239.26]) by mails.dpdk.org (Postfix) with ESMTP id C69414013F for ; Wed, 30 Mar 2022 13:32:32 +0200 (CEST) Received: from mailgw02.pantheon.sk (localhost.localdomain [127.0.0.1]) by mailgw02.pantheon.sk (Proxmox) with ESMTP id 62FD318394F; Wed, 30 Mar 2022 13:32:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; h=cc:cc:content-transfer-encoding:content-type:content-type :date:from:from:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=dkim; bh=f1GAcwWO0llfTOXMbJae 2CNK7YgDMyKgu8Sg+hvRQ9o=; b=IeBws+G0Yhsx35zMcvpy5q0S0BVxC6rNPjW/ 428YsbKwwnFFJxuLPpR9EQDi86VfTG3GYcpMBuRpNiUzmJAPWTMiS7ZEirwCpJCb Z4Nzvsosl4HqQlc0q2Yk5p2dlWGRXrOT2CWWD+jF6kIAQ+MlHuAyUjnPYIqZSvk6 PetVnFbCHblFnAUxyyyDJfV2FykS94YJ3AUYVxFxiyshdzWtvudEf+zVfs5yTF0p 5X5Mvl6uc5bwozqlrZ6/AJXc55lL74OqjfiMTz3OftA9Jagh7B4Z070/ni2e1HYM TsKxTK7mzGc5H4nr9yQ6NkC/TtTluIVk9xInqBi4plbz5laW+Q== From: =?iso-8859-2?Q?Juraj_Linke=B9?= To: "Dong, JunX" , "dts@dpdk.org" CC: "Tu, Lijuan" , "Sun, QingX" Subject: RE: [V1] framework/*: Replace framework texttable with third party library Thread-Topic: [V1] framework/*: Replace framework texttable with third party library Thread-Index: AdhEFHyAsiOc8KV6TlKppJVyxwPcKQAFSPsg Date: Wed, 30 Mar 2022 11:32:30 +0000 Message-ID: <118469bbc9624400b219a7899cd3925e@pantheon.tech> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.101.4.10] Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org > > > diff --git a/framework/test_result.py b/framework/test_result.py > > > index > > > 0231e769..abf8edb9 100644 > > > --- a/framework/test_result.py > > > +++ b/framework/test_result.py > > > @@ -32,7 +32,6 @@ > > > """ > > > Generic result container and reporters """ > > > -import framework.texttable as texttable # text format > > > > > > > > > class Result(object): > > > @@ -445,9 +444,11 @@ class ResultTable(object): > > > rt.add_row(row) > > > rt.table_print() > > > """ > > > + from texttable import Texttable > > > + > > > self.results_table_rows =3D [] > > > self.results_table_rows.append([]) > > > - self.table =3D texttable.Texttable(max_width=3D150) > > > + self.table =3D Texttable(max_width=3D150) > > > self.results_table_header =3D header > > > self.logger =3D None > > > self.rst =3D None > > > > Is there a reason for moving the import statement? I'd prefer to have > > it at the beginning of the file. >=20 > Hi, Juraj Linke=B9, thanks for your comments. > Sometimes, the trex will be used When execute performance suite, > And trex also used texttable that comes from itself. > But, the third party library texttable wasn't full compatible with the= trex's > version, > If import texttable in global in DTS framework will effect trex which = not import > again, > So, import texttable locally in the DTS framework. >=20 Ah, okay. I guess that's a reasonable workaround. I'm fine with this then. Acked-by: Juraj Linke=B9