From: lijuan.tu@intel.com
To: dts@dpdk.org,Ke Xu <ke1.xu@intel.com>
Cc: qi.fu@intel.com,ke1.xu@intel.com
Subject: [dts][PATCH V1 2/2] tests/tso: modify get_chksum_value_and_verify to improve the performance
Date: 01 Sep 2022 18:57:50 -0700 [thread overview]
Message-ID: <11ab82$k2tb5i@fmsmga008-auth.fm.intel.com> (raw)
In-Reply-To: <20220823055939.4186198-3-ke1.xu@intel.com>
On Tue, 23 Aug 2022 05:59:39 +0000, Ke Xu <ke1.xu@intel.com> wrote:
> Function "get_chksum_value_and_verify" in test suite TSO case test_tso_tunneling
> is of low efficiency. Methods are wrongly used.
>
> Duplicated call to method "packet.read_pcapfile" in this function will lengthen
> the packet sequence stored in "packet.pktgen.pkts", consuming more time when
> save pcap file. Duplicated call to method "packet.save_pcapfile" is also time
> consuming.
>
> Method "pks.show" and "self.pks1[i].show" is not used as expected. "*.show" is
> used to print the packet object, not intended to return a string. Current code
> is actually getting a method object and using "str(*)" method to turn a method
> object to a string, this may fail when "*.show" method is updated. The packet
> information printing here is equivilant to "repr(pks)".
>
> Signed-off-by: Ke Xu <ke1.xu@intel.com>
Acked-by: Lijuan Tu <lijuan.tu@intel.com>
Series applied, thanks
prev parent reply other threads:[~2022-09-02 1:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 5:59 [dts][PATCH V1 0/2] tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify error and " Ke Xu
2022-08-23 5:59 ` [dts][PATCH V1 1/2] tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify error Ke Xu
2022-08-23 5:59 ` [dts][PATCH V1 2/2] tests/tso: modify get_chksum_value_and_verify to improve the performance Ke Xu
2022-09-02 1:57 ` lijuan.tu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='11ab82$k2tb5i@fmsmga008-auth.fm.intel.com' \
--to=lijuan.tu@intel.com \
--cc=dts@dpdk.org \
--cc=ke1.xu@intel.com \
--cc=qi.fu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).