From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 348F1A0542; Fri, 2 Sep 2022 03:57:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12E3B40693; Fri, 2 Sep 2022 03:57:54 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id C7F7D40684 for ; Fri, 2 Sep 2022 03:57:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662083873; x=1693619873; h=message-id:date:content-transfer-encoding:mime-version: subject:from:to:reply-to:cc:in-reply-to; bh=n6cRelC6qH6/aoS2TlMvnsvb3T8uJ1vXxWt0WrhepY8=; b=XQ3+TF3YMl9gubfKJXYZk69qH3vUjemhzdM1UfqhYLqrEhFsErl0vRkY EknsVy5B/cCfveZBoFPKS3NZ2ri0B3cTsypdijJO2r4Iyo4fNuJHIWdLK NYcG0S/K47cg43qRFUWuNK7J5ZmgaxqDoqXeAHHEUJV0j6qNzxlUkmpxi xt86dPeqWsfep7uEcSbFcmMD0hM6CoxanKSd3se4k29aFamKsv+LYMe3v QtjzskUOlE0JA73jL21QcvzuLQWqUdr+CKYwAoNHirDgyWUZsjRAH1P7h W7R8SsdumRJrMNK5+XsdPFXkqjac62i9/F0HMETBeYS78+0vTdQicZQM7 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10457"; a="297154775" X-IronPort-AV: E=Sophos;i="5.93,281,1654585200"; d="scan'208";a="297154775" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2022 18:57:51 -0700 Message-Id: <11ab82$k2tb5i@fmsmga008-auth.fm.intel.com> Date: 01 Sep 2022 18:57:50 -0700 X-IronPort-AV: E=Sophos;i="5.93,281,1654585200"; d="scan'208";a="674147517" Received: from dpdk-lijuan-1.sh.intel.com ([10.67.119.225]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2022 18:57:50 -0700 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: [dts][PATCH V1 2/2] tests/tso: modify get_chksum_value_and_verify to improve the performance From: lijuan.tu@intel.com To: dts@dpdk.org,Ke Xu Cc: qi.fu@intel.com,ke1.xu@intel.com In-Reply-To: <20220823055939.4186198-3-ke1.xu@intel.com> X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Ke Xu Errors-To: dts-bounces@dpdk.org On Tue, 23 Aug 2022 05:59:39 +0000, Ke Xu wrote: > Function "get_chksum_value_and_verify" in test suite TSO case test_tso_tunn= eling > is of low efficiency. Methods are wrongly used. >=20 > Duplicated call to method "packet.read_pcapfile" in this function will leng= then > the packet sequence stored in "packet.pktgen.pkts", consuming more time wh= en > save pcap file. Duplicated call to method "packet.save_pcapfile" is also t= ime > consuming. >=20 > Method "pks.show" and "self.pks1[i].show" is not used as expected. "*.show"= is > used to print the packet object, not intended to return a string. Current = code > is actually getting a method object and using "str(*)" method to turn a me= thod > object to a string, this may fail when "*.show" method is updated. The pac= ket > information printing here is equivilant to "repr(pks)". >=20 > Signed-off-by: Ke Xu Acked-by: Lijuan Tu Series applied, thanks