From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3EC0CA046B for ; Mon, 19 Aug 2019 07:41:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0671C2BE1; Mon, 19 Aug 2019 07:41:03 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 5975E1DBD for ; Mon, 19 Aug 2019 07:41:01 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Aug 2019 22:41:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,403,1559545200"; d="scan'208";a="195460046" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 18 Aug 2019 22:41:00 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 18 Aug 2019 22:41:00 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 18 Aug 2019 22:41:00 -0700 Received: from shsmsx106.ccr.corp.intel.com ([169.254.10.204]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.80]) with mapi id 14.03.0439.000; Mon, 19 Aug 2019 13:40:57 +0800 From: "Fu, Qi" To: "Mo, YufengX" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH 08/17] tests/TestSuite_ipgre: add carlsville to support nic of ipgre Thread-Index: AQHVVku9CaR9JH7KBUS4mckDM42yKacB7FpA//9+3wCAAIhVsA== Date: Mon, 19 Aug 2019 05:40:57 +0000 Message-ID: <122BE83F39B639498C1565A7B0CDA2200113B986@SHSMSX106.ccr.corp.intel.com> References: <20190819110625.73544-1-qi.fu@intel.com> <20190819110625.73544-9-qi.fu@intel.com> <122BE83F39B639498C1565A7B0CDA2200113B95D@SHSMSX106.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWNjOWFjNjUtMTgwOC00NTQ3LWE0MmYtZDk1YTAxN2U4ZWM2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidnJ4ZktudXBaSnRIb3NKZ05kUE5OU1hBSWhkeHk5ZXRGT29CSThKeVwvaFlHam9UZkRDZkllbHdxb1wvelwvMmZwRCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH 08/17] tests/TestSuite_ipgre: add carlsville to support nic of ipgre X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Ok, I just verified the carlsville can work before but miss the Fortville. I will correct this patch. Thanks for your advice! Best regards, Fu, Qi -----Original Message----- From: Mo, YufengX=20 Sent: Monday, August 19, 2019 1:29 PM To: Fu, Qi ; dts@dpdk.org Subject: RE: [dts] [PATCH 08/17] tests/TestSuite_ipgre: add carlsville to s= upport nic of ipgre Hi,fuqi You can try this, its logic will return False. Is it your expected? nic =3D 'fortville_spirit' print nic.startswith("fortville" and "carlsville") > -----Original Message----- > From: Fu, Qi > Sent: Monday, August 19, 2019 1:24 PM > To: Mo, YufengX ; dts@dpdk.org > Subject: RE: [dts] [PATCH 08/17] tests/TestSuite_ipgre: add carlsville=20 > to support nic of ipgre >=20 > Hi, >=20 > Lijuan has reviewed these patchese and I have verified them before. > If use 'self.nic.startswith("fortville" or "carlsville")' it can't work, = but use 'self.nic.startswith("fortville" and "carlsville")' works well. >=20 > Best regards, > Fu, Qi >=20 >=20 > -----Original Message----- > From: Mo, YufengX > Sent: Monday, August 19, 2019 1:06 PM > To: Fu, Qi ; dts@dpdk.org > Cc: Fu, Qi > Subject: RE: [dts] [PATCH 08/17] tests/TestSuite_ipgre: add carlsville=20 > to support nic of ipgre >=20 > Have your leader review your source code? Below checking syntax is=20 > wrong >=20 >=20 > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of qifu > > Sent: Monday, August 19, 2019 7:06 PM > > To: dts@dpdk.org > > Cc: Fu, Qi > > Subject: [dts] [PATCH 08/17] tests/TestSuite_ipgre: add carlsville=20 > > to support nic of ipgre > > > > Add carlsville to support nic of ipgre. > > Signed-off-by: qifu > > --- > > tests/TestSuite_ipgre.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py=20 > > index > > 6f465fa..04fd651 100644 > > --- a/tests/TestSuite_ipgre.py > > +++ b/tests/TestSuite_ipgre.py > > @@ -63,7 +63,7 @@ class TestIpgre(TestCase): > > """ > > self.printFlag =3D self._enable_debug > > ports =3D self.dut.get_ports() > > - self.verify(self.nic.startswith("fortville"), > > + self.verify(self.nic.startswith("fortville" and=20 > > + "carlsville"), > > "GRE tunnel packet type only support by Fortville"= ) > > self.verify(len(ports) >=3D 1, "Insufficient ports for testing= ") > > valports =3D [_ for _ in ports if=20 > > self.tester.get_local_port(_) !=3D -1] > > -- > > 2.17.1