From: Lijuan Tu <lijuan.tu@intel.com>
To: yaobing <bingx.y.yao@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V3] tests/hotplug:dpdk script has changed its message
Date: Thu, 8 Nov 2018 01:58:53 +0800 [thread overview]
Message-ID: <14a42668-7647-726d-1ff7-9159f0f91ce5@intel.com> (raw)
In-Reply-To: <1541575685-30993-1-git-send-email-bingx.y.yao@intel.com>
Applied, thanks
On 2018年11月07日 15:28, yaobing wrote:
> In commit 3f4a837047ba67(app/test-pmd:allow detaching a port not closed)
> dpdk/app/test-pmd/testpmd.c change its return message from 'Please close
> port first' to 'Port not stopped',update dts script to align this change.
>
> Signed-off-by: yaobing <bingx.y.yao@intel.com>
> ---
> tests/TestSuite_hotplug.py | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/TestSuite_hotplug.py b/tests/TestSuite_hotplug.py
> index 7d63b71..5528a22 100644
> --- a/tests/TestSuite_hotplug.py
> +++ b/tests/TestSuite_hotplug.py
> @@ -101,13 +101,13 @@ class TestPortHotPlug(TestCase):
> self.dut.close_session(session_secondary)
> self.attach(self.port)
> self.dut.send_expect("start","testpmd>",60)
> - self.dut.send_expect("port detach %s" % self.port,"Please close port first",60)
> + self.dut.send_expect("port detach %s" % self.port,"Port not stopped",60)
> self.dut.send_expect("stop","testpmd>",60)
> self.detach(self.port)
> self.attach(self.port)
>
> self.dut.send_expect("start","testpmd>",60)
> - self.dut.send_expect("port detach %s" % self.port,"Please close port first",60)
> + self.dut.send_expect("port detach %s" % self.port,"Port not stopped",60)
> self.dut.send_expect("clear port stats %s" % self.port ,"testpmd>",60)
> self.send_packet(self.port)
> out = self.dut.send_expect("show port stats %s" % self.port ,"testpmd>",60)
> @@ -140,7 +140,7 @@ class TestPortHotPlug(TestCase):
> self.attach(self.port)
>
> self.dut.send_expect("start","testpmd>",60)
> - self.dut.send_expect("port detach %s" % self.port, "Please close port first",60)
> + self.dut.send_expect("port detach %s" % self.port, "Port not stopped",60)
> self.dut.send_expect("clear port stats %s" % self.port ,"testpmd>",60)
> self.send_packet(self.port)
> out = self.dut.send_expect("show port stats %s" % self.port ,"testpmd>",60)
prev parent reply other threads:[~2018-11-07 9:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 7:28 yaobing
2018-11-07 17:58 ` Lijuan Tu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14a42668-7647-726d-1ff7-9159f0f91ce5@intel.com \
--to=lijuan.tu@intel.com \
--cc=bingx.y.yao@intel.com \
--cc=dts@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).