test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V3] tests/hotplug:dpdk script has changed its message
@ 2018-11-07  7:28 yaobing
  2018-11-07 17:58 ` Lijuan Tu
  0 siblings, 1 reply; 2+ messages in thread
From: yaobing @ 2018-11-07  7:28 UTC (permalink / raw)
  To: dts; +Cc: yaobing

In commit 3f4a837047ba67(app/test-pmd:allow detaching a port not closed)
dpdk/app/test-pmd/testpmd.c change its return message from 'Please close 
port first' to 'Port not stopped',update dts script to align this change.

Signed-off-by: yaobing <bingx.y.yao@intel.com>
---
 tests/TestSuite_hotplug.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_hotplug.py b/tests/TestSuite_hotplug.py
index 7d63b71..5528a22 100644
--- a/tests/TestSuite_hotplug.py
+++ b/tests/TestSuite_hotplug.py
@@ -101,13 +101,13 @@ class TestPortHotPlug(TestCase):
         self.dut.close_session(session_secondary)
         self.attach(self.port)
         self.dut.send_expect("start","testpmd>",60)
-        self.dut.send_expect("port detach %s" % self.port,"Please close port first",60)
+        self.dut.send_expect("port detach %s" % self.port,"Port not stopped",60)
         self.dut.send_expect("stop","testpmd>",60)
         self.detach(self.port)
         self.attach(self.port)
    
         self.dut.send_expect("start","testpmd>",60)
-        self.dut.send_expect("port detach %s" % self.port,"Please close port first",60)
+        self.dut.send_expect("port detach %s" % self.port,"Port not stopped",60)
         self.dut.send_expect("clear port stats %s" % self.port ,"testpmd>",60)
         self.send_packet(self.port)
         out = self.dut.send_expect("show port stats %s" % self.port ,"testpmd>",60)
@@ -140,7 +140,7 @@ class TestPortHotPlug(TestCase):
         self.attach(self.port)
 
         self.dut.send_expect("start","testpmd>",60)
-        self.dut.send_expect("port detach %s" % self.port, "Please close port first",60)
+        self.dut.send_expect("port detach %s" % self.port, "Port not stopped",60)
         self.dut.send_expect("clear port stats %s" % self.port ,"testpmd>",60)
         self.send_packet(self.port)
         out = self.dut.send_expect("show port stats %s" % self.port ,"testpmd>",60)
-- 
2.17.2

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V3] tests/hotplug:dpdk script has changed its message
  2018-11-07  7:28 [dts] [PATCH V3] tests/hotplug:dpdk script has changed its message yaobing
@ 2018-11-07 17:58 ` Lijuan Tu
  0 siblings, 0 replies; 2+ messages in thread
From: Lijuan Tu @ 2018-11-07 17:58 UTC (permalink / raw)
  To: yaobing, dts

Applied, thanks


On 2018年11月07日 15:28, yaobing wrote:
> In commit 3f4a837047ba67(app/test-pmd:allow detaching a port not closed)
> dpdk/app/test-pmd/testpmd.c change its return message from 'Please close
> port first' to 'Port not stopped',update dts script to align this change.
>
> Signed-off-by: yaobing <bingx.y.yao@intel.com>
> ---
>   tests/TestSuite_hotplug.py | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/TestSuite_hotplug.py b/tests/TestSuite_hotplug.py
> index 7d63b71..5528a22 100644
> --- a/tests/TestSuite_hotplug.py
> +++ b/tests/TestSuite_hotplug.py
> @@ -101,13 +101,13 @@ class TestPortHotPlug(TestCase):
>           self.dut.close_session(session_secondary)
>           self.attach(self.port)
>           self.dut.send_expect("start","testpmd>",60)
> -        self.dut.send_expect("port detach %s" % self.port,"Please close port first",60)
> +        self.dut.send_expect("port detach %s" % self.port,"Port not stopped",60)
>           self.dut.send_expect("stop","testpmd>",60)
>           self.detach(self.port)
>           self.attach(self.port)
>      
>           self.dut.send_expect("start","testpmd>",60)
> -        self.dut.send_expect("port detach %s" % self.port,"Please close port first",60)
> +        self.dut.send_expect("port detach %s" % self.port,"Port not stopped",60)
>           self.dut.send_expect("clear port stats %s" % self.port ,"testpmd>",60)
>           self.send_packet(self.port)
>           out = self.dut.send_expect("show port stats %s" % self.port ,"testpmd>",60)
> @@ -140,7 +140,7 @@ class TestPortHotPlug(TestCase):
>           self.attach(self.port)
>   
>           self.dut.send_expect("start","testpmd>",60)
> -        self.dut.send_expect("port detach %s" % self.port, "Please close port first",60)
> +        self.dut.send_expect("port detach %s" % self.port, "Port not stopped",60)
>           self.dut.send_expect("clear port stats %s" % self.port ,"testpmd>",60)
>           self.send_packet(self.port)
>           out = self.dut.send_expect("show port stats %s" % self.port ,"testpmd>",60)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-11-07  9:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-07  7:28 [dts] [PATCH V3] tests/hotplug:dpdk script has changed its message yaobing
2018-11-07 17:58 ` Lijuan Tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).