From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C0CD1239 for ; Wed, 7 Nov 2018 10:31:00 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Nov 2018 01:30:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,475,1534834800"; d="scan'208";a="105997053" Received: from dts-maintain.sh.intel.com (HELO [10.67.119.110]) ([10.67.119.110]) by fmsmga001.fm.intel.com with ESMTP; 07 Nov 2018 01:30:58 -0800 To: yaobing , dts@dpdk.org References: <1541575685-30993-1-git-send-email-bingx.y.yao@intel.com> From: Lijuan Tu Message-ID: <14a42668-7647-726d-1ff7-9159f0f91ce5@intel.com> Date: Thu, 8 Nov 2018 01:58:53 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1541575685-30993-1-git-send-email-bingx.y.yao@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dts] [PATCH V3] tests/hotplug:dpdk script has changed its message X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2018 09:31:01 -0000 Applied, thanks On 2018年11月07日 15:28, yaobing wrote: > In commit 3f4a837047ba67(app/test-pmd:allow detaching a port not closed) > dpdk/app/test-pmd/testpmd.c change its return message from 'Please close > port first' to 'Port not stopped',update dts script to align this change. > > Signed-off-by: yaobing > --- > tests/TestSuite_hotplug.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tests/TestSuite_hotplug.py b/tests/TestSuite_hotplug.py > index 7d63b71..5528a22 100644 > --- a/tests/TestSuite_hotplug.py > +++ b/tests/TestSuite_hotplug.py > @@ -101,13 +101,13 @@ class TestPortHotPlug(TestCase): > self.dut.close_session(session_secondary) > self.attach(self.port) > self.dut.send_expect("start","testpmd>",60) > - self.dut.send_expect("port detach %s" % self.port,"Please close port first",60) > + self.dut.send_expect("port detach %s" % self.port,"Port not stopped",60) > self.dut.send_expect("stop","testpmd>",60) > self.detach(self.port) > self.attach(self.port) > > self.dut.send_expect("start","testpmd>",60) > - self.dut.send_expect("port detach %s" % self.port,"Please close port first",60) > + self.dut.send_expect("port detach %s" % self.port,"Port not stopped",60) > self.dut.send_expect("clear port stats %s" % self.port ,"testpmd>",60) > self.send_packet(self.port) > out = self.dut.send_expect("show port stats %s" % self.port ,"testpmd>",60) > @@ -140,7 +140,7 @@ class TestPortHotPlug(TestCase): > self.attach(self.port) > > self.dut.send_expect("start","testpmd>",60) > - self.dut.send_expect("port detach %s" % self.port, "Please close port first",60) > + self.dut.send_expect("port detach %s" % self.port, "Port not stopped",60) > self.dut.send_expect("clear port stats %s" % self.port ,"testpmd>",60) > self.send_packet(self.port) > out = self.dut.send_expect("show port stats %s" % self.port ,"testpmd>",60)