From: michael.luo@intel.com
To: dts@dpdk.org
Cc: yong.liu@intel.com
Subject: [dts] [PATCH v2] tests/pmdrss_hash: check reta_lines before verifying the result
Date: Wed, 28 Feb 2018 18:15:23 +0800 [thread overview]
Message-ID: <1519812923-77663-1-git-send-email-michael.luo@intel.com> (raw)
In-Reply-To: <1518087481-53786-1-git-send-email-michael.luo@intel.com>
From: Luo Gaoliang <michael.luo@intel.com>
If reta_lines was empty, DTS shows the test case passed still.
So add the checking of "reta_lines" before verifying result.
And changing the variable "reta_lines" as an argument of verify function
rather than a global variable.
Signed-off-by: Luo Gaoliang <michael.luo@intel.com>
---
| 25 ++++++++++++-------------
1 file changed, 12 insertions(+), 13 deletions(-)
--git a/tests/TestSuite_pmdrss_hash.py b/tests/TestSuite_pmdrss_hash.py
index 728c427..07c47b4 100644
--- a/tests/TestSuite_pmdrss_hash.py
+++ b/tests/TestSuite_pmdrss_hash.py
@@ -43,7 +43,6 @@ import utils
testQueues = [16]
reta_entries = []
-reta_lines = []
reta_num = 128
# Use scapy to send packets with different source and dest ip.
# and collect the hash result of five tuple and the queue id.
@@ -61,7 +60,7 @@ class TestPmdrssHash(TestCase):
"""
Sends packets.
"""
- global reta_lines
+ received_pkts = []
self.tester.scapy_foreground()
self.dut.send_expect("start", "testpmd>")
mac = self.dut.get_mac_address(0)
@@ -172,18 +171,18 @@ class TestPmdrssHash(TestCase):
name, value = item.split("=", 1)
reta_line[name.strip()] = value.strip()
- reta_lines.append(reta_line)
+ received_pkts.append(reta_line)
- self.verifyResult()
+ self.verifyResult(received_pkts)
- def verifyResult(self):
+ def verifyResult(self, reta_lines):
"""
Verify whether or not the result passes.
"""
- global reta_lines
global reta_num
result = []
+ self.verify(len(reta_lines) > 0, 'No packet received!')
self.result_table_create(
['packet index', 'hash value', 'hash index', 'queue id', 'actual queue id', 'pass '])
@@ -205,14 +204,13 @@ class TestPmdrssHash(TestCase):
i = i + 1
self.result_table_print()
- reta_lines = []
self.verify(sum(result) == 0, "the reta update function failed!")
def send_packet_symmetric(self, itf, tran_type):
"""
Sends packets.
"""
- global reta_lines
+ received_pkts = []
self.tester.scapy_foreground()
self.dut.send_expect("start", "testpmd>")
mac = self.dut.get_mac_address(0)
@@ -370,20 +368,22 @@ class TestPmdrssHash(TestCase):
item = item.strip()
if(item.startswith("RSS hash")):
name, value = item.split("=", 1)
+ else:
+ continue
reta_line[name.strip()] = value.strip()
- reta_lines.append(reta_line)
+ received_pkts.append(reta_line)
- self.verifyResult_symmetric()
+ self.verifyResult_symmetric(received_pkts)
- def verifyResult_symmetric(self):
+ def verifyResult_symmetric(self, reta_lines):
"""
Verify whether or not the result passes.
"""
- global reta_lines
global reta_num
result = []
+ self.verify(len(reta_lines) > 0, 'No packet received!')
self.result_table_create(
['packet index', 'RSS hash', 'hash index', 'queue id', 'actual queue id', 'pass '])
@@ -407,7 +407,6 @@ class TestPmdrssHash(TestCase):
i = i + 1
self.result_table_print()
- reta_lines = []
self.verify(
sum(result) == 0, "the symmetric RSS hash function failed!")
--
2.7.4
next prev parent reply other threads:[~2018-02-28 2:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 10:58 [dts] [PATCH] " michael.luo
2018-02-11 1:38 ` Liu, Yong
2018-02-28 10:15 ` michael.luo [this message]
2018-03-02 10:15 ` [dts] [PATCH v2] " Liu, Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519812923-77663-1-git-send-email-michael.luo@intel.com \
--to=michael.luo@intel.com \
--cc=dts@dpdk.org \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).