[dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case failures in vf_reset

[dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case failures in vf_reset

[Joyce Kong]

Clear port stats before counting port info

Signed-off-by: Joyce Kong <joyce.kong@arm.com>
---
 tests/TestSuite_vf_packet_rxtx.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/TestSuite_vf_packet_rxtx.py b/tests/TestSuite_vf_packet_rxtx.py
index 63f4820..6a29d23 100644
--- a/tests/TestSuite_vf_packet_rxtx.py
+++ b/tests/TestSuite_vf_packet_rxtx.py
@@ -279,6 +279,7 @@ class TestVfPacketRxtx(TestCase):
         rx_port = tx_port
 
         dst_mac = pmd0_vf0_mac
+        self.vm0_testpmd.execute_cmd('clear port stats all')
         self.tester.sendpkt_bg(tx_port, dst_mac)
 
         #vf port stop/start can trigger reset action
-- 
1.8.3.1

[dts] [PATCH 2/2] framework/virt_dut: ensure igb_uio installed

[Joyce Kong]

Ensure igb_uio driver is installed if driver='igb_uio'

Signed-off-by: Joyce Kong <joyce.kong@arm.com>
---
 framework/virt_dut.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/framework/virt_dut.py b/framework/virt_dut.py
index 62688dc..91620ef 100644
--- a/framework/virt_dut.py
+++ b/framework/virt_dut.py
@@ -153,6 +153,9 @@ class VirtDut(DPDKdut):
         self.setup_modules(target)
 
         if bind_dev:
+            self.send_expect('(lsmod | grep uio) | modprobe uio', '#')
+            self.send_expect('(lsmod | grep igb_uio)
+                             | insmod ./%s/kmod/igb_uio.ko' % target,'#')
             self.bind_interfaces_linux('igb_uio')
 
     def prerequisites(self, pkgName, patch, autodetect_topo):
-- 
1.8.3.1

Re: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case failures in vf_reset

[Joyce Kong]

Hi Marvin,

DUT PF would send dhcp protocol packet to VF before tester transmission, and that's why we need to clear ports  at the start.

Best Regards，
Joyce

-----Original Message-----
From: Liu, Yong [mailto:yong.liu@intel.com]
Sent: Thursday, March 8, 2018 11:37 AM
To: Joyce Kong <Joyce.Kong@arm.com>; dts@dpdk.org
Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
Subject: RE: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case failures in vf_reset

Hi Joyce,
Could you please figure out why need to clean the counter before tester transmission? It should be no packet sent to VF before that moment.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Joyce Kong
> Sent: Tuesday, March 06, 2018 3:47 PM
> To: dts@dpdk.org
> Cc: Joyce Kong <joyce.kong@arm.com>
> Subject: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case
> failures in vf_reset
>
> Clear port stats before counting port info
>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> ---
>  tests/TestSuite_vf_packet_rxtx.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/TestSuite_vf_packet_rxtx.py
> b/tests/TestSuite_vf_packet_rxtx.py
> index 63f4820..6a29d23 100644
> --- a/tests/TestSuite_vf_packet_rxtx.py
> +++ b/tests/TestSuite_vf_packet_rxtx.py
> @@ -279,6 +279,7 @@ class TestVfPacketRxtx(TestCase):
>          rx_port = tx_port
>
>          dst_mac = pmd0_vf0_mac
> +        self.vm0_testpmd.execute_cmd('clear port stats all')
>          self.tester.sendpkt_bg(tx_port, dst_mac)
>
>          #vf port stop/start can trigger reset action
> --
> 1.8.3.1

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case failures in vf_reset

[Liu, Yong]

Joyce,
There's still some kind of possibility that PF will transmit packets in the test which will cause unexpected result.
It's better to disable network-manager on the PF device. But if this solution is workable for you, I can also merge it.

Thanks,
Marvin

> -----Original Message-----
> From: Joyce Kong [mailto:Joyce.Kong@arm.com]
> Sent: Friday, March 09, 2018 7:39 PM
> To: Liu, Yong <yong.liu@intel.com>; dts@dpdk.org
> Subject: RE: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case
> failures in vf_reset
> 
> Hi Marvin,
> 
> DUT PF would send dhcp protocol packet to VF before tester transmission,
> and that's why we need to clear ports  at the start.
> 
> Best Regards，
> Joyce
> 
> -----Original Message-----
> From: Liu, Yong [mailto:yong.liu@intel.com]
> Sent: Thursday, March 8, 2018 11:37 AM
> To: Joyce Kong <Joyce.Kong@arm.com>; dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: RE: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case
> failures in vf_reset
> 
> Hi Joyce,
> Could you please figure out why need to clean the counter before tester
> transmission? It should be no packet sent to VF before that moment.
> 
> Thanks,
> Marvin
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Joyce Kong
> > Sent: Tuesday, March 06, 2018 3:47 PM
> > To: dts@dpdk.org
> > Cc: Joyce Kong <joyce.kong@arm.com>
> > Subject: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case
> > failures in vf_reset
> >
> > Clear port stats before counting port info
> >
> > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > ---
> >  tests/TestSuite_vf_packet_rxtx.py | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/TestSuite_vf_packet_rxtx.py
> > b/tests/TestSuite_vf_packet_rxtx.py
> > index 63f4820..6a29d23 100644
> > --- a/tests/TestSuite_vf_packet_rxtx.py
> > +++ b/tests/TestSuite_vf_packet_rxtx.py
> > @@ -279,6 +279,7 @@ class TestVfPacketRxtx(TestCase):
> >          rx_port = tx_port
> >
> >          dst_mac = pmd0_vf0_mac
> > +        self.vm0_testpmd.execute_cmd('clear port stats all')
> >          self.tester.sendpkt_bg(tx_port, dst_mac)
> >
> >          #vf port stop/start can trigger reset action
> > --
> > 1.8.3.1
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium. Thank you.

Re: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case failures in vf_reset

[Joyce Kong]

Hi Marvin,

Clearing port stats is valid on most occasions and we can't always ensure to disable all network-manager on PF. Overall there's no harm in doing this.

Thanks & regards，
Joyce

-----Original Message-----
From: Liu, Yong [mailto:yong.liu@intel.com]
Sent: Monday, March 12, 2018 9:39 AM
To: Joyce Kong <Joyce.Kong@arm.com>; dts@dpdk.org
Subject: RE: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case failures in vf_reset

Joyce,
There's still some kind of possibility that PF will transmit packets in the test which will cause unexpected result.
It's better to disable network-manager on the PF device. But if this solution is workable for you, I can also merge it.

Thanks,
Marvin

> -----Original Message-----
> From: Joyce Kong [mailto:Joyce.Kong@arm.com]
> Sent: Friday, March 09, 2018 7:39 PM
> To: Liu, Yong <yong.liu@intel.com>; dts@dpdk.org
> Subject: RE: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case
> failures in vf_reset
>
> Hi Marvin,
>
> DUT PF would send dhcp protocol packet to VF before tester
> transmission, and that's why we need to clear ports  at the start.
>
> Best Regards，
> Joyce
>
> -----Original Message-----
> From: Liu, Yong [mailto:yong.liu@intel.com]
> Sent: Thursday, March 8, 2018 11:37 AM
> To: Joyce Kong <Joyce.Kong@arm.com>; dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: RE: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case
> failures in vf_reset
>
> Hi Joyce,
> Could you please figure out why need to clean the counter before
> tester transmission? It should be no packet sent to VF before that moment.
>
> Thanks,
> Marvin
>
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Joyce Kong
> > Sent: Tuesday, March 06, 2018 3:47 PM
> > To: dts@dpdk.org
> > Cc: Joyce Kong <joyce.kong@arm.com>
> > Subject: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case
> > failures in vf_reset
> >
> > Clear port stats before counting port info
> >
> > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > ---
> >  tests/TestSuite_vf_packet_rxtx.py | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/TestSuite_vf_packet_rxtx.py
> > b/tests/TestSuite_vf_packet_rxtx.py
> > index 63f4820..6a29d23 100644
> > --- a/tests/TestSuite_vf_packet_rxtx.py
> > +++ b/tests/TestSuite_vf_packet_rxtx.py
> > @@ -279,6 +279,7 @@ class TestVfPacketRxtx(TestCase):
> >          rx_port = tx_port
> >
> >          dst_mac = pmd0_vf0_mac
> > +        self.vm0_testpmd.execute_cmd('clear port stats all')
> >          self.tester.sendpkt_bg(tx_port, dst_mac)
> >
> >          #vf port stop/start can trigger reset action
> > --
> > 1.8.3.1
>
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose
> the contents to any other person, use it for any purpose, or store or
> copy the information in any medium. Thank you.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case failures in vf_reset

[Liu, Yong]

Joyce,
Agreed with you, merged first patch into master branch.

Thanks,
Marvin

> -----Original Message-----
> From: Joyce Kong [mailto:Joyce.Kong@arm.com]
> Sent: Monday, March 12, 2018 10:26 AM
> To: Liu, Yong <yong.liu@intel.com>; dts@dpdk.org
> Subject: RE: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case
> failures in vf_reset
> 
> Hi Marvin,
> 
> Clearing port stats is valid on most occasions and we can't always ensure
> to disable all network-manager on PF. Overall there's no harm in doing
> this.
> 
> Thanks & regards，
> Joyce
> 
> -----Original Message-----
> From: Liu, Yong [mailto:yong.liu@intel.com]
> Sent: Monday, March 12, 2018 9:39 AM
> To: Joyce Kong <Joyce.Kong@arm.com>; dts@dpdk.org
> Subject: RE: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case
> failures in vf_reset
> 
> Joyce,
> There's still some kind of possibility that PF will transmit packets in
> the test which will cause unexpected result.
> It's better to disable network-manager on the PF device. But if this
> solution is workable for you, I can also merge it.
> 
> Thanks,
> Marvin
> 
> > -----Original Message-----
> > From: Joyce Kong [mailto:Joyce.Kong@arm.com]
> > Sent: Friday, March 09, 2018 7:39 PM
> > To: Liu, Yong <yong.liu@intel.com>; dts@dpdk.org
> > Subject: RE: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case
> > failures in vf_reset
> >
> > Hi Marvin,
> >
> > DUT PF would send dhcp protocol packet to VF before tester
> > transmission, and that's why we need to clear ports  at the start.
> >
> > Best Regards，
> > Joyce
> >
> > -----Original Message-----
> > From: Liu, Yong [mailto:yong.liu@intel.com]
> > Sent: Thursday, March 8, 2018 11:37 AM
> > To: Joyce Kong <Joyce.Kong@arm.com>; dts@dpdk.org
> > Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> > Subject: RE: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case
> > failures in vf_reset
> >
> > Hi Joyce,
> > Could you please figure out why need to clean the counter before
> > tester transmission? It should be no packet sent to VF before that
> moment.
> >
> > Thanks,
> > Marvin
> >
> > > -----Original Message-----
> > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Joyce Kong
> > > Sent: Tuesday, March 06, 2018 3:47 PM
> > > To: dts@dpdk.org
> > > Cc: Joyce Kong <joyce.kong@arm.com>
> > > Subject: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case
> > > failures in vf_reset
> > >
> > > Clear port stats before counting port info
> > >
> > > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > > ---
> > >  tests/TestSuite_vf_packet_rxtx.py | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/tests/TestSuite_vf_packet_rxtx.py
> > > b/tests/TestSuite_vf_packet_rxtx.py
> > > index 63f4820..6a29d23 100644
> > > --- a/tests/TestSuite_vf_packet_rxtx.py
> > > +++ b/tests/TestSuite_vf_packet_rxtx.py
> > > @@ -279,6 +279,7 @@ class TestVfPacketRxtx(TestCase):
> > >          rx_port = tx_port
> > >
> > >          dst_mac = pmd0_vf0_mac
> > > +        self.vm0_testpmd.execute_cmd('clear port stats all')
> > >          self.tester.sendpkt_bg(tx_port, dst_mac)
> > >
> > >          #vf port stop/start can trigger reset action
> > > --
> > > 1.8.3.1
> >
> > IMPORTANT NOTICE: The contents of this email and any attachments are
> > confidential and may also be privileged. If you are not the intended
> > recipient, please notify the sender immediately and do not disclose
> > the contents to any other person, use it for any purpose, or store or
> > copy the information in any medium. Thank you.
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium. Thank you.

[dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case failures in vf_reset

[Joyce Kong]

Clear port stats before counting port info

Signed-off-by: Joyce Kong <joyce.kong@arm.com>
---
 tests/TestSuite_vf_packet_rxtx.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/TestSuite_vf_packet_rxtx.py b/tests/TestSuite_vf_packet_rxtx.py
index 63f4820..6a29d23 100644
--- a/tests/TestSuite_vf_packet_rxtx.py
+++ b/tests/TestSuite_vf_packet_rxtx.py
@@ -279,6 +279,7 @@ class TestVfPacketRxtx(TestCase):
         rx_port = tx_port
 
         dst_mac = pmd0_vf0_mac
+        self.vm0_testpmd.execute_cmd('clear port stats all')
         self.tester.sendpkt_bg(tx_port, dst_mac)
 
         #vf port stop/start can trigger reset action
-- 
1.8.3.1

Re: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case failures in vf_reset

[Liu, Yong]

Hi Joyce,
Could you please figure out why need to clean the counter before tester transmission? It should be no packet sent to VF before that moment. 

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Joyce Kong
> Sent: Tuesday, March 06, 2018 3:47 PM
> To: dts@dpdk.org
> Cc: Joyce Kong <joyce.kong@arm.com>
> Subject: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case failures in
> vf_reset
> 
> Clear port stats before counting port info
> 
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> ---
>  tests/TestSuite_vf_packet_rxtx.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/TestSuite_vf_packet_rxtx.py
> b/tests/TestSuite_vf_packet_rxtx.py
> index 63f4820..6a29d23 100644
> --- a/tests/TestSuite_vf_packet_rxtx.py
> +++ b/tests/TestSuite_vf_packet_rxtx.py
> @@ -279,6 +279,7 @@ class TestVfPacketRxtx(TestCase):
>          rx_port = tx_port
> 
>          dst_mac = pmd0_vf0_mac
> +        self.vm0_testpmd.execute_cmd('clear port stats all')
>          self.tester.sendpkt_bg(tx_port, dst_mac)
> 
>          #vf port stop/start can trigger reset action
> --
> 1.8.3.1

[dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case failures in vf_reset

[Joyce Kong]

Clear port stats before counting port info

Signed-off-by: Joyce Kong <joyce.kong@arm.com>
---
 tests/TestSuite_vf_packet_rxtx.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/TestSuite_vf_packet_rxtx.py b/tests/TestSuite_vf_packet_rxtx.py
index 63f4820..6a29d23 100644
--- a/tests/TestSuite_vf_packet_rxtx.py
+++ b/tests/TestSuite_vf_packet_rxtx.py
@@ -279,6 +279,7 @@ class TestVfPacketRxtx(TestCase):
         rx_port = tx_port
 
         dst_mac = pmd0_vf0_mac
+        self.vm0_testpmd.execute_cmd('clear port stats all')
         self.tester.sendpkt_bg(tx_port, dst_mac)
 
         #vf port stop/start can trigger reset action
-- 
1.8.3.1

[dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case failures in vf_reset

[Joyce Kong]

Clear port stats before counting port info

Signed-off-by: Joyce Kong <joyce.kong@arm.com>
---
 tests/TestSuite_vf_packet_rxtx.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/TestSuite_vf_packet_rxtx.py b/tests/TestSuite_vf_packet_rxtx.py
index 63f4820..6a29d23 100644
--- a/tests/TestSuite_vf_packet_rxtx.py
+++ b/tests/TestSuite_vf_packet_rxtx.py
@@ -279,6 +279,7 @@ class TestVfPacketRxtx(TestCase):
         rx_port = tx_port
 
         dst_mac = pmd0_vf0_mac
+        self.vm0_testpmd.execute_cmd('clear port stats all')
         self.tester.sendpkt_bg(tx_port, dst_mac)
 
         #vf port stop/start can trigger reset action
-- 
1.8.3.1

[dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case failures in vf_reset

[Joyce Kong]

Clear port stats before counting port info

Signed-off-by: Joyce Kong <joyce.kong@arm.com>
---
 tests/TestSuite_vf_packet_rxtx.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/TestSuite_vf_packet_rxtx.py b/tests/TestSuite_vf_packet_rxtx.py
index 63f4820..6a29d23 100644
--- a/tests/TestSuite_vf_packet_rxtx.py
+++ b/tests/TestSuite_vf_packet_rxtx.py
@@ -279,6 +279,7 @@ class TestVfPacketRxtx(TestCase):
         rx_port = tx_port
 
         dst_mac = pmd0_vf0_mac
+        self.vm0_testpmd.execute_cmd('clear port stats all')
         self.tester.sendpkt_bg(tx_port, dst_mac)
 
         #vf port stop/start can trigger reset action
-- 
1.8.3.1