test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/TestSuite_short_live.py:Delay repair on start_up_time.
@ 2018-03-15  2:25 zhu,shuai
  0 siblings, 0 replies; 3+ messages in thread
From: zhu,shuai @ 2018-03-15  2:25 UTC (permalink / raw)
  To: dts; +Cc: zhu,shuai

As DPDK will capture signals, " SIGTERM" and "SIGINT", it needs some time to prepare to exit.

Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_short_live.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/TestSuite_short_live.py b/tests/TestSuite_short_live.py
index 62c43a5..238e3ab 100644
--- a/tests/TestSuite_short_live.py
+++ b/tests/TestSuite_short_live.py
@@ -162,6 +162,7 @@ class TestShortLiveApp(TestCase):
                 self.dut.send_expect("pkill -2 testpmd", "#", 60, True)
             else:
                 self.dut.send_expect("pkill -15 testpmd", "#", 60, True)
+            time.sleep(2)
 
     def test_clean_up_with_signal_l2fwd(self):
         repeat_time = 5
-- 
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/TestSuite_short_live.py:Delay repair on start_up_time.
  2018-03-14  7:02 zhu,shuai
@ 2018-03-14  9:34 ` Tu, LijuanX A
  0 siblings, 0 replies; 3+ messages in thread
From: Tu, LijuanX A @ 2018-03-14  9:34 UTC (permalink / raw)
  To: Zhu, ShuaiX, dts; +Cc: Zhu, ShuaiX

As DPDK will capture signals, " SIGTERM" and "SIGINT", it needs some time to prepare to exit.

Hi shuai,
Could you make your code more succinctly?


Code may be simple
-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
Sent: Wednesday, March 14, 2018 3:03 PM
To: dts@dpdk.org
Cc: Zhu, ShuaiX <shuaix.zhu@intel.com>
Subject: [dts] [PATCH V1] tests/TestSuite_short_live.py:Delay repair on start_up_time.

I think it is because case has delayed after killing testpmd, resulting in no release resources.

Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_short_live.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/TestSuite_short_live.py b/tests/TestSuite_short_live.py index 62c43a5..8d1d847 100644
--- a/tests/TestSuite_short_live.py
+++ b/tests/TestSuite_short_live.py
@@ -160,8 +160,10 @@ class TestShortLiveApp(TestCase):
             # kill with differen Signal
             if i%2 == 0:
                 self.dut.send_expect("pkill -2 testpmd", "#", 60, True)
+                time.sleep(2)
             else:
                 self.dut.send_expect("pkill -15 testpmd", "#", 60, True)
+                time.sleep(2)
 
     def test_clean_up_with_signal_l2fwd(self):
         repeat_time = 5
--
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1] tests/TestSuite_short_live.py:Delay repair on start_up_time.
@ 2018-03-14  7:02 zhu,shuai
  2018-03-14  9:34 ` Tu, LijuanX A
  0 siblings, 1 reply; 3+ messages in thread
From: zhu,shuai @ 2018-03-14  7:02 UTC (permalink / raw)
  To: dts; +Cc: zhu,shuai

I think it is because case has delayed after killing testpmd, resulting in no release resources.

Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_short_live.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/TestSuite_short_live.py b/tests/TestSuite_short_live.py
index 62c43a5..8d1d847 100644
--- a/tests/TestSuite_short_live.py
+++ b/tests/TestSuite_short_live.py
@@ -160,8 +160,10 @@ class TestShortLiveApp(TestCase):
             # kill with differen Signal
             if i%2 == 0:
                 self.dut.send_expect("pkill -2 testpmd", "#", 60, True)
+                time.sleep(2)
             else:
                 self.dut.send_expect("pkill -15 testpmd", "#", 60, True)
+                time.sleep(2)
 
     def test_clean_up_with_signal_l2fwd(self):
         repeat_time = 5
-- 
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-03-15  2:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-15  2:25 [dts] [PATCH V1] tests/TestSuite_short_live.py:Delay repair on start_up_time zhu,shuai
  -- strict thread matches above, loose matches on Subject: below --
2018-03-14  7:02 zhu,shuai
2018-03-14  9:34 ` Tu, LijuanX A

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).