* [dts] [PATCH V1] tests/generic_filter: fix 128 queues failed
@ 2018-03-15 7:18 lu,peipei
0 siblings, 0 replies; 6+ messages in thread
From: lu,peipei @ 2018-03-15 7:18 UTC (permalink / raw)
To: dts; +Cc: lu,peipei
remove parameter "--total-num-mbufs". the total_mbufs default was 128. please refer to dpdk fadd37f.
Signed-off-by: lu,peipei <peipeix.lu@intel.com>
---
tests/TestSuite_generic_filter.py | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tests/TestSuite_generic_filter.py b/tests/TestSuite_generic_filter.py
index e62e351..c1901ac 100644
--- a/tests/TestSuite_generic_filter.py
+++ b/tests/TestSuite_generic_filter.py
@@ -693,10 +693,8 @@ class TestGeneric_filter(TestCase):
if self.kdriver == "ixgbe":
self.dut.send_expect("sed -i -e 's/#define IXGBE_NONE_MODE_TX_NB_QUEUES 64$/#define IXGBE_NONE_MODE_TX_NB_QUEUES 128/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
self.dut.build_install_dpdk(self.target)
- global valports
- total_mbufs = self.request_mbufs(128) * len(valports)
self.pmdout.start_testpmd(
- "all", "--disable-rss --rxq=128 --txq=128 --portmask=%s --nb-cores=4 --total-num-mbufs=%d" % (portMask, total_mbufs))
+ "all", "--disable-rss --rxq=128 --txq=128 --portmask=%s --nb-cores=4" % portMask )
self.dut.send_expect(
"set stat_qmap rx %s 0 0" % valports[0], "testpmd> ")
self.dut.send_expect(
--
1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread* [dts] [PATCH V1] tests/generic_filter:fix 128 queues failed
@ 2018-03-21 9:23 lu,peipei
2018-03-23 10:07 ` Liu, Yong
0 siblings, 1 reply; 6+ messages in thread
From: lu,peipei @ 2018-03-21 9:23 UTC (permalink / raw)
To: dts; +Cc: lu,peipei
increase mbufs size to 1024. please refer to bd8f10f6d
Signed-off-by: lu,peipei <peipeix.lu@intel.com>
---
tests/TestSuite_generic_filter.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/TestSuite_generic_filter.py b/tests/TestSuite_generic_filter.py
index e62e351..e69246b 100644
--- a/tests/TestSuite_generic_filter.py
+++ b/tests/TestSuite_generic_filter.py
@@ -75,7 +75,7 @@ class TestGeneric_filter(TestCase):
"""
default txq/rxq descriptor is 64
"""
- return 128 * queue_num + 512
+ return 1024 * queue_num + 512
def port_config(self):
"""
--
1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dts] [PATCH V1] tests/generic_filter:fix 128 queues failed
2018-03-21 9:23 [dts] [PATCH V1] tests/generic_filter:fix " lu,peipei
@ 2018-03-23 10:07 ` Liu, Yong
0 siblings, 0 replies; 6+ messages in thread
From: Liu, Yong @ 2018-03-23 10:07 UTC (permalink / raw)
To: lu,peipei, dts
Peipei,
Merge into master branch. Since this is V2 version of your patch, please
change the title accordingly.
And what mentioned in commit log should be "rxq descriptor number" not
"mbufs size", they have different concepts.
Thanks,
Marvin
On 03/21/2018 05:23 PM, lu,peipei wrote:
> increase mbufs size to 1024. please refer to bd8f10f6d
>
> Signed-off-by: lu,peipei<peipeix.lu@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dts] [PATCH V1] tests/generic_filter: fix 128 queues failed
@ 2018-03-15 6:17 lu,peipei
2018-03-15 6:37 ` Tu, LijuanX A
2018-03-19 8:07 ` Liu, Yong
0 siblings, 2 replies; 6+ messages in thread
From: lu,peipei @ 2018-03-15 6:17 UTC (permalink / raw)
To: dts; +Cc: lu,peipei
remove parameter "--total-num-mbufs". the total_mbufs default was 128. please refer to dpdk fadd37f.
Signed-off-by: lu,peipei <peipeix.lu@intel.com>
---
tests/TestSuite_generic_filter.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/TestSuite_generic_filter.py b/tests/TestSuite_generic_filter.py
index e62e351..276c10f 100644
--- a/tests/TestSuite_generic_filter.py
+++ b/tests/TestSuite_generic_filter.py
@@ -696,7 +696,7 @@ class TestGeneric_filter(TestCase):
global valports
total_mbufs = self.request_mbufs(128) * len(valports)
self.pmdout.start_testpmd(
- "all", "--disable-rss --rxq=128 --txq=128 --portmask=%s --nb-cores=4 --total-num-mbufs=%d" % (portMask, total_mbufs))
+ "all", "--disable-rss --rxq=128 --txq=128 --portmask=%s --nb-cores=4" % portMask)
self.dut.send_expect(
"set stat_qmap rx %s 0 0" % valports[0], "testpmd> ")
self.dut.send_expect(
--
1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dts] [PATCH V1] tests/generic_filter: fix 128 queues failed
2018-03-15 6:17 [dts] [PATCH V1] tests/generic_filter: fix " lu,peipei
@ 2018-03-15 6:37 ` Tu, LijuanX A
2018-03-19 8:07 ` Liu, Yong
1 sibling, 0 replies; 6+ messages in thread
From: Tu, LijuanX A @ 2018-03-15 6:37 UTC (permalink / raw)
To: Lu, PeipeiX, dts; +Cc: Lu, PeipeiX
Hi peipei,
I think redundant code should be also removed ,when removing the parameter.
-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lu,peipei
Sent: Thursday, March 15, 2018 2:18 PM
To: dts@dpdk.org
Cc: Lu, PeipeiX <peipeix.lu@intel.com>
Subject: [dts] [PATCH V1] tests/generic_filter: fix 128 queues failed
remove parameter "--total-num-mbufs". the total_mbufs default was 128. please refer to dpdk fadd37f.
Signed-off-by: lu,peipei <peipeix.lu@intel.com>
---
tests/TestSuite_generic_filter.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/TestSuite_generic_filter.py b/tests/TestSuite_generic_filter.py
index e62e351..276c10f 100644
--- a/tests/TestSuite_generic_filter.py
+++ b/tests/TestSuite_generic_filter.py
@@ -696,7 +696,7 @@ class TestGeneric_filter(TestCase):
global valports
total_mbufs = self.request_mbufs(128) * len(valports)
self.pmdout.start_testpmd(
- "all", "--disable-rss --rxq=128 --txq=128 --portmask=%s --nb-cores=4 --total-num-mbufs=%d" % (portMask, total_mbufs))
+ "all", "--disable-rss --rxq=128 --txq=128 --portmask=%s --nb-cores=4" % portMask)
self.dut.send_expect(
"set stat_qmap rx %s 0 0" % valports[0], "testpmd> ")
self.dut.send_expect(
--
1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dts] [PATCH V1] tests/generic_filter: fix 128 queues failed
2018-03-15 6:17 [dts] [PATCH V1] tests/generic_filter: fix " lu,peipei
2018-03-15 6:37 ` Tu, LijuanX A
@ 2018-03-19 8:07 ` Liu, Yong
1 sibling, 0 replies; 6+ messages in thread
From: Liu, Yong @ 2018-03-19 8:07 UTC (permalink / raw)
To: Lu, PeipeiX, dts; +Cc: Lu, PeipeiX
Peipei,
I can't find commit fadd37f in dpdk source tree, please double check that.
The number of total mbufs is calculated for 128 queues. I don't think testpmd can start with default mbufs.
Please check whether all queues have been set up.
Thanks,
Marvin
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lu,peipei
> Sent: Thursday, March 15, 2018 2:18 PM
> To: dts@dpdk.org
> Cc: Lu, PeipeiX <peipeix.lu@intel.com>
> Subject: [dts] [PATCH V1] tests/generic_filter: fix 128 queues failed
>
> remove parameter "--total-num-mbufs". the total_mbufs default was 128.
> please refer to dpdk fadd37f.
>
> Signed-off-by: lu,peipei <peipeix.lu@intel.com>
> ---
> tests/TestSuite_generic_filter.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_generic_filter.py
> b/tests/TestSuite_generic_filter.py
> index e62e351..276c10f 100644
> --- a/tests/TestSuite_generic_filter.py
> +++ b/tests/TestSuite_generic_filter.py
> @@ -696,7 +696,7 @@ class TestGeneric_filter(TestCase):
> global valports
> total_mbufs = self.request_mbufs(128) * len(valports)
> self.pmdout.start_testpmd(
> - "all", "--disable-rss --rxq=128 --txq=128 --portmask=%s -
> -nb-cores=4 --total-num-mbufs=%d" % (portMask, total_mbufs))
> + "all", "--disable-rss --rxq=128 --txq=128 --portmask=%s -
> -nb-cores=4" % portMask)
> self.dut.send_expect(
> "set stat_qmap rx %s 0 0" % valports[0], "testpmd> ")
> self.dut.send_expect(
> --
> 1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-03-23 2:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-15 7:18 [dts] [PATCH V1] tests/generic_filter: fix 128 queues failed lu,peipei
-- strict thread matches above, loose matches on Subject: below --
2018-03-21 9:23 [dts] [PATCH V1] tests/generic_filter:fix " lu,peipei
2018-03-23 10:07 ` Liu, Yong
2018-03-15 6:17 [dts] [PATCH V1] tests/generic_filter: fix " lu,peipei
2018-03-15 6:37 ` Tu, LijuanX A
2018-03-19 8:07 ` Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).