From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id CAF9E5F5F for ; Tue, 20 Mar 2018 05:39:36 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2018 21:39:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,333,1517904000"; d="scan'208";a="40439214" Received: from unknown (HELO dpdk-fedora20.icx.intel.com) ([10.240.176.135]) by orsmga001.jf.intel.com with ESMTP; 19 Mar 2018 21:39:34 -0700 From: "han,yingya" To: dts@dpdk.org Cc: "han,yingya" Date: Tue, 20 Mar 2018 12:40:49 +0800 Message-Id: <1521520849-89149-1-git-send-email-yingyax.han@intel.com> X-Mailer: git-send-email 1.9.3 Subject: [dts] [PATCH V1]tests/mac_filter: fix FVL stats issue X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2018 04:39:37 -0000 In testpmd show port stats command is to read FVL register, and it's all packets of FVL. Contrast to FLV , Niantic's stats, tx/rx packets , don't include packets filtered. It's a difference between Niantic and FLV. Signed-off-by: han,yingya --- tests/TestSuite_mac_filter.py | 35 ++++++++++++++++------------------- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/tests/TestSuite_mac_filter.py b/tests/TestSuite_mac_filter.py index 1c58b87..a0c890d 100644 --- a/tests/TestSuite_mac_filter.py +++ b/tests/TestSuite_mac_filter.py @@ -107,48 +107,45 @@ class TestWhitelist(TestCase): # send one packet with the portid MAC address self.whitelist_send_packet(portid, self.dest) - out = self.dut.send_expect("show port stats %d" % portid, "testpmd> ") - cur_rxpkt = utils.regexp(out, "RX-packets: ([0-9]+)") + out = self.dut.get_session_output() + cur_rxpkt = utils.regexp(out, "received ([0-9]+) packets") # check the packet increase self.verify(int(cur_rxpkt) == int(pre_rxpkt) + self.frames_to_send, "Packet has not been received on default address") # send one packet to a different MAC address # new_mac = self.dut.get_mac_address(portid) self.whitelist_send_packet(portid, fake_mac_addr) - + out = self.dut.get_session_output() pre_rxpkt = cur_rxpkt - out = self.dut.send_expect("show port stats %d" % portid, "testpmd> ") - cur_rxpkt = utils.regexp(out, "RX-packets: ([0-9]+)") - - # check the packet DO NOT increase - self.verify(int(cur_rxpkt) == int(pre_rxpkt), + if not out: + cur_rxpkt = 0 + # check the packet DO NOT increase + self.verify(int(cur_rxpkt) == int(pre_rxpkt) - self.frames_to_send, "Packet has been received on a new MAC address that has not been added yet") # add the different MAC address - out = self.dut.send_expect("mac_addr add %d" % portid + " %s" % fake_mac_addr, "testpmd>") + self.dut.send_expect("mac_addr add %d" % portid + " %s" % fake_mac_addr, "testpmd>") # send again one packet to a different MAC address self.whitelist_send_packet(portid, fake_mac_addr) - + out = self.dut.get_session_output() pre_rxpkt = cur_rxpkt - out = self.dut.send_expect("show port stats %d" % portid, "testpmd> ") - cur_rxpkt = utils.regexp(out, "RX-packets: ([0-9]+)") + cur_rxpkt = utils.regexp(out, "received ([0-9]+) packets") # check the packet increase self.verify(int(cur_rxpkt) == int(pre_rxpkt) + self.frames_to_send, "Packet has not been received on a new MAC address that has been added to the port") # remove the fake MAC address - out = self.dut.send_expect("mac_addr remove %d" % portid + " %s" % fake_mac_addr, "testpmd>") + self.dut.send_expect("mac_addr remove %d" % portid + " %s" % fake_mac_addr, "testpmd>") # send again one packet to a different MAC address self.whitelist_send_packet(portid, fake_mac_addr) - + out = self.dut.get_session_output() pre_rxpkt = cur_rxpkt - out = self.dut.send_expect("show port stats %d" % portid, "testpmd> ") - cur_rxpkt = utils.regexp(out, "RX-packets: ([0-9]+)") - - # check the packet increase - self.verify(int(cur_rxpkt) == int(pre_rxpkt), + if not out: + cur_rxpkt = 0 + # check the packet increase + self.verify(int(cur_rxpkt) == int(pre_rxpkt) - self.frames_to_send, "Packet has been received on a new MAC address that has been removed from the port") self.dut.send_expect("stop", "testpmd> ") -- 1.9.3