test suite reviews and discussions
 help / color / mirror / Atom feed
From: "han,yingya" <yingyax.han@intel.com>
To: dts@dpdk.org
Cc: "han,yingya" <yingyax.han@intel.com>
Subject: [dts] [PATCH V1]tests/userspace_ethtool: fix FVL stats issue
Date: Thu, 29 Mar 2018 15:44:02 +0800	[thread overview]
Message-ID: <1522309442-103581-1-git-send-email-yingyax.han@intel.com> (raw)

FVL port statistic is retrieved from register.
Those filtered packets still will be calculated in.
Signed-off-by: han,yingya <yingyax.han@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index 84b1f1e..44bac01 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -443,7 +443,11 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
             pkt.send_pkt(tx_port=intf)
             time.sleep(2)
             rx_pkts_wrong, _ = self.strip_portstats(port)
-            self.verify(rx_pkts_wrong == rx_pkts, "Failed to filter Rx vlan packet")
+            if self.nic.startswith('fortville'):
+                self.verify(rx_pkts_wrong == rx_pkts + 1, "Failed to filter Rx vlan packet")
+                self.verify(_ == rx_pkts, "Failed to filter Rx vlan packet")
+            else:
+                self.verify(rx_pkts_wrong == rx_pkts, "Failed to filter Rx vlan packet")
 
             # remove vlan
             self.dut.send_expect("vlan %d del %d" % (index, vlan), "EthApp>")
@@ -452,7 +456,11 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
             pkt.send_pkt(tx_port=intf)
             time.sleep(2)
             rx_pkts_del, _ = self.strip_portstats(port)
-            self.verify(rx_pkts_del == rx_pkts, "Failed to remove Rx vlan filter")
+            if self.nic.startswith('fortville'):
+                self.verify(rx_pkts_del == rx_pkts_wrong + 1, "Failed to filter Rx vlan packet")
+                self.verify(_ == rx_pkts, "Failed to filter Rx vlan packet")
+            else:
+                self.verify(rx_pkts_del == rx_pkts, "Failed to filter Rx vlan packet")
 
         self.dut.send_expect("quit", "# ")
         self.dut.send_expect("sed -i -e '/hw_vlan_filter=1;$/d' %s" % main_file, "# ")
-- 
1.9.3

             reply	other threads:[~2018-03-29  7:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29  7:44 han,yingya [this message]
2018-04-10  1:29 ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1522309442-103581-1-git-send-email-yingyax.han@intel.com \
    --to=yingyax.han@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).