test suite reviews and discussions
 help / color / mirror / Atom feed
From: "zhu,shuai" <shuaix.zhu@intel.com>
To: dts@dpdk.org
Cc: "zhu,shuai" <shuaix.zhu@intel.com>
Subject: [dts] [PATCH V1] tests/uni_pkt:Fixed syntax error
Date: Fri, 30 Mar 2018 10:41:05 +0800	[thread overview]
Message-ID: <1522377665-104981-1-git-send-email-shuaix.zhu@intel.com> (raw)

Use NIC family name to match case.
fortville NIC family:
    fortville_eagle,
    fortville_spirit,
    fortville_spirit_single,
    fortville_25g

fortpark NIC family:
    fortpark_TLV,
    fortpark_TLV_vf   
 

Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_uni_pkt.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_uni_pkt.py b/tests/TestSuite_uni_pkt.py
index e11b482..2586ad9 100644
--- a/tests/TestSuite_uni_pkt.py
+++ b/tests/TestSuite_uni_pkt.py
@@ -115,7 +115,7 @@ class TestUniPacket(TestCase):
         """
         checked that whether L3 and L4 packet can be normally detected.
         """
-        if "fortville" in self.nic.lower() or "fortpark_TLV" in self.nic.lower():
+        if "fortville" in self.nic or "fortpark_TLV" in self.nic:
             outerL4Type = "L4_NONFRAG"
             ipv4_default_packet_type = ["L2_ETHER", "L3_IPV4_EXT_UNKNOWN"]
         elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
@@ -133,7 +133,7 @@ class TestUniPacket(TestCase):
         }
 
         # delete the unsupported packet based on nic type
-        if "fortville" in self.nic.lower() or "fortpark_TLV" in self.nic.lower():
+        if "fortville" in self.nic or "fortpark_TLV" in self.nic:
             pktType.pop("MAC_IPihl_PKT")
             pktType.pop("MAC_IPihl_SCTP_PKT")
         elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
@@ -146,7 +146,7 @@ class TestUniPacket(TestCase):
         """
         checked that whether IPv6 and L4 packet can be normally detected.
         """
-        if "fortville" in self.nic.lower() or "fortpark_TLV" in self.nic.lower():
+        if "fortville" in self.nic or "fortpark_TLV" in self.nic:
             outerL4Type = "L4_NONFRAG"
             ipv6_default_packet_type = ["L2_ETHER", "L3_IPV6_EXT_UNKNOWN"]
         elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
@@ -162,7 +162,7 @@ class TestUniPacket(TestCase):
         }
 
         # delete the unsupported packet based on nic type
-        if "fortville" in self.nic.lower() or "fortpark_TLV" in self.nic.lower():
+        if "fortville" in self.nic or "fortpark_TLV" in self.nic:
             pktType.pop("MAC_IPv6FRAG_PKT_N")
         elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
             pktType.pop("MAC_IPv6FRAG_PKT_F")
-- 
1.9.3

             reply	other threads:[~2018-03-30  2:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-30  2:41 zhu,shuai [this message]
2018-04-04 12:28 ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1522377665-104981-1-git-send-email-shuaix.zhu@intel.com \
    --to=shuaix.zhu@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).