* [dts] [PATCH V1] tests/uni_pkt:Fixed syntax error
@ 2018-03-30 2:41 zhu,shuai
2018-04-04 12:28 ` Liu, Yong
0 siblings, 1 reply; 2+ messages in thread
From: zhu,shuai @ 2018-03-30 2:41 UTC (permalink / raw)
To: dts; +Cc: zhu,shuai
Use NIC family name to match case.
fortville NIC family:
fortville_eagle,
fortville_spirit,
fortville_spirit_single,
fortville_25g
fortpark NIC family:
fortpark_TLV,
fortpark_TLV_vf
Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
tests/TestSuite_uni_pkt.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/TestSuite_uni_pkt.py b/tests/TestSuite_uni_pkt.py
index e11b482..2586ad9 100644
--- a/tests/TestSuite_uni_pkt.py
+++ b/tests/TestSuite_uni_pkt.py
@@ -115,7 +115,7 @@ class TestUniPacket(TestCase):
"""
checked that whether L3 and L4 packet can be normally detected.
"""
- if "fortville" in self.nic.lower() or "fortpark_TLV" in self.nic.lower():
+ if "fortville" in self.nic or "fortpark_TLV" in self.nic:
outerL4Type = "L4_NONFRAG"
ipv4_default_packet_type = ["L2_ETHER", "L3_IPV4_EXT_UNKNOWN"]
elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
@@ -133,7 +133,7 @@ class TestUniPacket(TestCase):
}
# delete the unsupported packet based on nic type
- if "fortville" in self.nic.lower() or "fortpark_TLV" in self.nic.lower():
+ if "fortville" in self.nic or "fortpark_TLV" in self.nic:
pktType.pop("MAC_IPihl_PKT")
pktType.pop("MAC_IPihl_SCTP_PKT")
elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
@@ -146,7 +146,7 @@ class TestUniPacket(TestCase):
"""
checked that whether IPv6 and L4 packet can be normally detected.
"""
- if "fortville" in self.nic.lower() or "fortpark_TLV" in self.nic.lower():
+ if "fortville" in self.nic or "fortpark_TLV" in self.nic:
outerL4Type = "L4_NONFRAG"
ipv6_default_packet_type = ["L2_ETHER", "L3_IPV6_EXT_UNKNOWN"]
elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
@@ -162,7 +162,7 @@ class TestUniPacket(TestCase):
}
# delete the unsupported packet based on nic type
- if "fortville" in self.nic.lower() or "fortpark_TLV" in self.nic.lower():
+ if "fortville" in self.nic or "fortpark_TLV" in self.nic:
pktType.pop("MAC_IPv6FRAG_PKT_N")
elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
pktType.pop("MAC_IPv6FRAG_PKT_F")
--
1.9.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dts] [PATCH V1] tests/uni_pkt:Fixed syntax error
2018-03-30 2:41 [dts] [PATCH V1] tests/uni_pkt:Fixed syntax error zhu,shuai
@ 2018-04-04 12:28 ` Liu, Yong
0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2018-04-04 12:28 UTC (permalink / raw)
To: zhu,shuai, dts
Thanks Shuai, applied.
On 03/30/2018 10:41 AM, zhu,shuai wrote:
> Use NIC family name to match case.
> fortville NIC family:
> fortville_eagle,
> fortville_spirit,
> fortville_spirit_single,
> fortville_25g
>
> fortpark NIC family:
> fortpark_TLV,
> fortpark_TLV_vf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-04 4:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-30 2:41 [dts] [PATCH V1] tests/uni_pkt:Fixed syntax error zhu,shuai
2018-04-04 12:28 ` Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).