test suite reviews and discussions
 help / color / mirror / Atom feed
From: "han,yingya" <yingyax.han@intel.com>
To: dts@dpdk.org
Cc: "han,yingya" <yingyax.han@intel.com>
Subject: [dts] [PATCH V1]tests/shutdown_api: fix the CRC stripping enabled issue
Date: Thu, 17 May 2018 13:15:03 +0800	[thread overview]
Message-ID: <1526534103-15323-1-git-send-email-yingyax.han@intel.com> (raw)

The CRC strip defaults to enable and the output of CRC stripping changed in 18.05.
'Rx offloads=0x1000' is defined as DEV_RX_OFFLOAD_CRC_STRIP.

Signed-off-by: han,yingya <yingyax.han@intel.com>
---
 tests/TestSuite_shutdown_api.py | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index af0b77d..8b6de18 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -253,8 +253,8 @@ class TestShutdownApi(TestCase):
         self.dut.send_expect("set fwd mac", "testpmd>")
         self.dut.send_expect("port start all", "testpmd> ", 100)
         out = self.dut.send_expect("show config rxtx", "testpmd> ")
-        self.verify("RX queues=2" in out, "RX queues not reconfigured properly")
-        self.verify("TX queues=2" in out, "TX queues not reconfigured properly")
+        self.verify("RX queue number: 2" in out, "RX queues not reconfigured properly")
+        self.verify("Tx queue number: 2" in out, "TX queues not reconfigured properly")
         self.dut.send_expect("start", "testpmd> ")
         self.check_forwarding()
         self.dut.send_expect("quit", "# ", 30)
@@ -263,7 +263,10 @@ class TestShutdownApi(TestCase):
         """
         Reconfigure All Ports With The Same Configurations (CRC)
         """
-        self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop" % utils.create_mask(self.ports), socket=self.ports_socket)
+        self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop --disable-crc-strip" % utils.create_mask(self.ports), socket=self.ports_socket)
+        out = self.dut.send_expect("show config rxtx", "testpmd> ")
+        self.verify(
+            "Rx offloads=0x0" in out, "CRC stripping not disabled properly")
 
         self.dut.send_expect("port stop all", "testpmd> ", 100)
         self.dut.send_expect("port config all crc-strip on", "testpmd> ")
@@ -271,7 +274,7 @@ class TestShutdownApi(TestCase):
         self.dut.send_expect("port start all", "testpmd> ", 100)
         out = self.dut.send_expect("show config rxtx", "testpmd> ")
         self.verify(
-            "CRC stripping enabled" in out, "CRC stripping not enabled properly")
+            "Rx offloads=0x1000" in out, "CRC stripping not enabled properly")
         self.dut.send_expect("start", "testpmd> ")
         self.check_forwarding()
 
-- 
1.9.3

             reply	other threads:[~2018-05-17  5:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17  5:15 han,yingya [this message]
2018-05-17 15:30 ` Liu, Yong
  -- strict thread matches above, loose matches on Subject: below --
2018-05-17  2:09 han,yingya
2018-05-17  2:17 ` Liu, Yong
2018-05-17  2:59   ` Han, YingyaX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1526534103-15323-1-git-send-email-yingyax.han@intel.com \
    --to=yingyax.han@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).