* [dts] [PATCH V1] tests/vf daemon : open vf filter
@ 2018-05-25 9:26 zhao,meijuan
2018-05-28 13:30 ` Liu, Yong
0 siblings, 1 reply; 6+ messages in thread
From: zhao,meijuan @ 2018-05-25 9:26 UTC (permalink / raw)
To: dts; +Cc: zhao,meijuan
before set rx_vlan add command, need enable vf filter, before
v18.02, vf filter default is enable
Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
tests/TestSuite_vf_daemon.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/TestSuite_vf_daemon.py b/tests/TestSuite_vf_daemon.py
index fddfb98..56fc4be 100644
--- a/tests/TestSuite_vf_daemon.py
+++ b/tests/TestSuite_vf_daemon.py
@@ -571,6 +571,7 @@ class Testvf_daemon(TestCase):
self.vm0_testpmd.execute_cmd('set fwd mac')
self.vm0_testpmd.execute_cmd('start')
#self.dut_testpmd.execute_cmd('rx_vlan add %d port 0 vf 1' % match_vlan)
+ self.vm0_testpmd.execute_cmd('vlan set filter on 0')
self.vm0_testpmd.execute_cmd('rx_vlan add %d 0' % match_vlan)
if self.kdriver == "i40e":
self.dut_testpmd.execute_cmd('set vf vlan stripq 0 0 off')
--
1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dts] [PATCH V1] tests/vf daemon : open vf filter
2018-05-25 9:26 [dts] [PATCH V1] tests/vf daemon : open vf filter zhao,meijuan
@ 2018-05-28 13:30 ` Liu, Yong
0 siblings, 0 replies; 6+ messages in thread
From: Liu, Yong @ 2018-05-28 13:30 UTC (permalink / raw)
To: zhao,meijuan, dts
Thanks Meijuan, applied. BTW, this patch almost the same as previous
one. Please merge them into one at next time.
Thanks,
Marvin
On 05/25/2018 05:26 PM, zhao,meijuan wrote:
> before set rx_vlan add command, need enable vf filter, before
> v18.02, vf filter default is enable
>
>
> Signed-off-by: zhao,meijuan<meijuanx.zhao@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dts] [PATCH V1] tests/vf daemon : open vf filter
@ 2018-05-23 6:41 zhao,meijuan
2018-05-25 8:50 ` Liu, Yong
0 siblings, 1 reply; 6+ messages in thread
From: zhao,meijuan @ 2018-05-23 6:41 UTC (permalink / raw)
To: dts; +Cc: zhao,meijuan
before set rx_vlan add command, need enable vf filter,
before v18.02, vf filter default is enable
Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
tests/TestSuite_vf_daemon.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/TestSuite_vf_daemon.py b/tests/TestSuite_vf_daemon.py
index b1ad522..fddfb98 100644
--- a/tests/TestSuite_vf_daemon.py
+++ b/tests/TestSuite_vf_daemon.py
@@ -622,6 +622,7 @@ class Testvf_daemon(TestCase):
self.vm0_testpmd.execute_cmd('set verbose 1')
self.vm0_testpmd.execute_cmd('start')
for rx_vlan in rx_vlans:
+ self.vm0_testpmd.execute_cmd('vlan set filter on 0')
self.vm0_testpmd.execute_cmd('rx_vlan add %s 0' % rx_vlan)
self.dut_testpmd.execute_cmd('set vf vlan stripq 0 0 off')
time.sleep(3)
@@ -632,7 +633,7 @@ class Testvf_daemon(TestCase):
time.sleep(3)
out = self.send_and_vlanstrip(self.vf0_mac,rx_vlan)
self.verify(rx_vlan not in out, "Failed to disable strip vlan!!!")
-
+ self.vm0_testpmd.execute_cmd('vlan set filter off 0')
def test_vlan_filter(self):
"""
--
1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dts] [PATCH V1] tests/vf daemon : open vf filter
2018-05-23 6:41 zhao,meijuan
@ 2018-05-25 8:50 ` Liu, Yong
2018-05-25 8:54 ` Zhao, MeijuanX
0 siblings, 1 reply; 6+ messages in thread
From: Liu, Yong @ 2018-05-25 8:50 UTC (permalink / raw)
To: Zhao, MeijuanX, dts; +Cc: Zhao, MeijuanX
Meijuan,
Since vlan filter setting is the prerequisite for vlan strip and filter, why only vlan_strip case added this setting?
Is it also needed for test_vlan_filter case?
Thanks,
Marvin
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan
> Sent: Wednesday, May 23, 2018 2:42 PM
> To: dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: [dts] [PATCH V1] tests/vf daemon : open vf filter
>
> before set rx_vlan add command, need enable vf filter,
> before v18.02, vf filter default is enable
>
> Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> ---
> tests/TestSuite_vf_daemon.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_vf_daemon.py b/tests/TestSuite_vf_daemon.py
> index b1ad522..fddfb98 100644
> --- a/tests/TestSuite_vf_daemon.py
> +++ b/tests/TestSuite_vf_daemon.py
> @@ -622,6 +622,7 @@ class Testvf_daemon(TestCase):
> self.vm0_testpmd.execute_cmd('set verbose 1')
> self.vm0_testpmd.execute_cmd('start')
> for rx_vlan in rx_vlans:
> + self.vm0_testpmd.execute_cmd('vlan set filter on 0')
> self.vm0_testpmd.execute_cmd('rx_vlan add %s 0' % rx_vlan)
> self.dut_testpmd.execute_cmd('set vf vlan stripq 0 0 off')
> time.sleep(3)
> @@ -632,7 +633,7 @@ class Testvf_daemon(TestCase):
> time.sleep(3)
> out = self.send_and_vlanstrip(self.vf0_mac,rx_vlan)
> self.verify(rx_vlan not in out, "Failed to disable strip
> vlan!!!")
> -
> + self.vm0_testpmd.execute_cmd('vlan set filter off 0')
>
> def test_vlan_filter(self):
> """
> --
> 1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dts] [PATCH V1] tests/vf daemon : open vf filter
2018-05-25 8:50 ` Liu, Yong
@ 2018-05-25 8:54 ` Zhao, MeijuanX
2018-05-25 9:07 ` Liu, Yong
0 siblings, 1 reply; 6+ messages in thread
From: Zhao, MeijuanX @ 2018-05-25 8:54 UTC (permalink / raw)
To: Liu, Yong, dts; +Cc: Zhao, MeijuanX
test_vlan_filter script has vlan filter set
-----Original Message-----
From: Liu, Yong
Sent: Friday, May 25, 2018 4:50 PM
To: Zhao, MeijuanX <meijuanx.zhao@intel.com>; dts@dpdk.org
Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
Subject: RE: [dts] [PATCH V1] tests/vf daemon : open vf filter
Meijuan,
Since vlan filter setting is the prerequisite for vlan strip and filter, why only vlan_strip case added this setting?
Is it also needed for test_vlan_filter case?
Thanks,
Marvin
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan
> Sent: Wednesday, May 23, 2018 2:42 PM
> To: dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: [dts] [PATCH V1] tests/vf daemon : open vf filter
>
> before set rx_vlan add command, need enable vf filter, before v18.02,
> vf filter default is enable
>
> Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> ---
> tests/TestSuite_vf_daemon.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_vf_daemon.py
> b/tests/TestSuite_vf_daemon.py index b1ad522..fddfb98 100644
> --- a/tests/TestSuite_vf_daemon.py
> +++ b/tests/TestSuite_vf_daemon.py
> @@ -622,6 +622,7 @@ class Testvf_daemon(TestCase):
> self.vm0_testpmd.execute_cmd('set verbose 1')
> self.vm0_testpmd.execute_cmd('start')
> for rx_vlan in rx_vlans:
> + self.vm0_testpmd.execute_cmd('vlan set filter on 0')
> self.vm0_testpmd.execute_cmd('rx_vlan add %s 0' % rx_vlan)
> self.dut_testpmd.execute_cmd('set vf vlan stripq 0 0 off')
> time.sleep(3)
> @@ -632,7 +633,7 @@ class Testvf_daemon(TestCase):
> time.sleep(3)
> out = self.send_and_vlanstrip(self.vf0_mac,rx_vlan)
> self.verify(rx_vlan not in out, "Failed to disable strip
> vlan!!!")
> -
> + self.vm0_testpmd.execute_cmd('vlan set filter off 0')
>
> def test_vlan_filter(self):
> """
> --
> 1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dts] [PATCH V1] tests/vf daemon : open vf filter
2018-05-25 8:54 ` Zhao, MeijuanX
@ 2018-05-25 9:07 ` Liu, Yong
0 siblings, 0 replies; 6+ messages in thread
From: Liu, Yong @ 2018-05-25 9:07 UTC (permalink / raw)
To: Zhao, MeijuanX, dts
Sorry, I missed that. Patch also applied in.
Thanks,
Marvin
> -----Original Message-----
> From: Zhao, MeijuanX
> Sent: Friday, May 25, 2018 4:54 PM
> To: Liu, Yong <yong.liu@intel.com>; dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: RE: [dts] [PATCH V1] tests/vf daemon : open vf filter
>
> test_vlan_filter script has vlan filter set
>
> -----Original Message-----
> From: Liu, Yong
> Sent: Friday, May 25, 2018 4:50 PM
> To: Zhao, MeijuanX <meijuanx.zhao@intel.com>; dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: RE: [dts] [PATCH V1] tests/vf daemon : open vf filter
>
> Meijuan,
> Since vlan filter setting is the prerequisite for vlan strip and filter,
> why only vlan_strip case added this setting?
> Is it also needed for test_vlan_filter case?
>
> Thanks,
> Marvin
>
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan
> > Sent: Wednesday, May 23, 2018 2:42 PM
> > To: dts@dpdk.org
> > Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> > Subject: [dts] [PATCH V1] tests/vf daemon : open vf filter
> >
> > before set rx_vlan add command, need enable vf filter, before v18.02,
> > vf filter default is enable
> >
> > Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> > ---
> > tests/TestSuite_vf_daemon.py | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/TestSuite_vf_daemon.py
> > b/tests/TestSuite_vf_daemon.py index b1ad522..fddfb98 100644
> > --- a/tests/TestSuite_vf_daemon.py
> > +++ b/tests/TestSuite_vf_daemon.py
> > @@ -622,6 +622,7 @@ class Testvf_daemon(TestCase):
> > self.vm0_testpmd.execute_cmd('set verbose 1')
> > self.vm0_testpmd.execute_cmd('start')
> > for rx_vlan in rx_vlans:
> > + self.vm0_testpmd.execute_cmd('vlan set filter on 0')
> > self.vm0_testpmd.execute_cmd('rx_vlan add %s 0' % rx_vlan)
> > self.dut_testpmd.execute_cmd('set vf vlan stripq 0 0 off')
> > time.sleep(3)
> > @@ -632,7 +633,7 @@ class Testvf_daemon(TestCase):
> > time.sleep(3)
> > out = self.send_and_vlanstrip(self.vf0_mac,rx_vlan)
> > self.verify(rx_vlan not in out, "Failed to disable strip
> > vlan!!!")
> > -
> > + self.vm0_testpmd.execute_cmd('vlan set filter off 0')
> >
> > def test_vlan_filter(self):
> > """
> > --
> > 1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-28 5:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-25 9:26 [dts] [PATCH V1] tests/vf daemon : open vf filter zhao,meijuan
2018-05-28 13:30 ` Liu, Yong
-- strict thread matches above, loose matches on Subject: below --
2018-05-23 6:41 zhao,meijuan
2018-05-25 8:50 ` Liu, Yong
2018-05-25 8:54 ` Zhao, MeijuanX
2018-05-25 9:07 ` Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).