* [dts] [PATCH V1] tests/sriov kvm: add vlan strip
@ 2018-05-28 9:08 zhao,meijuan
0 siblings, 0 replies; 5+ messages in thread
From: zhao,meijuan @ 2018-05-28 9:08 UTC (permalink / raw)
To: dts; +Cc: zhao,meijuan
before dpdk18.02, testpmd default vlan strip value is enable,
test vlan mirror need enable vlan strip
Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
tests/TestSuite_sriov_kvm.py | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/tests/TestSuite_sriov_kvm.py b/tests/TestSuite_sriov_kvm.py
index ee8d555..1526d4f 100644
--- a/tests/TestSuite_sriov_kvm.py
+++ b/tests/TestSuite_sriov_kvm.py
@@ -773,6 +773,8 @@ class TestSriovKvm(TestCase):
self.setup_2vm_2vf_env()
self.setup_two_vm_common_prerequisite()
+ self.vm1_testpmd.execute_cmd('vlan set strip on 0')
+
port_id_0 = 0
vlan_id = 0
vf_mask = '0x1'
@@ -799,12 +801,17 @@ class TestSriovKvm(TestCase):
vm1_ret_stats['TX-packets'] == packet_num,
"Vlan mirror failed between VM0 and VM1!")
+ self.vm1_testpmd.execute_cmd('vlan set strip off 0')
+
self.reset_port_mirror_rule(port_id_0, rule_id)
def test_two_vms_vlan_and_pool_mirror(self):
self.setup_2vm_2vf_env()
self.setup_two_vm_common_prerequisite()
+ self.vm0_testpmd.execute_cmd('vlan set strip on 0')
+ self.vm1_testpmd.execute_cmd('vlan set strip on 0')
+
port_id_0 = 0
vlan_id = 3
vf_mask = '0x2'
@@ -846,6 +853,9 @@ class TestSriovKvm(TestCase):
self.verify(self.vm0_testpmd.check_tx_bytes(vm0_ret_stats['RX-packets'], 10 * packet_num),
"Vlan mirror failed between VM0 and VM1 when set vlan and pool mirror!")
+ self.vm0_testpmd.execute_cmd('vlan set strip off 0')
+ self.vm1_testpmd.execute_cmd('vlan set strip off 0')
+
self.reset_port_all_mirror_rule(port_id_0)
def test_two_vms_uplink_and_downlink_mirror(self):
@@ -900,6 +910,9 @@ class TestSriovKvm(TestCase):
self.setup_2vm_2vf_env()
self.setup_two_vm_common_prerequisite()
+ self.vm0_testpmd.execute_cmd('vlan set strip on 0')
+ self.vm1_testpmd.execute_cmd('vlan set strip on 0')
+
self.vm0_testpmd.execute_cmd('stop')
self.vm1_testpmd.execute_cmd('stop')
@@ -978,6 +991,9 @@ class TestSriovKvm(TestCase):
"Vlan and downlink mirror failed between VM0 and VM1 " +
"when set vlan, pool, uplink and downlink mirror!")
+ self.vm0_testpmd.execute_cmd('vlan set strip off 0')
+ self.vm1_testpmd.execute_cmd('vlan set strip off 0')
+
self.reset_port_all_mirror_rule(port_id_0)
def test_two_vms_add_multi_exact_mac_on_vf(self):
--
1.9.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dts] [PATCH V1] tests/sriov kvm: add vlan strip
2018-07-03 8:20 [dts] [PATCH V1] tests/sriov kvm: add " zhao,meijuan
@ 2018-07-03 16:46 ` Liu, Yong
0 siblings, 0 replies; 5+ messages in thread
From: Liu, Yong @ 2018-07-03 16:46 UTC (permalink / raw)
To: zhao,meijuan, dts
Thanks, Meijuan. Modified commit log for more accurate. Need to enable
vlan filter for vlan mirror cases.
On 07/03/2018 04:20 PM, zhao,meijuan wrote:
> after dpdk-18.02,bad commit 8b9bd0,testpmd vlan filter and strip default value change,
> lead to ethdev and driver status is inconformity
>
> Signed-off-by: zhao,meijuan<meijuanx.zhao@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dts] [PATCH V1] tests/sriov kvm: add vlan strip
@ 2018-07-03 8:20 zhao,meijuan
2018-07-03 16:46 ` Liu, Yong
0 siblings, 1 reply; 5+ messages in thread
From: zhao,meijuan @ 2018-07-03 8:20 UTC (permalink / raw)
To: dts; +Cc: zhao,meijuan
after dpdk-18.02,bad commit 8b9bd0,testpmd vlan filter and strip default value change,
lead to ethdev and driver status is inconformity
Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
tests/TestSuite_sriov_kvm.py | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/tests/TestSuite_sriov_kvm.py b/tests/TestSuite_sriov_kvm.py
index ee8d555..39e6af3 100644
--- a/tests/TestSuite_sriov_kvm.py
+++ b/tests/TestSuite_sriov_kvm.py
@@ -772,7 +772,7 @@ class TestSriovKvm(TestCase):
def test_two_vms_vlan_mirror(self):
self.setup_2vm_2vf_env()
self.setup_two_vm_common_prerequisite()
-
+ self.vm1_testpmd.execute_cmd('vlan set strip on 0')
port_id_0 = 0
vlan_id = 0
vf_mask = '0x1'
@@ -804,7 +804,8 @@ class TestSriovKvm(TestCase):
def test_two_vms_vlan_and_pool_mirror(self):
self.setup_2vm_2vf_env()
self.setup_two_vm_common_prerequisite()
-
+ self.vm0_testpmd.execute_cmd('vlan set strip on 0')
+ self.vm1_testpmd.execute_cmd('vlan set strip on 0')
port_id_0 = 0
vlan_id = 3
vf_mask = '0x2'
@@ -899,7 +900,8 @@ class TestSriovKvm(TestCase):
def test_two_vms_vlan_and_pool_and_uplink_and_downlink(self):
self.setup_2vm_2vf_env()
self.setup_two_vm_common_prerequisite()
-
+ self.vm0_testpmd.execute_cmd('vlan set strip on 0')
+ self.vm1_testpmd.execute_cmd('vlan set strip on 0')
self.vm0_testpmd.execute_cmd('stop')
self.vm1_testpmd.execute_cmd('stop')
--
1.9.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dts] [PATCH V1] tests/sriov kvm:add vlan strip
2018-06-12 8:44 [dts] [PATCH V1] tests/sriov kvm:add " zhao,meijuan
@ 2018-06-12 9:09 ` Liu, Yong
0 siblings, 0 replies; 5+ messages in thread
From: Liu, Yong @ 2018-06-12 9:09 UTC (permalink / raw)
To: Zhao, MeijuanX, dts; +Cc: Zhao, MeijuanX
Hi Meijuan,
Could you please confirm with developer that vlan strip was must for mirror?
If it is true, please also update related test plan.
Thanks,
Marvin
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan
> Sent: Tuesday, June 12, 2018 4:45 PM
> To: dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: [dts] [PATCH V1] tests/sriov kvm:add vlan strip
>
> before dpdk18.02, testpmd default vlan strip value is enable,
> test vlan mirror need enable vlan strip
>
> Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> ---
> tests/TestSuite_sriov_kvm.py | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/tests/TestSuite_sriov_kvm.py b/tests/TestSuite_sriov_kvm.py
> index ee8d555..e5c984c 100644
> --- a/tests/TestSuite_sriov_kvm.py
> +++ b/tests/TestSuite_sriov_kvm.py
> @@ -772,7 +772,7 @@ class TestSriovKvm(TestCase):
> def test_two_vms_vlan_mirror(self):
> self.setup_2vm_2vf_env()
> self.setup_two_vm_common_prerequisite()
> -
> + self.vm1_testpmd.execute_cmd('vlan set strip on 0')
> port_id_0 = 0
> vlan_id = 0
> vf_mask = '0x1'
> @@ -804,7 +804,8 @@ class TestSriovKvm(TestCase):
> def test_two_vms_vlan_and_pool_mirror(self):
> self.setup_2vm_2vf_env()
> self.setup_two_vm_common_prerequisite()
> -
> + self.vm0_testpmd.execute_cmd('vlan set strip on 0')
> + self.vm1_testpmd.execute_cmd('vlan set strip on 0')
> port_id_0 = 0
> vlan_id = 3
> vf_mask = '0x2'
> @@ -851,7 +852,8 @@ class TestSriovKvm(TestCase):
> def test_two_vms_uplink_and_downlink_mirror(self):
> self.setup_2vm_2vf_env()
> self.setup_two_vm_common_prerequisite()
> -
> + self.vm0_testpmd.execute_cmd('vlan set strip on 0')
> + self.vm1_testpmd.execute_cmd('vlan set strip on 0')
> self.vm0_testpmd.execute_cmd('stop')
> self.vm1_testpmd.execute_cmd('stop')
>
> --
> 1.9.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dts] [PATCH V1] tests/sriov kvm:add vlan strip
@ 2018-06-12 8:44 zhao,meijuan
2018-06-12 9:09 ` Liu, Yong
0 siblings, 1 reply; 5+ messages in thread
From: zhao,meijuan @ 2018-06-12 8:44 UTC (permalink / raw)
To: dts; +Cc: zhao,meijuan
before dpdk18.02, testpmd default vlan strip value is enable,
test vlan mirror need enable vlan strip
Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
tests/TestSuite_sriov_kvm.py | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/tests/TestSuite_sriov_kvm.py b/tests/TestSuite_sriov_kvm.py
index ee8d555..e5c984c 100644
--- a/tests/TestSuite_sriov_kvm.py
+++ b/tests/TestSuite_sriov_kvm.py
@@ -772,7 +772,7 @@ class TestSriovKvm(TestCase):
def test_two_vms_vlan_mirror(self):
self.setup_2vm_2vf_env()
self.setup_two_vm_common_prerequisite()
-
+ self.vm1_testpmd.execute_cmd('vlan set strip on 0')
port_id_0 = 0
vlan_id = 0
vf_mask = '0x1'
@@ -804,7 +804,8 @@ class TestSriovKvm(TestCase):
def test_two_vms_vlan_and_pool_mirror(self):
self.setup_2vm_2vf_env()
self.setup_two_vm_common_prerequisite()
-
+ self.vm0_testpmd.execute_cmd('vlan set strip on 0')
+ self.vm1_testpmd.execute_cmd('vlan set strip on 0')
port_id_0 = 0
vlan_id = 3
vf_mask = '0x2'
@@ -851,7 +852,8 @@ class TestSriovKvm(TestCase):
def test_two_vms_uplink_and_downlink_mirror(self):
self.setup_2vm_2vf_env()
self.setup_two_vm_common_prerequisite()
-
+ self.vm0_testpmd.execute_cmd('vlan set strip on 0')
+ self.vm1_testpmd.execute_cmd('vlan set strip on 0')
self.vm0_testpmd.execute_cmd('stop')
self.vm1_testpmd.execute_cmd('stop')
--
1.9.3
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-03 9:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-28 9:08 [dts] [PATCH V1] tests/sriov kvm: add vlan strip zhao,meijuan
2018-06-12 8:44 [dts] [PATCH V1] tests/sriov kvm:add " zhao,meijuan
2018-06-12 9:09 ` Liu, Yong
2018-07-03 8:20 [dts] [PATCH V1] tests/sriov kvm: add " zhao,meijuan
2018-07-03 16:46 ` Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).