test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/vf daemon  fix make queues full fail
@ 2018-06-04  6:37 zhao,meijuan
  2018-06-11  5:14 ` Liu, Yong
  0 siblings, 1 reply; 5+ messages in thread
From: zhao,meijuan @ 2018-06-04  6:37 UTC (permalink / raw)
  To: dts; +Cc: zhao,meijuan

dpdk18.05 change CONFIG_RTE_MEMPOOL_CACHE_MAX_SIZE as 512

Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
 tests/TestSuite_vf_daemon.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_vf_daemon.py b/tests/TestSuite_vf_daemon.py
index 56fc4be..b5e9e99 100644
--- a/tests/TestSuite_vf_daemon.py
+++ b/tests/TestSuite_vf_daemon.py
@@ -464,7 +464,7 @@ class Testvf_daemon(TestCase):
         self.vf1_mac = self.vm1_testpmd.get_port_mac(0)
         out = self.send_and_pmdout(self.vf1_mac, 0, 64, 2000)
         out = self.vm1_testpmd.execute_cmd('show port stats 0')
-        self.verify("RX-packets: 1023" in out, 
+        self.verify("RX-packets: 511" in out, 
             "Failed to let vf1 full of queues!!!")
         out = self.send_and_pmdout(self.vf0_mac, 0, 64, 20)
         out = self.vm0_testpmd.execute_cmd('show port stats 0')
-- 
1.9.3

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1] tests/vf daemon  fix make queues full fail
  2018-06-04  6:37 [dts] [PATCH V1] tests/vf daemon fix make queues full fail zhao,meijuan
@ 2018-06-11  5:14 ` Liu, Yong
  0 siblings, 0 replies; 5+ messages in thread
From: Liu, Yong @ 2018-06-11  5:14 UTC (permalink / raw)
  To: Zhao, MeijuanX, dts; +Cc: Zhao, MeijuanX

Meijuan,
Your git commit is not accurate, the number of descriptors are changed because of testpmd will use driver default setting. This value maybe changed as different NICs will have different settings. 

I recommend you to fix this value by testpmd "--rxd" parameters, thus this value can be aligned between all NICs.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan
> Sent: Monday, June 04, 2018 2:37 PM
> To: dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: [dts] [PATCH V1] tests/vf daemon fix make queues full fail
> 
> dpdk18.05 change CONFIG_RTE_MEMPOOL_CACHE_MAX_SIZE as 512
> 
> Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> ---
>  tests/TestSuite_vf_daemon.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_vf_daemon.py b/tests/TestSuite_vf_daemon.py
> index 56fc4be..b5e9e99 100644
> --- a/tests/TestSuite_vf_daemon.py
> +++ b/tests/TestSuite_vf_daemon.py
> @@ -464,7 +464,7 @@ class Testvf_daemon(TestCase):
>          self.vf1_mac = self.vm1_testpmd.get_port_mac(0)
>          out = self.send_and_pmdout(self.vf1_mac, 0, 64, 2000)
>          out = self.vm1_testpmd.execute_cmd('show port stats 0')
> -        self.verify("RX-packets: 1023" in out,
> +        self.verify("RX-packets: 511" in out,
>              "Failed to let vf1 full of queues!!!")
>          out = self.send_and_pmdout(self.vf0_mac, 0, 64, 20)
>          out = self.vm0_testpmd.execute_cmd('show port stats 0')
> --
> 1.9.3

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1] tests/vf daemon : fix make queues full fail
  2018-06-11 10:14 [dts] [PATCH V1] tests/vf daemon : " zhao,meijuan
@ 2018-06-12  9:54 ` Liu, Yong
  0 siblings, 0 replies; 5+ messages in thread
From: Liu, Yong @ 2018-06-12  9:54 UTC (permalink / raw)
  To: zhao,meijuan, dts

Thanks Meijuan, applied with comments modified.

On 06/11/2018 06:14 PM, zhao,meijuan wrote:
> change rx queue number
>
> Signed-off-by: zhao,meijuan<meijuanx.zhao@intel.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts] [PATCH V1] tests/vf daemon : fix make queues full fail
@ 2018-06-11 10:14 zhao,meijuan
  2018-06-12  9:54 ` Liu, Yong
  0 siblings, 1 reply; 5+ messages in thread
From: zhao,meijuan @ 2018-06-11 10:14 UTC (permalink / raw)
  To: dts; +Cc: zhao,meijuan

change rx queue number

Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
 tests/TestSuite_vf_daemon.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_vf_daemon.py b/tests/TestSuite_vf_daemon.py
index 56fc4be..f034214 100644
--- a/tests/TestSuite_vf_daemon.py
+++ b/tests/TestSuite_vf_daemon.py
@@ -454,7 +454,7 @@ class Testvf_daemon(TestCase):
         Enable/disable drop enable bit for all queues from PF
         """
         self.check_vf_link_status()
-        self.vm1_testpmd.start_testpmd(VM_CORES_MASK, '--port-topology=chained')
+        self.vm1_testpmd.start_testpmd(VM_CORES_MASK, '--port-topology=chained --rxd=1024')
 
         self.vm0_testpmd.execute_cmd('set fwd rxonly')
         self.vm0_testpmd.execute_cmd('set verbose 1')
-- 
1.9.3

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts] [PATCH V1] tests/vf daemon: fix make queues full fail
@ 2018-05-18  8:10 zhao,meijuan
  0 siblings, 0 replies; 5+ messages in thread
From: zhao,meijuan @ 2018-05-18  8:10 UTC (permalink / raw)
  To: dts; +Cc: zhao,meijuan

dpdk18.05 change CONFIG_RTE_MEMPOOL_CACHE_MAX_SIZE as 512

Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
 tests/TestSuite_vf_daemon.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_vf_daemon.py b/tests/TestSuite_vf_daemon.py
index b1ad522..b8b98ba 100644
--- a/tests/TestSuite_vf_daemon.py
+++ b/tests/TestSuite_vf_daemon.py
@@ -464,7 +464,7 @@ class Testvf_daemon(TestCase):
         self.vf1_mac = self.vm1_testpmd.get_port_mac(0)
         out = self.send_and_pmdout(self.vf1_mac, 0, 64, 2000)
         out = self.vm1_testpmd.execute_cmd('show port stats 0')
-        self.verify("RX-packets: 1023" in out, 
+        self.verify("RX-packets: 511" in out, 
             "Failed to let vf1 full of queues!!!")
         out = self.send_and_pmdout(self.vf0_mac, 0, 64, 20)
         out = self.vm0_testpmd.execute_cmd('show port stats 0')
-- 
1.9.3

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-06-12  2:08 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-04  6:37 [dts] [PATCH V1] tests/vf daemon fix make queues full fail zhao,meijuan
2018-06-11  5:14 ` Liu, Yong
  -- strict thread matches above, loose matches on Subject: below --
2018-06-11 10:14 [dts] [PATCH V1] tests/vf daemon : " zhao,meijuan
2018-06-12  9:54 ` Liu, Yong
2018-05-18  8:10 [dts] [PATCH V1] tests/vf daemon: " zhao,meijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).