test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/vf daemon enable filter before disable for pf in niantic
@ 2018-06-04  7:27 zhao,meijuan
  2018-06-11  5:15 ` Liu, Yong
  0 siblings, 1 reply; 3+ messages in thread
From: zhao,meijuan @ 2018-06-04  7:27 UTC (permalink / raw)
  To: dts; +Cc: zhao,meijuan

since dpdk18.02,dpdk testpmd filter default valuechange,
pf filter default value cann't work,need enable then disable,
pf filter can work,this issue will be fixed in the next dpdk 
18.08 release

Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
 tests/TestSuite_vf_daemon.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/TestSuite_vf_daemon.py b/tests/TestSuite_vf_daemon.py
index 56fc4be..4ad4098 100644
--- a/tests/TestSuite_vf_daemon.py
+++ b/tests/TestSuite_vf_daemon.py
@@ -576,6 +576,7 @@ class Testvf_daemon(TestCase):
         if self.kdriver == "i40e":
             self.dut_testpmd.execute_cmd('set vf vlan stripq 0 0 off')
         else:
+            self.dut_testpmd.execute_cmd('vlan set filter on 0')
             self.dut_testpmd.execute_cmd('vlan set filter off 0')
             self.dut_testpmd.execute_cmd('vlan set strip off 0')
             self.vm0_testpmd.execute_cmd('vlan set strip off 0')
-- 
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/vf daemon enable filter before disable for pf in niantic
  2018-06-04  7:27 [dts] [PATCH V1] tests/vf daemon enable filter before disable for pf in niantic zhao,meijuan
@ 2018-06-11  5:15 ` Liu, Yong
  0 siblings, 0 replies; 3+ messages in thread
From: Liu, Yong @ 2018-06-11  5:15 UTC (permalink / raw)
  To: Zhao, MeijuanX, dts; +Cc: Zhao, MeijuanX

Meijuan,
Please merge this with previous one and add note into code.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan
> Sent: Monday, June 04, 2018 3:28 PM
> To: dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: [dts] [PATCH V1] tests/vf daemon enable filter before disable for
> pf in niantic
> 
> since dpdk18.02,dpdk testpmd filter default valuechange,
> pf filter default value cann't work,need enable then disable,
> pf filter can work,this issue will be fixed in the next dpdk
> 18.08 release
> 
> Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> ---
>  tests/TestSuite_vf_daemon.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/TestSuite_vf_daemon.py b/tests/TestSuite_vf_daemon.py
> index 56fc4be..4ad4098 100644
> --- a/tests/TestSuite_vf_daemon.py
> +++ b/tests/TestSuite_vf_daemon.py
> @@ -576,6 +576,7 @@ class Testvf_daemon(TestCase):
>          if self.kdriver == "i40e":
>              self.dut_testpmd.execute_cmd('set vf vlan stripq 0 0 off')
>          else:
> +            self.dut_testpmd.execute_cmd('vlan set filter on 0')
>              self.dut_testpmd.execute_cmd('vlan set filter off 0')
>              self.dut_testpmd.execute_cmd('vlan set strip off 0')
>              self.vm0_testpmd.execute_cmd('vlan set strip off 0')
> --
> 1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1] tests/vf daemon enable filter before disable for pf in niantic
@ 2018-06-11  5:57 zhao,meijuan
  0 siblings, 0 replies; 3+ messages in thread
From: zhao,meijuan @ 2018-06-11  5:57 UTC (permalink / raw)
  To: dts; +Cc: zhao,meijuan

since dpdk18.02,dpdk testpmd filter default value change, pf filter
default value cann't work for pf of niantic,need enable then disable, pf filter can
work,this issue will be fixed in the next dpdk-18.08 release

Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
 tests/TestSuite_vf_daemon.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/TestSuite_vf_daemon.py b/tests/TestSuite_vf_daemon.py
index 56fc4be..16fc7da 100644
--- a/tests/TestSuite_vf_daemon.py
+++ b/tests/TestSuite_vf_daemon.py
@@ -576,6 +576,10 @@ class Testvf_daemon(TestCase):
         if self.kdriver == "i40e":
             self.dut_testpmd.execute_cmd('set vf vlan stripq 0 0 off')
         else:
+            # since dpdk18.02,dpdk testpmd filter default value change, pf filter
+            # default value cann't work for pf of niantic,need enable then disable, pf filter can  
+            # work,this issue will be fixed in the next dpdk-18.08 release
+            self.dut_testpmd.execute_cmd('vlan set filter on 0')
             self.dut_testpmd.execute_cmd('vlan set filter off 0')
             self.dut_testpmd.execute_cmd('vlan set strip off 0')
             self.vm0_testpmd.execute_cmd('vlan set strip off 0')
-- 
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-06-11  5:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-04  7:27 [dts] [PATCH V1] tests/vf daemon enable filter before disable for pf in niantic zhao,meijuan
2018-06-11  5:15 ` Liu, Yong
2018-06-11  5:57 zhao,meijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).