test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/ieee1588: fix ieee1588 failed
@ 2018-06-05  6:32 lu,peipei
  2018-06-11  5:52 ` Liu, Yong
  0 siblings, 1 reply; 4+ messages in thread
From: lu,peipei @ 2018-06-05  6:32 UTC (permalink / raw)
  To: dts; +Cc: lu,peipei

IEEE1588 PTP V2 SYNC Message filtered by hardware need to set DEV_TX_OFFLOAD_MULTI_SEGS.

Signed-off-by: lu,peipei <peipeix.lu@intel.com>
---
 tests/TestSuite_ieee1588.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_ieee1588.py b/tests/TestSuite_ieee1588.py
index d9a7b3a..17da665 100644
--- a/tests/TestSuite_ieee1588.py
+++ b/tests/TestSuite_ieee1588.py
@@ -59,7 +59,7 @@ class TestIeee1588(TestCase):
         self.dut.build_install_dpdk(self.target)
 
         self.pmdout = PmdOutput(self.dut)
-        self.pmdout.start_testpmd("Default")
+        self.pmdout.start_testpmd("Default","--tx-offloads=0x8000")
 
     def set_up(self):
         """
-- 
1.9.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/ieee1588: fix ieee1588 failed
  2018-06-05  6:32 [dts] [PATCH V1] tests/ieee1588: fix ieee1588 failed lu,peipei
@ 2018-06-11  5:52 ` Liu, Yong
  0 siblings, 0 replies; 4+ messages in thread
From: Liu, Yong @ 2018-06-11  5:52 UTC (permalink / raw)
  To: Lu, PeipeiX, dts, Lu,  Wenzhuo; +Cc: Lu, PeipeiX

Hi Peipei,
I can't see the relationship between multiple segments and IEEE1588.  Please check with developers as it maybe one potential bug.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lu,peipei
> Sent: Tuesday, June 05, 2018 2:32 PM
> To: dts@dpdk.org
> Cc: Lu, PeipeiX <peipeix.lu@intel.com>
> Subject: [dts] [PATCH V1] tests/ieee1588: fix ieee1588 failed
> 
> IEEE1588 PTP V2 SYNC Message filtered by hardware need to set
> DEV_TX_OFFLOAD_MULTI_SEGS.
> 
> Signed-off-by: lu,peipei <peipeix.lu@intel.com>
> ---
>  tests/TestSuite_ieee1588.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_ieee1588.py b/tests/TestSuite_ieee1588.py
> index d9a7b3a..17da665 100644
> --- a/tests/TestSuite_ieee1588.py
> +++ b/tests/TestSuite_ieee1588.py
> @@ -59,7 +59,7 @@ class TestIeee1588(TestCase):
>          self.dut.build_install_dpdk(self.target)
> 
>          self.pmdout = PmdOutput(self.dut)
> -        self.pmdout.start_testpmd("Default")
> +        self.pmdout.start_testpmd("Default","--tx-offloads=0x8000")
> 
>      def set_up(self):
>          """
> --
> 1.9.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/ieee1588: fix ieee1588 failed
  2018-03-28  6:49 han,yingya
@ 2018-03-29  2:35 ` Liu, Yong
  0 siblings, 0 replies; 4+ messages in thread
From: Liu, Yong @ 2018-03-29  2:35 UTC (permalink / raw)
  To: Han, YingyaX, dts; +Cc: Lu, PeipeiX

Hi Yingya,
Just for IEEE1588 suite, I think only DEV_RX_OFFLOAD_TIMESTAMP (0x00004000) is needed. 
Enabling too much Tx offloaing flags will cause confusion.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of han,yingya
> Sent: Wednesday, March 28, 2018 2:49 PM
> To: dts@dpdk.org
> Cc: Lu, PeipeiX <peipeix.lu@intel.com>
> Subject: [dts] [PATCH V1] tests/ieee1588: fix ieee1588 failed
> 
> From: "lu,peipei" <peipeix.lu@intel.com>
> 
> IEEE1588 PTP V2 SYNC Message filtered by hardware need to set tx offloads.
> 
> Signed-off-by: lu,peipei <peipeix.lu@intel.com>
> ---
>  tests/TestSuite_ieee1588.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_ieee1588.py b/tests/TestSuite_ieee1588.py
> index d9a7b3a..eb7645f 100644
> --- a/tests/TestSuite_ieee1588.py
> +++ b/tests/TestSuite_ieee1588.py
> @@ -59,7 +59,7 @@ class TestIeee1588(TestCase):
>          self.dut.build_install_dpdk(self.target)
> 
>          self.pmdout = PmdOutput(self.dut)
> -        self.pmdout.start_testpmd("Default")
> +        self.pmdout.start_testpmd("Default","--tx-offloads=0x8ffe")
> 
>      def set_up(self):
>          """
> --
> 1.9.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH V1] tests/ieee1588: fix ieee1588 failed
@ 2018-03-28  6:49 han,yingya
  2018-03-29  2:35 ` Liu, Yong
  0 siblings, 1 reply; 4+ messages in thread
From: han,yingya @ 2018-03-28  6:49 UTC (permalink / raw)
  To: dts; +Cc: lu,peipei

From: "lu,peipei" <peipeix.lu@intel.com>

IEEE1588 PTP V2 SYNC Message filtered by hardware need to set tx offloads.

Signed-off-by: lu,peipei <peipeix.lu@intel.com>
---
 tests/TestSuite_ieee1588.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_ieee1588.py b/tests/TestSuite_ieee1588.py
index d9a7b3a..eb7645f 100644
--- a/tests/TestSuite_ieee1588.py
+++ b/tests/TestSuite_ieee1588.py
@@ -59,7 +59,7 @@ class TestIeee1588(TestCase):
         self.dut.build_install_dpdk(self.target)
 
         self.pmdout = PmdOutput(self.dut)
-        self.pmdout.start_testpmd("Default")
+        self.pmdout.start_testpmd("Default","--tx-offloads=0x8ffe")
 
     def set_up(self):
         """
-- 
1.9.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-06-11  5:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-05  6:32 [dts] [PATCH V1] tests/ieee1588: fix ieee1588 failed lu,peipei
2018-06-11  5:52 ` Liu, Yong
  -- strict thread matches above, loose matches on Subject: below --
2018-03-28  6:49 han,yingya
2018-03-29  2:35 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).