test suite reviews and discussions
 help / color / mirror / Atom feed
From: "xu,gang" <gangx.xu@intel.com>
To: dts@dpdk.org
Cc: "xu,gang" <gangx.xu@intel.com>
Subject: [dts] [PATCH V1] fix vlan filter off in invalid
Date: Tue,  5 Jun 2018 17:58:56 +0800	[thread overview]
Message-ID: <1528192737-44719-1-git-send-email-gangx.xu@intel.com> (raw)

Before the dpdk commit 8b9bd0efe0b6920a08e28eebacf2bb916bdf5653
VLAN filter and VLAN strip are enabled in testpmd by default.
But since this commit ,they are disabled by default.
so "vlam set filter off 0" can't be expected,
need "vlan set filter on 0" first

Signed-off-by: xu,gang <gangx.xu@intel.com>
---
 tests/TestSuite_generic_filter.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/TestSuite_generic_filter.py b/tests/TestSuite_generic_filter.py
index e69246b..cc7934b 100644
--- a/tests/TestSuite_generic_filter.py
+++ b/tests/TestSuite_generic_filter.py
@@ -103,8 +103,12 @@ class TestGeneric_filter(TestCase):
             self.dut.send_expect(
                 "vlan set strip off %s" % valports[1], "testpmd> ")
             self.dut.send_expect(
+                "vlan set filter on %s" % valports[0], "testpmd> ")
+            self.dut.send_expect(
                 "vlan set filter off %s" % valports[0], "testpmd> ")
             self.dut.send_expect(
+                "vlan set filter on %s" % valports[1], "testpmd> ")
+            self.dut.send_expect(
                 "vlan set filter off %s" % valports[1], "testpmd> ")
 
         self.dut.send_expect("set flush_rx on", "testpmd> ")
-- 
1.9.3

             reply	other threads:[~2018-06-05  9:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-05  9:58 xu,gang [this message]
2018-06-05  9:58 ` [dts] [PATCH V1] modify unit_tests_dump keyword matching xu,gang
2018-06-11 13:44   ` Liu, Yong
2018-06-11  5:54 ` [dts] [PATCH V1] fix vlan filter off in invalid Liu, Yong
  -- strict thread matches above, loose matches on Subject: below --
2018-05-30  8:19 xu,gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1528192737-44719-1-git-send-email-gangx.xu@intel.com \
    --to=gangx.xu@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).