test suite reviews and discussions
 help / color / mirror / Atom feed
From: "han,yingya" <yingyax.han@intel.com>
To: dts@dpdk.org
Cc: "han,yingya" <yingyax.han@intel.com>
Subject: [dts] [PATCH V1]tests/shutdown_api: fix the crc-strip issue
Date: Mon, 23 Jul 2018 17:01:01 +0800	[thread overview]
Message-ID: <1532336461-89611-1-git-send-email-yingyax.han@intel.com> (raw)

CRC strip has been modified in 1808 and the parameter of "disable-crc-strip" don't take effect.
More details can refer to dpdk commit e557ebc0.

Signed-off-by: han,yingya <yingyax.han@intel.com>
---
 tests/TestSuite_shutdown_api.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index 8b6de18..645f5c0 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -263,12 +263,13 @@ class TestShutdownApi(TestCase):
         """
         Reconfigure All Ports With The Same Configurations (CRC)
         """
-        self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop --disable-crc-strip" % utils.create_mask(self.ports), socket=self.ports_socket)
+        self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop" % utils.create_mask(self.ports), socket=self.ports_socket)
+        self.dut.send_expect("port stop all", "testpmd> ", 100)
+        self.dut.send_expect("port config all crc-strip off", "testpmd> ")
         out = self.dut.send_expect("show config rxtx", "testpmd> ")
         self.verify(
             "Rx offloads=0x0" in out, "CRC stripping not disabled properly")
 
-        self.dut.send_expect("port stop all", "testpmd> ", 100)
         self.dut.send_expect("port config all crc-strip on", "testpmd> ")
         self.dut.send_expect("set fwd mac", "testpmd>")
         self.dut.send_expect("port start all", "testpmd> ", 100)
-- 
1.9.3

             reply	other threads:[~2018-07-23  8:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-23  9:01 han,yingya [this message]
2018-07-25 11:09 ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1532336461-89611-1-git-send-email-yingyax.han@intel.com \
    --to=yingyax.han@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).