* [dts] [PATCH V1] tests/shutdown_api update Rx offloads return value after enable crc-strp
@ 2018-09-21 2:31 wenjieli
2018-09-30 6:49 ` Tu, Lijuan
0 siblings, 1 reply; 2+ messages in thread
From: wenjieli @ 2018-09-21 2:31 UTC (permalink / raw)
To: dts; +Cc: wenjieli
Due to DPDK commit 323e7b667f18376c60351282950b28d4d0cc6165, the Rx offloads return
value is changed from 0x1000 to 0x0, update dts to fit this change.
Signed-off-by: wenjieli <wenjiex.a.li@intel.com>
---
tests/TestSuite_shutdown_api.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index 52a8fbf..61a6d6b 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -274,7 +274,7 @@ class TestShutdownApi(TestCase):
self.dut.send_expect("port start all", "testpmd> ", 100)
out = self.dut.send_expect("show config rxtx", "testpmd> ")
self.verify(
- "Rx offloads=0x1000" in out, "CRC stripping not enabled properly")
+ "Rx offloads=0x0" in out, "CRC stripping not enabled properly")
self.dut.send_expect("start", "testpmd> ")
self.check_forwarding()
--
1.9.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dts] [PATCH V1] tests/shutdown_api update Rx offloads return value after enable crc-strp
2018-09-21 2:31 [dts] [PATCH V1] tests/shutdown_api update Rx offloads return value after enable crc-strp wenjieli
@ 2018-09-30 6:49 ` Tu, Lijuan
0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2018-09-30 6:49 UTC (permalink / raw)
To: Li, WenjieX A, dts; +Cc: Li, WenjieX A
>From your comments, I can't get why the return value changed to 0x0; I wish to get the reason from your comments but not to read the dpdk commit 323e7b6
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of wenjieli
> Sent: Friday, September 21, 2018 10:31 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V1] tests/shutdown_api update Rx offloads return
> value after enable crc-strp
>
> Due to DPDK commit 323e7b667f18376c60351282950b28d4d0cc6165, the
> Rx offloads return value is changed from 0x1000 to 0x0, update dts to fit this
> change.
>
> Signed-off-by: wenjieli <wenjiex.a.li@intel.com>
> ---
> tests/TestSuite_shutdown_api.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_shutdown_api.py
> b/tests/TestSuite_shutdown_api.py index 52a8fbf..61a6d6b 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -274,7 +274,7 @@ class TestShutdownApi(TestCase):
> self.dut.send_expect("port start all", "testpmd> ", 100)
> out = self.dut.send_expect("show config rxtx", "testpmd> ")
> self.verify(
> - "Rx offloads=0x1000" in out, "CRC stripping not enabled
> properly")
> + "Rx offloads=0x0" in out, "CRC stripping not enabled
> + properly")
[Lijuan] Could you define a name for the crc flag, for example, RX_OFFLOAD_KEEP_CRC = 0x1000, self.verfiy(rx_offload & RX_OFFLOAD_KEEP_CRC, "CRC keep is not enabled properly")
> self.dut.send_expect("start", "testpmd> ")
> self.check_forwarding()
>
> --
> 1.9.3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-30 6:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-21 2:31 [dts] [PATCH V1] tests/shutdown_api update Rx offloads return value after enable crc-strp wenjieli
2018-09-30 6:49 ` Tu, Lijuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).