test suite reviews and discussions
 help / color / mirror / Atom feed
From: wenjieli <wenjiex.a.li@intel.com>
To: dts@dpdk.org
Cc: wenjieli <wenjiex.a.li@intel.com>
Subject: [dts] [PATCH V1] shutdown_api/reconfigure_ports: change DEV_RX_OFFLOAD_CRC_STRIP from 0x1000 to 0x0
Date: Tue, 16 Oct 2018 10:53:33 +0800	[thread overview]
Message-ID: <1539658413-5656-1-git-send-email-wenjiex.a.li@intel.com> (raw)

"#define DEV_RX_OFFLOAD_CRC_STRIP   0x00001000" was removed from 
dpdk/lib/librte_ethdev/rte_ethdev.h since 33e7b667f18376c603512, 
the expected DEV_RX_OFFLOAD_CRC_STRIP value changed to 0x0; 
update testsuit for this changement.

Signed-off-by: wenjieli <wenjiex.a.li@intel.com>
---
 tests/TestSuite_shutdown_api.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index 52a8fbf..0f8436b 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -263,18 +263,18 @@ class TestShutdownApi(TestCase):
         """
         Reconfigure All Ports With The Same Configurations (CRC)
         """
+        DEV_RX_OFFLOAD_KEEP_CRC="0x10000"
+        DEV_RX_OFFLOAD_CRC_STRIP="0x0"
         self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop --disable-crc-strip" % utils.create_mask(self.ports), socket=self.ports_socket)
         out = self.dut.send_expect("show config rxtx", "testpmd> ")
-        self.verify(
-            "Rx offloads=0x10000" in out, "CRC keeping not enabled properly")
+        self.verify("Rx offloads=%s" % DEV_RX_OFFLOAD_KEEP_CRC in out, "CRC keeping not enabled properly")
 
         self.dut.send_expect("port stop all", "testpmd> ", 100)
         self.dut.send_expect("port config all crc-strip on", "testpmd> ")
         self.dut.send_expect("set fwd mac", "testpmd>")
         self.dut.send_expect("port start all", "testpmd> ", 100)
         out = self.dut.send_expect("show config rxtx", "testpmd> ")
-        self.verify(
-            "Rx offloads=0x1000" in out, "CRC stripping not enabled properly")
+        self.verify("Rx offloads=%s" % DEV_RX_OFFLOAD_CRC_STRIP in out, "CRC stripping not enabled properly")
         self.dut.send_expect("start", "testpmd> ")
         self.check_forwarding()
 
-- 
2.17.2

             reply	other threads:[~2018-10-16  2:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-16  2:53 wenjieli [this message]
2018-10-22  2:28 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1539658413-5656-1-git-send-email-wenjiex.a.li@intel.com \
    --to=wenjiex.a.li@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).