From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id A01372BC8 for ; Tue, 16 Oct 2018 04:50:38 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Oct 2018 19:50:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,386,1534834800"; d="scan'208";a="95532916" Received: from unknown (HELO localhost.localdomain.sh.intel.com) ([10.240.176.135]) by fmsmga002.fm.intel.com with ESMTP; 15 Oct 2018 19:50:35 -0700 From: wenjieli To: dts@dpdk.org Cc: wenjieli Date: Tue, 16 Oct 2018 10:53:33 +0800 Message-Id: <1539658413-5656-1-git-send-email-wenjiex.a.li@intel.com> X-Mailer: git-send-email 1.9.3 Subject: [dts] [PATCH V1] shutdown_api/reconfigure_ports: change DEV_RX_OFFLOAD_CRC_STRIP from 0x1000 to 0x0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2018 02:50:39 -0000 "#define DEV_RX_OFFLOAD_CRC_STRIP 0x00001000" was removed from dpdk/lib/librte_ethdev/rte_ethdev.h since 33e7b667f18376c603512, the expected DEV_RX_OFFLOAD_CRC_STRIP value changed to 0x0; update testsuit for this changement. Signed-off-by: wenjieli --- tests/TestSuite_shutdown_api.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py index 52a8fbf..0f8436b 100644 --- a/tests/TestSuite_shutdown_api.py +++ b/tests/TestSuite_shutdown_api.py @@ -263,18 +263,18 @@ class TestShutdownApi(TestCase): """ Reconfigure All Ports With The Same Configurations (CRC) """ + DEV_RX_OFFLOAD_KEEP_CRC="0x10000" + DEV_RX_OFFLOAD_CRC_STRIP="0x0" self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop --disable-crc-strip" % utils.create_mask(self.ports), socket=self.ports_socket) out = self.dut.send_expect("show config rxtx", "testpmd> ") - self.verify( - "Rx offloads=0x10000" in out, "CRC keeping not enabled properly") + self.verify("Rx offloads=%s" % DEV_RX_OFFLOAD_KEEP_CRC in out, "CRC keeping not enabled properly") self.dut.send_expect("port stop all", "testpmd> ", 100) self.dut.send_expect("port config all crc-strip on", "testpmd> ") self.dut.send_expect("set fwd mac", "testpmd>") self.dut.send_expect("port start all", "testpmd> ", 100) out = self.dut.send_expect("show config rxtx", "testpmd> ") - self.verify( - "Rx offloads=0x1000" in out, "CRC stripping not enabled properly") + self.verify("Rx offloads=%s" % DEV_RX_OFFLOAD_CRC_STRIP in out, "CRC stripping not enabled properly") self.dut.send_expect("start", "testpmd> ") self.check_forwarding() -- 2.17.2