test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1 1/7] tests/ipgre: change parse_tunnel to parse-tunnel
@ 2018-10-17  2:37 wenjieli
  2018-10-17  2:37 ` [dts] [PATCH V1 2/7] test_plans/ipgre: " wenjieli
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: wenjieli @ 2018-10-17  2:37 UTC (permalink / raw)
  To: dts; +Cc: wenjieli

In dpdk commit 5b48cd159536b70a943ae8246c2f717183818b19:
    app/testpmd: fix csum parse-tunnel command invocation
    Based on the documentation and help print, the sub command
    for csum suppose to be "parse-tunnel" instead of "parse_tunnel"
    in app/test-pmd/cmdline.c.
Update tests/ipgre to fit this changement.

Signed-off-by: wenjieli <wenjiex.a.li@intel.com>
---
 tests/TestSuite_ipgre.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py
index 2dccb9c..564ffb6 100644
--- a/tests/TestSuite_ipgre.py
+++ b/tests/TestSuite_ipgre.py
@@ -318,7 +318,7 @@ class TestIpgre(TestCase):
         self.dut.send_expect("csum set sctp hw 0", "testpmd>")
         self.dut.send_expect("csum set outer-ip hw 0", "testpmd>")
         self.dut.send_expect("csum set tcp hw 0", "testpmd>")
-        self.dut.send_expect("csum parse_tunnel on 0", "testpmd>")
+        self.dut.send_expect("csum parse-tunnel on 0", "testpmd>")
         self.dut.send_expect("port start all", "testpmd>")
         self.dut.send_expect("start", "testpmd>")
 
-- 
2.17.2

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dts] [PATCH V1 2/7] test_plans/ipgre: change parse_tunnel to parse-tunnel
  2018-10-17  2:37 [dts] [PATCH V1 1/7] tests/ipgre: change parse_tunnel to parse-tunnel wenjieli
@ 2018-10-17  2:37 ` wenjieli
  2018-10-17  2:37 ` [dts] [PATCH V1 3/7] tests/nvgre: " wenjieli
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: wenjieli @ 2018-10-17  2:37 UTC (permalink / raw)
  To: dts; +Cc: wenjieli

In dpdk commit 5b48cd159536b70a943ae8246c2f717183818b19:
    app/testpmd: fix csum parse-tunnel command invocation
    Based on the documentation and help print, the sub command
    for csum suppose to be "parse-tunnel" instead of "parse_tunnel"
    in app/test-pmd/cmdline.c.
Update test_plans/ipgre to fit this changement.

Signed-off-by: wenjieli <wenjiex.a.li@intel.com>
---
 test_plans/ipgre_test_plan.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test_plans/ipgre_test_plan.rst b/test_plans/ipgre_test_plan.rst
index 3ca9af7..97c4a51 100644
--- a/test_plans/ipgre_test_plan.rst
+++ b/test_plans/ipgre_test_plan.rst
@@ -169,7 +169,7 @@ Start testpmd with hardware checksum offload enabled::
     testpmd> csum set sctp hw 0
     testpmd> csum set outer-ip hw 0
     testpmd> csum set tcp hw 0
-    testpmd> csum parse_tunnel on 0
+    testpmd> csum parse-tunnel on 0
     testpmd> start
 
 Send packet with wrong outer IP checksum and check forwarded packet IP
-- 
2.17.2

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dts] [PATCH V1 3/7] tests/nvgre: change parse_tunnel to parse-tunnel
  2018-10-17  2:37 [dts] [PATCH V1 1/7] tests/ipgre: change parse_tunnel to parse-tunnel wenjieli
  2018-10-17  2:37 ` [dts] [PATCH V1 2/7] test_plans/ipgre: " wenjieli
@ 2018-10-17  2:37 ` wenjieli
  2018-10-17  2:37 ` [dts] [PATCH V1 4/7] test_plans/nvgre: " wenjieli
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: wenjieli @ 2018-10-17  2:37 UTC (permalink / raw)
  To: dts; +Cc: wenjieli

In dpdk commit 5b48cd159536b70a943ae8246c2f717183818b19:
    app/testpmd: fix csum parse-tunnel command invocation
    Based on the documentation and help print, the sub command
    for csum suppose to be "parse-tunnel" instead of "parse_tunnel"
    in app/test-pmd/cmdline.c.
Update tests/nvgre to fit this changement.

Signed-off-by: wenjieli <wenjiex.a.li@intel.com>
---
 tests/TestSuite_nvgre.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_nvgre.py b/tests/TestSuite_nvgre.py
index 99b8490..b9aa990 100644
--- a/tests/TestSuite_nvgre.py
+++ b/tests/TestSuite_nvgre.py
@@ -557,7 +557,7 @@ class TestNvgre(TestCase):
         self.dut.send_expect("csum set tcp hw %d" % (self.dut_tx_port), "testpmd>", 10)
         self.dut.send_expect("csum set sctp hw %d" % (self.dut_tx_port), "testpmd>", 10)
         self.dut.send_expect("csum set outer-ip hw %d" % (self.dut_tx_port), "testpmd>", 10)
-        self.dut.send_expect("csum parse_tunnel on %d" % (self.dut_tx_port), "testpmd>", 10)
+        self.dut.send_expect("csum parse-tunnel on %d" % (self.dut_tx_port), "testpmd>", 10)
         self.dut.send_expect("port start all", "testpmd>")
 
         # log the nvgre format
-- 
2.17.2

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dts] [PATCH V1 4/7] test_plans/nvgre: change parse_tunnel to parse-tunnel
  2018-10-17  2:37 [dts] [PATCH V1 1/7] tests/ipgre: change parse_tunnel to parse-tunnel wenjieli
  2018-10-17  2:37 ` [dts] [PATCH V1 2/7] test_plans/ipgre: " wenjieli
  2018-10-17  2:37 ` [dts] [PATCH V1 3/7] tests/nvgre: " wenjieli
@ 2018-10-17  2:37 ` wenjieli
  2018-10-17  2:37 ` [dts] [PATCH V1 5/7] tests/vxlan: " wenjieli
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: wenjieli @ 2018-10-17  2:37 UTC (permalink / raw)
  To: dts; +Cc: wenjieli

In dpdk commit 5b48cd159536b70a943ae8246c2f717183818b19:
    app/testpmd: fix csum parse-tunnel command invocation
    Based on the documentation and help print, the sub command
    for csum suppose to be "parse-tunnel" instead of "parse_tunnel"
    in app/test-pmd/cmdline.c.
Update test_plans/nvgre to fit this changement.

Signed-off-by: wenjieli <wenjiex.a.li@intel.com>
---
 test_plans/nvgre_test_plan.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test_plans/nvgre_test_plan.rst b/test_plans/nvgre_test_plan.rst
index 7f71eb2..970b338 100644
--- a/test_plans/nvgre_test_plan.rst
+++ b/test_plans/nvgre_test_plan.rst
@@ -273,7 +273,7 @@ Set csum packet forwarding mode and enable verbose log::
     csum set tcp hw <dut tx_port>
     csum set sctp hw <dut tx_port>
     csum set nvgre hw <dut tx_port>
-    csum parse_tunnel on <dut tx_port>
+    csum parse-tunnel on <dut tx_port>
     set verbose 1
 
 Send packet with invalid checksum first. Then check forwarded packet checksum
@@ -316,7 +316,7 @@ Set csum packet forwarding mode and enable verbose log::
     csum set tcp hw <dut tx_port>
     csum set sctp hw <dut tx_port>
     csum set nvgre hw <dut tx_port>
-    csum parse_tunnel on <dut tx_port>
+    csum parse-tunnel on <dut tx_port>
     set verbose 1
 
 Send packet with invalid checksum first. Then check forwarded packet checksum
-- 
2.17.2

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dts] [PATCH V1 5/7] tests/vxlan: change parse_tunnel to parse-tunnel
  2018-10-17  2:37 [dts] [PATCH V1 1/7] tests/ipgre: change parse_tunnel to parse-tunnel wenjieli
                   ` (2 preceding siblings ...)
  2018-10-17  2:37 ` [dts] [PATCH V1 4/7] test_plans/nvgre: " wenjieli
@ 2018-10-17  2:37 ` wenjieli
  2018-10-17  2:37 ` [dts] [PATCH V1 6/7] test_plans/vxlan: " wenjieli
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: wenjieli @ 2018-10-17  2:37 UTC (permalink / raw)
  To: dts; +Cc: wenjieli

In dpdk commit 5b48cd159536b70a943ae8246c2f717183818b19:
    app/testpmd: fix csum parse-tunnel command invocation
    Based on the documentation and help print, the sub command
    for csum suppose to be "parse-tunnel" instead of "parse_tunnel"
    in app/test-pmd/cmdline.c.
Update tests/vxlan to fit this changement.

Signed-off-by: wenjieli <wenjiex.a.li@intel.com>
---
 tests/TestSuite_vxlan.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py
index ab9f691..d5a9d77 100644
--- a/tests/TestSuite_vxlan.py
+++ b/tests/TestSuite_vxlan.py
@@ -664,7 +664,7 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
         self.csum_set_type('tcp', self.recv_port)
         self.csum_set_type('sctp', self.recv_port)
         self.dut.send_expect("port start all", "testpmd>")
-        self.dut.send_expect("csum parse_tunnel on %d" %
+        self.dut.send_expect("csum parse-tunnel on %d" %
                              self.recv_port, "testpmd>", 10)
 
         self.enable_vxlan(self.dut_port)
@@ -736,7 +736,7 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
         self.csum_set_type('udp', self.recv_port)
         self.csum_set_type('tcp', self.recv_port)
         self.csum_set_type('sctp', self.recv_port)
-        self.dut.send_expect("csum parse_tunnel on %d" %
+        self.dut.send_expect("csum parse-tunnel on %d" %
                              self.recv_port, "testpmd>", 10)
 
         self.enable_vxlan(self.dut_port)
@@ -1089,9 +1089,9 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
 
             self.dut.send_expect(pmd_cmd, "testpmd> ", 100)
             self.dut.send_expect("set fwd csum", "testpmd>", 10)
-            self.dut.send_expect("csum parse_tunnel on %d" %
+            self.dut.send_expect("csum parse-tunnel on %d" %
                                  self.dut_port, "testpmd>", 10)
-            self.dut.send_expect("csum parse_tunnel on %d" %
+            self.dut.send_expect("csum parse-tunnel on %d" %
                                  self.recv_port, "testpmd>", 10)
             self.enable_vxlan(self.dut_port)
             self.enable_vxlan(self.recv_port)
-- 
2.17.2

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dts] [PATCH V1 6/7] test_plans/vxlan: change parse_tunnel to parse-tunnel
  2018-10-17  2:37 [dts] [PATCH V1 1/7] tests/ipgre: change parse_tunnel to parse-tunnel wenjieli
                   ` (3 preceding siblings ...)
  2018-10-17  2:37 ` [dts] [PATCH V1 5/7] tests/vxlan: " wenjieli
@ 2018-10-17  2:37 ` wenjieli
  2018-10-17  2:37 ` [dts] [PATCH V1 7/7] tests/tso: " wenjieli
  2018-10-17 15:58 ` [dts] [PATCH V1 1/7] tests/ipgre: " Lijuan Tu
  6 siblings, 0 replies; 8+ messages in thread
From: wenjieli @ 2018-10-17  2:37 UTC (permalink / raw)
  To: dts; +Cc: wenjieli

In dpdk commit 5b48cd159536b70a943ae8246c2f717183818b19:
    app/testpmd: fix csum parse-tunnel command invocation
    Based on the documentation and help print, the sub command
    for csum suppose to be "parse-tunnel" instead of "parse_tunnel"
    in app/test-pmd/cmdline.c.
Update test_plans/vxlan to fit this changement.

Signed-off-by: wenjieli <wenjiex.a.li@intel.com>
---
 test_plans/vxlan_test_plan.rst | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/test_plans/vxlan_test_plan.rst b/test_plans/vxlan_test_plan.rst
index c058637..83c99ac 100644
--- a/test_plans/vxlan_test_plan.rst
+++ b/test_plans/vxlan_test_plan.rst
@@ -139,8 +139,8 @@ Enable VXLAN protocol on ports::
 
 Enable IP,UDP,TCP,SCTP,OUTER-IP checksum offload::
 
-    csum parse_tunnel on 0
-    csum parse_tunnel on 1
+    csum parse-tunnel on 0
+    csum parse-tunnel on 1
     csum set ip hw 0
     csum set udp hw 0
     csum set tcp hw 0
@@ -236,8 +236,8 @@ Enable VXLAN protocol on ports::
 
 Enable IP,UDP,TCP,SCTP,VXLAN checksum offload::
 
-    csum parse_tunnel on 0
-    csum parse_tunnel on 1
+    csum parse-tunnel on 0
+    csum parse-tunnel on 1
     csum set ip hw 0
     csum set udp hw 0
     csum set tcp hw 0
-- 
2.17.2

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dts] [PATCH V1 7/7] tests/tso: change parse_tunnel to parse-tunnel
  2018-10-17  2:37 [dts] [PATCH V1 1/7] tests/ipgre: change parse_tunnel to parse-tunnel wenjieli
                   ` (4 preceding siblings ...)
  2018-10-17  2:37 ` [dts] [PATCH V1 6/7] test_plans/vxlan: " wenjieli
@ 2018-10-17  2:37 ` wenjieli
  2018-10-17 15:58 ` [dts] [PATCH V1 1/7] tests/ipgre: " Lijuan Tu
  6 siblings, 0 replies; 8+ messages in thread
From: wenjieli @ 2018-10-17  2:37 UTC (permalink / raw)
  To: dts; +Cc: wenjieli

In dpdk commit 5b48cd159536b70a943ae8246c2f717183818b19:
    app/testpmd: fix csum parse-tunnel command invocation
    Based on the documentation and help print, the sub command
    for csum suppose to be "parse-tunnel" instead of "parse_tunnel"
    in app/test-pmd/cmdline.c.
Update tests/tso to fit this changement.

Signed-off-by: wenjieli <wenjiex.a.li@intel.com>
---
 tests/TestSuite_tso.py | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/TestSuite_tso.py b/tests/TestSuite_tso.py
index 0a9d66c..8dc84c2 100644
--- a/tests/TestSuite_tso.py
+++ b/tests/TestSuite_tso.py
@@ -165,14 +165,14 @@ class TestTSO(TestCase):
         self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[0], "testpmd> ", 120)
         self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[0], "testpmd> ", 120)
         self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[0], "testpmd> ", 120)
-        self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[0], "testpmd> ", 120)
+        self.dut.send_expect("csum parse-tunnel on %d" % self.dut_ports[0], "testpmd> ", 120)
 
         self.dut.send_expect("csum set ip hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set udp hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[1], "testpmd> ", 120)
-        self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[1], "testpmd> ", 120)
+        self.dut.send_expect("csum parse-tunnel on %d" % self.dut_ports[1], "testpmd> ", 120)
 
         self.dut.send_expect("tso set 800 %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("set fwd csum", "testpmd> ", 120)
@@ -231,14 +231,14 @@ class TestTSO(TestCase):
         self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[0], "testpmd> ", 120)
         self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[0], "testpmd> ", 120)
         self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[0], "testpmd> ", 120)
-        self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[0], "testpmd> ", 120)
+        self.dut.send_expect("csum parse-tunnel on %d" % self.dut_ports[0], "testpmd> ", 120)
 
         self.dut.send_expect("csum set ip hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set udp hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[1], "testpmd> ", 120)
-        self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[1], "testpmd> ", 120)
+        self.dut.send_expect("csum parse-tunnel on %d" % self.dut_ports[1], "testpmd> ", 120)
 
         self.dut.send_expect("tso set 800 %d" % self.dut_ports[1], "testpmd> ", 120)
         self.dut.send_expect("set fwd csum", "testpmd> ", 120)
@@ -300,13 +300,13 @@ class TestTSO(TestCase):
             self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[0], "testpmd> ", 120)
             self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[0], "testpmd> ", 120)
             self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[0], "testpmd> ", 120)
-            self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[0], "testpmd> ", 120)
+            self.dut.send_expect("csum parse-tunnel on %d" % self.dut_ports[0], "testpmd> ", 120)
             self.dut.send_expect("csum set ip hw %d" % self.dut_ports[1], "testpmd> ", 120)
             self.dut.send_expect("csum set udp hw %d" % self.dut_ports[1], "testpmd> ", 120)
             self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[1], "testpmd> ", 120)
             self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[1], "testpmd> ", 120)
             self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[1], "testpmd> ", 120)
-            self.dut.send_expect("csum parse_tunnel on %d" % self.dut_ports[1], "testpmd> ", 120)
+            self.dut.send_expect("csum parse-tunnel on %d" % self.dut_ports[1], "testpmd> ", 120)
             self.dut.send_expect("tso set 800 %d" % self.dut_ports[1], "testpmd> ", 120)
             self.dut.send_expect("set fwd csum", "testpmd> ", 120)
             self.dut.send_expect("start", "testpmd> ")
-- 
2.17.2

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dts] [PATCH V1 1/7] tests/ipgre: change parse_tunnel to parse-tunnel
  2018-10-17  2:37 [dts] [PATCH V1 1/7] tests/ipgre: change parse_tunnel to parse-tunnel wenjieli
                   ` (5 preceding siblings ...)
  2018-10-17  2:37 ` [dts] [PATCH V1 7/7] tests/tso: " wenjieli
@ 2018-10-17 15:58 ` Lijuan Tu
  6 siblings, 0 replies; 8+ messages in thread
From: Lijuan Tu @ 2018-10-17 15:58 UTC (permalink / raw)
  To: wenjieli, dts

Applied, thanks


On 2018年10月17日 10:37, wenjieli wrote:
> In dpdk commit 5b48cd159536b70a943ae8246c2f717183818b19:
>      app/testpmd: fix csum parse-tunnel command invocation
>      Based on the documentation and help print, the sub command
>      for csum suppose to be "parse-tunnel" instead of "parse_tunnel"
>      in app/test-pmd/cmdline.c.
> Update tests/ipgre to fit this changement.
>
> Signed-off-by: wenjieli <wenjiex.a.li@intel.com>
> ---
>   tests/TestSuite_ipgre.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py
> index 2dccb9c..564ffb6 100644
> --- a/tests/TestSuite_ipgre.py
> +++ b/tests/TestSuite_ipgre.py
> @@ -318,7 +318,7 @@ class TestIpgre(TestCase):
>           self.dut.send_expect("csum set sctp hw 0", "testpmd>")
>           self.dut.send_expect("csum set outer-ip hw 0", "testpmd>")
>           self.dut.send_expect("csum set tcp hw 0", "testpmd>")
> -        self.dut.send_expect("csum parse_tunnel on 0", "testpmd>")
> +        self.dut.send_expect("csum parse-tunnel on 0", "testpmd>")
>           self.dut.send_expect("port start all", "testpmd>")
>           self.dut.send_expect("start", "testpmd>")
>   

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-10-17  7:30 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-17  2:37 [dts] [PATCH V1 1/7] tests/ipgre: change parse_tunnel to parse-tunnel wenjieli
2018-10-17  2:37 ` [dts] [PATCH V1 2/7] test_plans/ipgre: " wenjieli
2018-10-17  2:37 ` [dts] [PATCH V1 3/7] tests/nvgre: " wenjieli
2018-10-17  2:37 ` [dts] [PATCH V1 4/7] test_plans/nvgre: " wenjieli
2018-10-17  2:37 ` [dts] [PATCH V1 5/7] tests/vxlan: " wenjieli
2018-10-17  2:37 ` [dts] [PATCH V1 6/7] test_plans/vxlan: " wenjieli
2018-10-17  2:37 ` [dts] [PATCH V1 7/7] tests/tso: " wenjieli
2018-10-17 15:58 ` [dts] [PATCH V1 1/7] tests/ipgre: " Lijuan Tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).