test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/ptype_mapping: align changes with dpdk
@ 2018-10-22  9:31 yaobing
  0 siblings, 0 replies; 3+ messages in thread
From: yaobing @ 2018-10-22  9:31 UTC (permalink / raw)
  To: dts; +Cc: yaobing, Lijuan Tu

get local coremask due to script hard code

Since dpdk commit b2fd027389 changes the file app/test-pmd/rxonly.c,
test cases should be aligned with dpdk.

Signed-off-by: Lijuan Tu <lijuan.tu@intel.com>
Signed-off-by: yaobing <bingx.y.yao@intel.com>
---
 tests/TestSuite_ptype_mapping.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_ptype_mapping.py b/tests/TestSuite_ptype_mapping.py
index 8f310e8..1581887 100644
--- a/tests/TestSuite_ptype_mapping.py
+++ b/tests/TestSuite_ptype_mapping.py
@@ -53,8 +53,9 @@ class TestPtype_Mapping(TestCase):
         self.dut_port = valports[0]
         tester_port = self.tester.get_local_port(self.dut_port)
         self.tester_iface = self.tester.get_interface(tester_port)
-        self.dut.send_expect("sed -i -e '/mb->vlan_tci, mb->vlan_tci_outer);" +\
-            "/a\printf(\" - pktype: 0x%x\", mb->packet_type);'" +\
+        self.dut.send_expect("sed -i -e '" +\
+            "/rte_get_ptype_name(mb->packet_type, buf, sizeof(buf));" +\
+            "/a\\\\t\\t\\tprintf(\" - pktype: 0x%x\", mb->packet_type);'" +\
             " app/test-pmd/rxonly.c", "# ", 30, verify = True)
         self.dut.build_install_dpdk(self.dut.target)
         
-- 
2.17.2

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/ptype_mapping: align changes with dpdk
  2018-11-01 10:01 wenjieli
@ 2018-11-05 10:41 ` Lijuan Tu
  0 siblings, 0 replies; 3+ messages in thread
From: Lijuan Tu @ 2018-11-05 10:41 UTC (permalink / raw)
  To: wenjieli, dts

Applied, thanks


On 2018年11月01日 18:01, wenjieli wrote:
> Since dpdk commit 739e13bcc98f56 changes the file app/test-pmd/rxonly.c,
> test cases should be aligned with dpdk. Print "pktype" in
> app/test-pmd/util.c instead of app/test-pmd/rxonly.c.
>
> Signed-off-by: wenjieli <wenjiex.a.li@intel.com>
> ---
>   tests/TestSuite_ptype_mapping.py | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/tests/TestSuite_ptype_mapping.py b/tests/TestSuite_ptype_mapping.py
> index 1581887..7838ee7 100644
> --- a/tests/TestSuite_ptype_mapping.py
> +++ b/tests/TestSuite_ptype_mapping.py
> @@ -54,9 +54,10 @@ class TestPtype_Mapping(TestCase):
>           tester_port = self.tester.get_local_port(self.dut_port)
>           self.tester_iface = self.tester.get_interface(tester_port)
>           self.dut.send_expect("sed -i -e '" +\
> -            "/rte_get_ptype_name(mb->packet_type, buf, sizeof(buf));" +\
> -            "/a\\\\t\\t\\tprintf(\" - pktype: 0x%x\", mb->packet_type);'" +\
> -            " app/test-pmd/rxonly.c", "# ", 30, verify = True)
> +            "/printf(\" - VLAN tci=0x%x\", mb->vlan_tci);" +\
> +            "/a\\\\t\\tprintf(\" - pktype: 0x%x\", mb->packet_type);'" +\
> +            " app/test-pmd/util.c", "# ", 30, verify = True)
> +
>           self.dut.build_install_dpdk(self.dut.target)
>           
>   
> @@ -231,7 +232,7 @@ class TestPtype_Mapping(TestCase):
>           Run after each test suite.
>           """
>           self.dut.send_expect("sed -i '/printf(\" - pktype: 0x%x\", " +\
> -            "mb->packet_type);/d' app/test-pmd/rxonly.c", "# ", 30, verify = True)
> +            "mb->packet_type);/d' app/test-pmd/util.c", "# ", 30, verify = True)
>           self.dut.build_install_dpdk(self.dut.target)
>           self.dut.kill_all()
>           pass

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1] tests/ptype_mapping: align changes with dpdk
@ 2018-11-01 10:01 wenjieli
  2018-11-05 10:41 ` Lijuan Tu
  0 siblings, 1 reply; 3+ messages in thread
From: wenjieli @ 2018-11-01 10:01 UTC (permalink / raw)
  To: dts; +Cc: wenjieli

Since dpdk commit 739e13bcc98f56 changes the file app/test-pmd/rxonly.c, 
test cases should be aligned with dpdk. Print "pktype" in
app/test-pmd/util.c instead of app/test-pmd/rxonly.c.

Signed-off-by: wenjieli <wenjiex.a.li@intel.com>
---
 tests/TestSuite_ptype_mapping.py | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_ptype_mapping.py b/tests/TestSuite_ptype_mapping.py
index 1581887..7838ee7 100644
--- a/tests/TestSuite_ptype_mapping.py
+++ b/tests/TestSuite_ptype_mapping.py
@@ -54,9 +54,10 @@ class TestPtype_Mapping(TestCase):
         tester_port = self.tester.get_local_port(self.dut_port)
         self.tester_iface = self.tester.get_interface(tester_port)
         self.dut.send_expect("sed -i -e '" +\
-            "/rte_get_ptype_name(mb->packet_type, buf, sizeof(buf));" +\
-            "/a\\\\t\\t\\tprintf(\" - pktype: 0x%x\", mb->packet_type);'" +\
-            " app/test-pmd/rxonly.c", "# ", 30, verify = True)
+            "/printf(\" - VLAN tci=0x%x\", mb->vlan_tci);" +\
+            "/a\\\\t\\tprintf(\" - pktype: 0x%x\", mb->packet_type);'" +\
+            " app/test-pmd/util.c", "# ", 30, verify = True)
+
         self.dut.build_install_dpdk(self.dut.target)
         
 
@@ -231,7 +232,7 @@ class TestPtype_Mapping(TestCase):
         Run after each test suite.
         """
         self.dut.send_expect("sed -i '/printf(\" - pktype: 0x%x\", " +\
-            "mb->packet_type);/d' app/test-pmd/rxonly.c", "# ", 30, verify = True)
+            "mb->packet_type);/d' app/test-pmd/util.c", "# ", 30, verify = True)
         self.dut.build_install_dpdk(self.dut.target)
         self.dut.kill_all()
         pass
-- 
2.17.2

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-05  2:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-22  9:31 [dts] [PATCH V1] tests/ptype_mapping: align changes with dpdk yaobing
2018-11-01 10:01 wenjieli
2018-11-05 10:41 ` Lijuan Tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).