From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 1254C5B40 for ; Tue, 23 Oct 2018 07:11:12 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Oct 2018 22:11:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,414,1534834800"; d="scan'208";a="97684199" Received: from unknown (HELO localhost.localdomain.sh.intel.com) ([10.240.176.135]) by fmsmga002.fm.intel.com with ESMTP; 22 Oct 2018 22:11:11 -0700 From: wenjieli To: dts@dpdk.org Cc: wenjieli Date: Tue, 23 Oct 2018 13:14:12 +0800 Message-Id: <1540271652-4683-1-git-send-email-wenjiex.a.li@intel.com> X-Mailer: git-send-email 1.9.3 Subject: [dts] [PATCH V2] tests/shutdown_api: check crc strip bit instead of Rx offloads to verify CRC is enabled or not X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2018 05:11:13 -0000 If crc strip enabled, the crc strip bit (bit 12) is 0, else it is 1. Use this bit to check crc is enabled or not, will not just check the Rx offloads value in output. Signed-off-by: wenjieli --- tests/TestSuite_shutdown_api.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py index 52a8fbf..decd9a7 100644 --- a/tests/TestSuite_shutdown_api.py +++ b/tests/TestSuite_shutdown_api.py @@ -263,6 +263,8 @@ class TestShutdownApi(TestCase): """ Reconfigure All Ports With The Same Configurations (CRC) """ + RX_OFFLOAD_KEEP_CRC = 0x1000 + CRC_Strip_bit = 0 self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop --disable-crc-strip" % utils.create_mask(self.ports), socket=self.ports_socket) out = self.dut.send_expect("show config rxtx", "testpmd> ") self.verify( @@ -273,8 +275,10 @@ class TestShutdownApi(TestCase): self.dut.send_expect("set fwd mac", "testpmd>") self.dut.send_expect("port start all", "testpmd> ", 100) out = self.dut.send_expect("show config rxtx", "testpmd> ") + Rx_offloads = re.compile('Rx offloads=(.*?)\s+?').findall(out, re.S) self.verify( - "Rx offloads=0x1000" in out, "CRC stripping not enabled properly") + RX_OFFLOAD_KEEP_CRC & int(Rx_offloads[0],16) == CRC_Strip_bit and RX_OFFLOAD_KEEP_CRC & int(Rx_offloads[1],16) == CRC_Strip_bit, + "CRC stripping not enabled properly") self.dut.send_expect("start", "testpmd> ") self.check_forwarding() -- 2.17.2