From: wenjieli <wenjiex.a.li@intel.com>
To: dts@dpdk.org
Cc: wenjieli <wenjiex.a.li@intel.com>
Subject: [dts] [PATCH V3] tests/shutdown_api: check crc strip bit instead of Rx offloads to verify CRC is enabled or not
Date: Wed, 24 Oct 2018 17:12:11 +0800 [thread overview]
Message-ID: <1540372331-10787-1-git-send-email-wenjiex.a.li@intel.com> (raw)
If crc strip is enabled, the crc strip bit (bit 16) is 0, else it is 1.
Use this bit to check crc is enabled or not, will not just check the
Rx offloads value in output.
Signed-off-by: wenjieli <wenjiex.a.li@intel.com>
---
tests/TestSuite_shutdown_api.py | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index 52a8fbf..1282cf7 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -263,18 +263,24 @@ class TestShutdownApi(TestCase):
"""
Reconfigure All Ports With The Same Configurations (CRC)
"""
+ RX_OFFLOAD_KEEP_CRC = 0x10000
+
self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop --disable-crc-strip" % utils.create_mask(self.ports), socket=self.ports_socket)
out = self.dut.send_expect("show config rxtx", "testpmd> ")
+ Rx_offloads = re.compile('Rx offloads=(.*?)\s+?').findall(out, re.S)
+ crc_keep = int(Rx_offloads[0],16) & RX_OFFLOAD_KEEP_CRC and int(Rx_offloads[1],16) & RX_OFFLOAD_KEEP_CRC
self.verify(
- "Rx offloads=0x10000" in out, "CRC keeping not enabled properly")
+ crc_keep == RX_OFFLOAD_KEEP_CRC, "CRC keeping not enabled properly")
self.dut.send_expect("port stop all", "testpmd> ", 100)
self.dut.send_expect("port config all crc-strip on", "testpmd> ")
self.dut.send_expect("set fwd mac", "testpmd>")
self.dut.send_expect("port start all", "testpmd> ", 100)
out = self.dut.send_expect("show config rxtx", "testpmd> ")
+ Rx_offloads = re.compile('Rx offloads=(.*?)\s+?').findall(out, re.S)
+ crc_strip = int(Rx_offloads[0],16) | ~RX_OFFLOAD_KEEP_CRC and int(Rx_offloads[1],16) | ~RX_OFFLOAD_KEEP_CRC
self.verify(
- "Rx offloads=0x1000" in out, "CRC stripping not enabled properly")
+ crc_strip == ~RX_OFFLOAD_KEEP_CRC, "CRC stripping not enabled properly")
self.dut.send_expect("start", "testpmd> ")
self.check_forwarding()
--
2.17.2
next reply other threads:[~2018-10-24 9:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 9:12 wenjieli [this message]
2018-10-25 8:50 ` Tu, Lijuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1540372331-10787-1-git-send-email-wenjiex.a.li@intel.com \
--to=wenjiex.a.li@intel.com \
--cc=dts@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).