test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V2] tests/shutdown_api: add sagepond support speed to change_linkspeed
@ 2018-10-26 10:24 wenjieli
  2018-10-30 15:22 ` Lijuan Tu
  0 siblings, 1 reply; 2+ messages in thread
From: wenjieli @ 2018-10-26 10:24 UTC (permalink / raw)
  To: dts; +Cc: wenjieli

Sagepond nic only support 1000baseT and 10000baseT, but the peer nic
might support more speeds, sagepond could be set to unsupport mode; to
avoid such issue, add sagepond support speed to change_linkspeed case.

Signed-off-by: wenjieli <wenjiex.a.li@intel.com>
---
 tests/TestSuite_shutdown_api.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index 1282cf7..ba4c6cb 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -312,6 +312,9 @@ class TestShutdownApi(TestCase):
             elif self.nic in ["fortville_eagle"]:
                 if config[0] != '10000':
                     continue
+            elif self.nic in ["sagepond"]:
+                if config[0] != '1000' and '10000':
+                    continue
             self.dut.send_expect("port stop all", "testpmd> ", 100)
             for port in self.ports:
                 self.dut.send_expect("port config %d speed %s duplex %s" % (port,
-- 
2.17.2

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V2] tests/shutdown_api: add sagepond support speed to change_linkspeed
  2018-10-26 10:24 [dts] [PATCH V2] tests/shutdown_api: add sagepond support speed to change_linkspeed wenjieli
@ 2018-10-30 15:22 ` Lijuan Tu
  0 siblings, 0 replies; 2+ messages in thread
From: Lijuan Tu @ 2018-10-30 15:22 UTC (permalink / raw)
  To: wenjieli, dts

Applied, thanks


On 2018年10月26日 18:24, wenjieli wrote:
> Sagepond nic only support 1000baseT and 10000baseT, but the peer nic
> might support more speeds, sagepond could be set to unsupport mode; to
> avoid such issue, add sagepond support speed to change_linkspeed case.
>
> Signed-off-by: wenjieli <wenjiex.a.li@intel.com>
> ---
>   tests/TestSuite_shutdown_api.py | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
> index 1282cf7..ba4c6cb 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -312,6 +312,9 @@ class TestShutdownApi(TestCase):
>               elif self.nic in ["fortville_eagle"]:
>                   if config[0] != '10000':
>                       continue
> +            elif self.nic in ["sagepond"]:
> +                if config[0] != '1000' and '10000':
> +                    continue
>               self.dut.send_expect("port stop all", "testpmd> ", 100)
>               for port in self.ports:
>                   self.dut.send_expect("port config %d speed %s duplex %s" % (port,

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-30  6:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-26 10:24 [dts] [PATCH V2] tests/shutdown_api: add sagepond support speed to change_linkspeed wenjieli
2018-10-30 15:22 ` Lijuan Tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).