test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1 1/2] tests/vf mackfilter: add dpdk pf test scenorio
@ 2018-11-23  8:49 zhao,meijuan
  2018-11-23  8:49 ` [dts] [PATCH V1 2/2] test_plans/vf pacfilter: " zhao,meijuan
  2018-11-28  3:25 ` [dts] [PATCH V1 1/2] tests/vf mackfilter: " Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: zhao,meijuan @ 2018-11-23  8:49 UTC (permalink / raw)
  To: dts; +Cc: zhao,meijuan

add dpdk pf test scenorio

Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
 tests/TestSuite_vf_macfilter.py | 46 ++++++++++++++++++++++++++-------
 1 file changed, 36 insertions(+), 10 deletions(-)

diff --git a/tests/TestSuite_vf_macfilter.py b/tests/TestSuite_vf_macfilter.py
index f0de169..c255d01 100644
--- a/tests/TestSuite_vf_macfilter.py
+++ b/tests/TestSuite_vf_macfilter.py
@@ -13,13 +13,15 @@ VM_CORES_MASK = 'all'
 class TestVfMacFilter(TestCase):
 
     supported_vf_driver = ['pci-stub', 'vfio-pci']
+    vf0_wrongmac = "00:11:22:33:48:55"
+    vf0_setmac = "00:11:22:33:44:55"
 
     def set_up_all(self):
         self.dut_ports = self.dut.get_ports(self.nic)
         self.verify(len(self.dut_ports) > 1, "Insufficient ports")
         self.vm0 = None
         self.pf0_vf0_mac = "00:12:34:56:78:01"
-        self.iplinkset = True
+        self.iplinkset = False
 
         # set vf assign method and vf driver
         self.vf_driver = self.get_suite_cfg()['vf_driver']
@@ -124,15 +126,18 @@ class TestVfMacFilter(TestCase):
 ###### send the packets with wrong MAC address to VF, check if the VF will not RX the packets.
  
     def test_kernel_2pf_2vf_1vm_iplink_macfilter(self):
-
+        self.iplinkset = True
         self.setup_2pf_2vf_1vm_env(driver='')
+        self.result_verify_iplink()
 
+    def result_verify_iplink(self):
+        if self.iplinkset == False:
+            self.host_testpmd.execute_cmd('set vf mac addr 0 0 %s' % self.pf0_vf0_mac)
         self.vm0_dut_ports = self.vm_dut_0.get_ports('any')
         self.vm0_testpmd = PmdOutput(self.vm_dut_0)
         self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
         # Get VF's MAC
         pmd_vf0_mac = self.vm0_testpmd.get_port_mac(0)
-        vf0_wrongmac = "00:11:22:33:48:55"
         self.vm0_testpmd.execute_cmd('set promisc all off')
         self.vm0_testpmd.execute_cmd('set fwd mac')
         self.vm0_testpmd.execute_cmd('start')
@@ -147,18 +152,19 @@ class TestVfMacFilter(TestCase):
         src_mac = self.tester.get_mac(tx_port)
         pkt_param=[("ether", {'dst': dst_mac, 'src': src_mac})]
         
-        print "\nfirst send packets to the kernel PF set MAC, expected result is RX packets=TX packets\n"
+        print "\nfirst send packets to the PF set MAC, expected result is RX packets=TX packets\n"
         result1 = self.tester.check_random_pkts(tgen_ports, pktnum=100, allow_miss=False, params=pkt_param)
 	print "\nshow port stats in testpmd for double check: \n", self.vm0_testpmd.execute_cmd('show port stats all')   
         self.verify(result1 != False, "VF0 failed to forward packets to VF1")
         
         print "\nSecondly, negative test, send packets to a wrong MAC, expected result is RX packets=0\n"
-        dst_mac = vf0_wrongmac
+        dst_mac = self.vf0_wrongmac
         pkt_param=[("ether", {'dst': dst_mac, 'src': src_mac})]
         result2 = self.tester.check_random_pkts(tgen_ports, pktnum=100, allow_miss=False, params=pkt_param)
         print "\nshow port stats in testpmd for double check: \n", self.vm0_testpmd.execute_cmd('show port stats all')
         self.verify(result2 != True, "VF0 failed to forward packets to VF1")
 
+
 #######2. test case for kernel pf and dpdk vf 2pf_2vf_1vm MAC filter scenario.
 ####### kernel pf will not set MAC address and the VF will get a random generated MAC
 ####### in the testpmd in VM, and then add VF mac address in the testpmd,for example, VF_MAC1
@@ -170,17 +176,37 @@ class TestVfMacFilter(TestCase):
 
         self.iplinkset = False
         self.setup_2pf_2vf_1vm_env(driver='')
+        self.send_packet_and_verify()
+
+#######3. test case for dpdk pf and dpdk vf 2pf_2vf_1vm MAC filter scenario.
+####### kernel pf will not set MAC address and the VF will get a random generated MAC
+####### in the testpmd in VM, and then add VF mac address in the testpmd,for example, VF_MAC1
+####### then send packets to the VF with the random generated MAC and the new added VF_MAC1
+####### and the expected result is that all packets can be RXed and TXed. What's more, send
+####### packets with a wrong MAC address to the VF will not received by the VF.
+    def test_dpdk_2pf_2vf_1vm_mac_add_filter(self):
+        self.iplinkset = False
+        self.setup_2pf_2vf_1vm_env(driver='igb_uio')
+        self.send_packet_and_verify()
+
+######4. test case for dpdk pf and dpdk vf 2pf_2vf_1vm MAC filter scenario
+###### dpdk pf will first run 'set vf mac addr 0 0 xx:xx:xx:xx:xx:xx, then
+###### in the vm, send packets with this MAC to VF, check if the MAC filter works. Also
+###### send the packets with wrong MAC address to VF, check if the VF will not RX the packets.
+    def test_dpdk_2pf_2vf_1vm_iplink_macfilter(self):
+        self.iplinkset = False
+        self.setup_2pf_2vf_1vm_env(driver='igb_uio')
+        self.result_verify_iplink()
 
+    def send_packet_and_verify(self):
         self.vm0_dut_ports = self.vm_dut_0.get_ports('any')
         self.vm0_testpmd = PmdOutput(self.vm_dut_0)
         self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
         
         # Get VF0 port MAC address
         pmd_vf0_mac = self.vm0_testpmd.get_port_mac(0)
-        vf0_setmac = "00:11:22:33:44:55"
-        vf0_wrongmac = "00:11:22:33:48:55"
         self.vm0_testpmd.execute_cmd('set promisc all off')
-        ret = self.vm0_testpmd.execute_cmd('mac_addr add 0 %s' %vf0_setmac)
+        ret = self.vm0_testpmd.execute_cmd('mac_addr add 0 %s' %self.vf0_setmac)
         # check the operation is supported or not.
         print ret 
  
@@ -203,14 +229,14 @@ class TestVfMacFilter(TestCase):
         self.verify(result1 != False, "VF0 failed to forward packets to VF1")
         
         print "\nsecondly, send packets to the new added MAC, expected result is RX packets=TX packets\n"
-        dst_mac = vf0_setmac
+        dst_mac = self.vf0_setmac
         pkt_param=[("ether", {'dst': dst_mac, 'src': src_mac})]
         result2 = self.tester.check_random_pkts(tgen_ports, pktnum=100, allow_miss=False, params=pkt_param)
         print "\nshow port stats in testpmd for double check: \n", self.vm0_testpmd.execute_cmd('show port stats all')
         self.verify(result2 != False, "VF0 failed to forward packets to VF1")
 
         print "\nThirdly, negative test, send packets to a wrong MAC, expected result is RX packets=0\n"
-        dst_mac = vf0_wrongmac
+        dst_mac = self.vf0_wrongmac
         pkt_param=[("ether", {'dst': dst_mac, 'src': src_mac})]
         result3 = self.tester.check_random_pkts(tgen_ports, pktnum=100, allow_miss=False, params=pkt_param)
         print "\nshow port stats in testpmd for double check: \n", self.vm0_testpmd.execute_cmd('show port stats all')
-- 
2.17.2

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1 2/2] test_plans/vf pacfilter: add dpdk pf test scenorio
  2018-11-23  8:49 [dts] [PATCH V1 1/2] tests/vf mackfilter: add dpdk pf test scenorio zhao,meijuan
@ 2018-11-23  8:49 ` zhao,meijuan
  2018-11-28  3:25 ` [dts] [PATCH V1 1/2] tests/vf mackfilter: " Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: zhao,meijuan @ 2018-11-23  8:49 UTC (permalink / raw)
  To: dts; +Cc: zhao,meijuan

add dpdk pf test scenorio

Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
 test_plans/vf_macfilter_test_plan.rst | 190 ++++++++++++++++++++++++--
 1 file changed, 182 insertions(+), 8 deletions(-)

diff --git a/test_plans/vf_macfilter_test_plan.rst b/test_plans/vf_macfilter_test_plan.rst
index 221c05e..715c66d 100644
--- a/test_plans/vf_macfilter_test_plan.rst
+++ b/test_plans/vf_macfilter_test_plan.rst
@@ -39,7 +39,7 @@ Test Case 1: test_kernel_2pf_2vf_1vm_iplink_macfilter
 
 1. Get the pci device id of DUT, for example::
 
-      ./dpdk_nic_bind.py --st
+      ./usertools/dpdk-devbind.py -s
 
       0000:81:00.0 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f0 drv=i40e unused=
       0000:81:00.1 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f1 drv=i40e unused=
@@ -49,7 +49,7 @@ Test Case 1: test_kernel_2pf_2vf_1vm_iplink_macfilter
       echo 1 > /sys/bus/pci/devices/0000\:81\:00.0/sriov_numvfs
       echo 1 > /sys/bus/pci/devices/0000\:81\:00.1/sriov_numvfs
 
-      ./dpdk_nic_bind.py --st
+      ./usertools/dpdk-devbind.py -s
       0000:81:00.0 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f0 drv=i40e unused=
       0000:81:00.1 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f1 drv=i40e unused=
       0000:81:02.0 'XL710/X710 Virtual Function' unused=
@@ -76,7 +76,7 @@ Test Case 1: test_kernel_2pf_2vf_1vm_iplink_macfilter
       virsh nodedev-detach pci_0000_81_02_0;
       virsh nodedev-detach pci_0000_81_0a_0;
 
-      ./dpdk_nic_bind.py --st
+      ./usertools/dpdk-devbind.py -s
 
       0000:81:00.0 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f0 drv=i40e unused=
       0000:81:00.1 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f1 drv=i40e unused=
@@ -96,7 +96,7 @@ Test Case 1: test_kernel_2pf_2vf_1vm_iplink_macfilter
    bind them to igb_uio driver, and then start testpmd, enable CRC strip,
    disable promisc mode,set it in mac forward mode::
 
-      ./tools/dpdk_nic_bind.py --bind=igb_uio 00:06.0 00:07.0
+      ./usertools/dpdk-devbind.py --bind=igb_uio 00:06.0 00:07.0
       ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x0f -n 4 -w 00:06.0 -w 00:07.0 -- -i --portmask=0x3 --tx-offloads=0x8fff
 
       testpmd> port stop all
@@ -119,7 +119,7 @@ Test Case 2: test_kernel_2pf_2vf_1vm_mac_add_filter
 
 1. Get the pci device id of DUT, for example::
 
-      ./dpdk_nic_bind.py --st
+      ./usertools/dpdk-devbind.py -s
 
       0000:81:00.0 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f0 drv=i40e unused=
       0000:81:00.1 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f1 drv=i40e unused=
@@ -129,7 +129,7 @@ Test Case 2: test_kernel_2pf_2vf_1vm_mac_add_filter
       echo 1 > /sys/bus/pci/devices/0000\:81\:00.0/sriov_numvfs
       echo 1 > /sys/bus/pci/devices/0000\:81\:00.1/sriov_numvfs
 
-      ./dpdk_nic_bind.py --st
+      ./usertools/dpdk-devbind.py -s
       0000:81:00.0 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f0 drv=i40e unused=
       0000:81:00.1 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f1 drv=i40e unused=
       0000:81:02.0 'XL710/X710 Virtual Function' unused=
@@ -154,7 +154,7 @@ Test Case 2: test_kernel_2pf_2vf_1vm_mac_add_filter
       virsh nodedev-detach pci_0000_81_02_0;
       virsh nodedev-detach pci_0000_81_0a_0;
 
-      ./dpdk_nic_bind.py --st
+      ./usertools/dpdk-devbind.py -s
 
       0000:81:00.0 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f0 drv=i40e unused=
       0000:81:00.1 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f1 drv=i40e unused=
@@ -174,7 +174,7 @@ Test Case 2: test_kernel_2pf_2vf_1vm_mac_add_filter
    bind them to igb_uio driver, and then start testpmd, enable CRC strip on
    VF, disable promisc mode, add a new MAC to VF0 and then start::
 
-      ./tools/dpdk_nic_bind.py --bind=igb_uio 00:06.0 00:07.0
+      ./usertools/dpdk-devbind.py --bind=igb_uio 00:06.0 00:07.0
       ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x0f -n 4 -w 00:06.0 -w 00:07.0 -- -i --portmask=0x3 --tx-offloads=0x8fff
 
       testpmd> port stop all
@@ -199,3 +199,177 @@ Test Case 2: test_kernel_2pf_2vf_1vm_mac_add_filter
 8. Use scapy to send 100 random packets with a wrong MAC to VF0, verify the
    packets can't be received by one VF and can be forward to another VF
    correctly.
+
+Test Case 3: test_dpdk_2pf_2vf_1vm_mac_add_filter
+===================================================
+
+1. Get the pci device id of DUT, bind them to igb_uio,for example::
+
+      ./usertools/dpdk-devbind.py -s
+
+      0000:81:00.0 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f0 drv=i40e unused=
+      0000:81:00.1 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f1 drv=i40e unused=
+      ./usertools/dpdk-devbind.py --bind=igb_uio 0000:81:00.0 0000:81:00.1
+      
+
+2. Create 2 VFs from 2 PFs, and don't set the VF MAC address at PF0::
+
+      echo 1 > /sys/bus/pci/devices/0000\:81\:00.0/max_vfs
+      echo 1 > /sys/bus/pci/devices/0000\:81\:00.1/max_vfs
+
+      ./usertools/dpdk-devbind.py -s
+      0000:81:00.0 'Ethernet Controller X710 for 10GbE SFP+'  drv=igb_uio unused=i40e
+      0000:81:00.1 'Ethernet Controller X710 for 10GbE SFP+'  drv=igb_uio unused=i40e
+      0000:81:02.0 'XL710/X710 Virtual Function' unused=
+      0000:81:0a.0 'XL710/X710 Virtual Function' unused=
+
+3. Start testpmd::
+
+      ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x6 -n 4 -b 0000:81:02.0 -b 0000:81:0a.0 -- -i
+
+4. Detach VFs from the host, bind them to pci-stub driver::
+
+      /sbin/modprobe pci-stub
+
+      using `lspci -nn|grep -i ethernet` to get VF device id, for example "8086 154c",
+
+      echo "8086 154c" > /sys/bus/pci/drivers/pci-stub/new_id
+      echo 0000:81:02.0 > /sys/bus/pci/devices/0000:08:02.0/driver/unbind
+      echo 0000:81:02.0 > /sys/bus/pci/drivers/pci-stub/bind
+
+      echo "8086 154c" > /sys/bus/pci/drivers/pci-stub/new_id
+      echo 0000:81:0a.0 > /sys/bus/pci/devices/0000:08:0a.0/driver/unbind
+      echo 0000:81:0a.0 > /sys/bus/pci/drivers/pci-stub/bind
+
+   or using the following more easy way::
+
+      virsh nodedev-detach pci_0000_81_02_0;
+      virsh nodedev-detach pci_0000_81_0a_0;
+
+      ./dpdk_nic_bind.py --st
+
+      0000:81:00.0 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f0 drv=i40e unused=
+      0000:81:00.1 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f1 drv=i40e unused=
+      0000:81:02.0 'XL710/X710 Virtual Function' if= drv=pci-stub unused=
+      0000:81:0a.0 'XL710/X710 Virtual Function' if= drv=pci-stub unused=
+
+   it can be seen that VFs 81:02.0 & 81:0a.0 's driver is pci-stub.
+5. Passthrough VFs 81:02.0 & 81:0a.0 to vm0, and start vm0::
+
+      /usr/bin/qemu-system-x86_64  -name vm0 -enable-kvm \
+      -cpu host -smp 4 -m 2048 -drive file=/home/image/sriov-fc20-1.img -vnc :1 \
+      -device pci-assign,host=81:02.0,id=pt_0 \
+      -device pci-assign,host=81:0a.0,id=pt_1
+
+6. login vm0, got VFs pci device id in vm0, assume they are 00:06.0 & 00:07.0,
+   bind them to igb_uio driver, and then start testpmd, enable CRC strip on
+   VF, disable promisc mode, add a new MAC to VF0 and then start::
+
+      ./tools/dpdk_nic_bind.py --bind=igb_uio 00:06.0 00:07.0
+      ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x0f -n 4 -w 00:06.0 -w 00:07.0 -- -i --portmask=0x3 --tx-offloads=0x8fff
+
+      testpmd> port stop all
+      testpmd> port config all crc-strip on
+      testpmd> port start all
+      testpmd> set promisc all off
+      testpmd> mac_addr add 0 00:11:22:33:44:55
+      testpmd> set fwd mac
+      testpmd> start
+
+   Note: In Jan, 2016, i40e doesn't support mac_addr add operation, so the
+   case will be failed for FVL/Fort park NICs.
+
+7. Use scapy to send 100 random packets with current VF0's MAC, verify the
+   packets can be received by one VF and can be forward to another VF
+   correctly.
+
+8. Use scapy to send 100 random packets with new added VF0's MAC, verify the
+   packets can be received by one VF and can be forward to another VF
+   correctly.
+
+9. Use scapy to send 100 random packets with a wrong MAC to VF0, verify the
+   packets can't be received by one VF and can be forward to another VF
+   correctly.
+Test Case 4: test_dpdk_2pf_2vf_1vm_iplink_macfilter
+===================================================
+
+1. Get the pci device id of DUT, bind them to igb_uio,for example::
+
+      ./usertools/dpdk-devbind.py -s
+
+      0000:81:00.0 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f0 drv=i40e unused=
+      0000:81:00.1 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f1 drv=i40e unused=
+      ./usertools/dpdk-devbind.py --bind=igb_uio 0000:81:00.0 0000:81:00.1
+
+
+2. Create 2 VFs from 2 PFs, and set the VF MAC address at PF0::
+
+      echo 1 > /sys/bus/pci/devices/0000\:81\:00.0/max_vfs
+      echo 1 > /sys/bus/pci/devices/0000\:81\:00.1/max_vfs
+
+      ./usertools/dpdk-devbind.py -s
+      0000:81:00.0 'Ethernet Controller X710 for 10GbE SFP+'  drv=igb_uio unused=i40e
+      0000:81:00.1 'Ethernet Controller X710 for 10GbE SFP+'  drv=igb_uio unused=i40e
+      0000:81:02.0 'XL710/X710 Virtual Function' unused=
+      0000:81:0a.0 'XL710/X710 Virtual Function' unused=
+
+3. Start testpmd::
+
+      ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x6 -n 4 -b 0000:81:02.0 -b 0000:81:0a.0 -- -i
+      testpmd>set vf mac addr 0 0 00:11:22:33:44:55
+
+4. Detach VFs from the host, bind them to pci-stub driver::
+
+      /sbin/modprobe pci-stub
+
+      using `lspci -nn|grep -i ethernet` to get VF device id, for example "8086 154c",
+
+      echo "8086 154c" > /sys/bus/pci/drivers/pci-stub/new_id
+      echo 0000:81:02.0 > /sys/bus/pci/devices/0000:08:02.0/driver/unbind
+      echo 0000:81:02.0 > /sys/bus/pci/drivers/pci-stub/bind
+
+      echo "8086 154c" > /sys/bus/pci/drivers/pci-stub/new_id
+      echo 0000:81:0a.0 > /sys/bus/pci/devices/0000:08:0a.0/driver/unbind
+      echo 0000:81:0a.0 > /sys/bus/pci/drivers/pci-stub/bind
+
+   or using the following more easy way::
+
+      virsh nodedev-detach pci_0000_81_02_0;
+      virsh nodedev-detach pci_0000_81_0a_0;
+
+      ./dpdk_nic_bind.py --st
+
+      0000:81:00.0 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f0 drv=i40e unused=
+      0000:81:00.1 'Ethernet Controller X710 for 10GbE SFP+' if=ens259f1 drv=i40e unused=
+      0000:81:02.0 'XL710/X710 Virtual Function' if= drv=pci-stub unused=
+      0000:81:0a.0 'XL710/X710 Virtual Function' if= drv=pci-stub unused=
+
+   it can be seen that VFs 81:02.0 & 81:0a.0 's driver is pci-stub.
+5. Passthrough VFs 81:02.0 & 81:0a.0 to vm0, and start vm0::
+
+      /usr/bin/qemu-system-x86_64  -name vm0 -enable-kvm \
+      -cpu host -smp 4 -m 2048 -drive file=/home/image/sriov-fc20-1.img -vnc :1 \
+      -device pci-assign,host=81:02.0,id=pt_0 \
+      -device pci-assign,host=81:0a.0,id=pt_1
+
+6. Login vm0, got VFs pci device id in vm0, assume they are 00:06.0 & 00:07.0,
+   bind them to igb_uio driver, and then start testpmd, enable CRC strip,
+   disable promisc mode,set it in mac forward mode::
+
+      ./tools/dpdk_nic_bind.py --bind=igb_uio 00:06.0 00:07.0
+      ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x0f -n 4 -w 00:06.0 -w 00:07.0 -- -i --portmask=0x3 --tx-offloads=0x8fff
+
+      testpmd> port stop all
+      testpmd> port config all crc-strip on
+      testpmd> port start all
+      testpmd> set promisc all off
+      testpmd> set fwd mac
+      testpmd> start
+
+7. Use scapy to send 100 random packets with ip link set MAC to VF, verify the
+   packets can be received by one VF and can be forward to another VF
+   correctly.
+
+8. Also use scapy to send 100 random packets with a wrong MAC to VF, verify
+   the packets can't be received by one VF and can be forward to another VF
+   correctly.
-- 
2.17.2

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1 1/2] tests/vf mackfilter: add dpdk pf test scenorio
  2018-11-23  8:49 [dts] [PATCH V1 1/2] tests/vf mackfilter: add dpdk pf test scenorio zhao,meijuan
  2018-11-23  8:49 ` [dts] [PATCH V1 2/2] test_plans/vf pacfilter: " zhao,meijuan
@ 2018-11-28  3:25 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2018-11-28  3:25 UTC (permalink / raw)
  To: Zhao, MeijuanX, dts; +Cc: Zhao, MeijuanX

Hi meijun,
Good to see a new function: result_verify_iplink.
I found self.iplinkset only used in result_verify_iplink, so It's better to take iplinkset as a parameter of iplinkset.

For instance:

> +    def result_verify_iplink(self, iplinkset=False):
> +        if iplinkset == False:
> +            self.host_testpmd.execute_cmd('set vf mac addr 0 0 %s' %
> + self.pf0_vf0_mac)

>      def test_kernel_2pf_2vf_1vm_iplink_macfilter(self):
>          self.setup_2pf_2vf_1vm_env(driver='')
> +        self.result_verify_iplink(iplinkset=True)

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan
> Sent: Friday, November 23, 2018 4:50 PM
> To: dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: [dts] [PATCH V1 1/2] tests/vf mackfilter: add dpdk pf test scenorio
> 
> add dpdk pf test scenorio
> 
> Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> ---
>  tests/TestSuite_vf_macfilter.py | 46 ++++++++++++++++++++++++++-------
>  1 file changed, 36 insertions(+), 10 deletions(-)
> 
> diff --git a/tests/TestSuite_vf_macfilter.py b/tests/TestSuite_vf_macfilter.py
> index f0de169..c255d01 100644
> --- a/tests/TestSuite_vf_macfilter.py
> +++ b/tests/TestSuite_vf_macfilter.py
> @@ -13,13 +13,15 @@ VM_CORES_MASK = 'all'
>  class TestVfMacFilter(TestCase):
> 
>      supported_vf_driver = ['pci-stub', 'vfio-pci']
> +    vf0_wrongmac = "00:11:22:33:48:55"
> +    vf0_setmac = "00:11:22:33:44:55"
> 
>      def set_up_all(self):
>          self.dut_ports = self.dut.get_ports(self.nic)
>          self.verify(len(self.dut_ports) > 1, "Insufficient ports")
>          self.vm0 = None
>          self.pf0_vf0_mac = "00:12:34:56:78:01"
> -        self.iplinkset = True
> +        self.iplinkset = False
> 
>          # set vf assign method and vf driver
>          self.vf_driver = self.get_suite_cfg()['vf_driver'] @@ -124,15
> +126,18 @@ class TestVfMacFilter(TestCase):
>  ###### send the packets with wrong MAC address to VF, check if the VF will
> not RX the packets.
> 
>      def test_kernel_2pf_2vf_1vm_iplink_macfilter(self):
> -
> +        self.iplinkset = True
>          self.setup_2pf_2vf_1vm_env(driver='')
> +        self.result_verify_iplink()
> 
> +    def result_verify_iplink(self):
> +        if self.iplinkset == False:
> +            self.host_testpmd.execute_cmd('set vf mac addr 0 0 %s' %
> + self.pf0_vf0_mac)
>          self.vm0_dut_ports = self.vm_dut_0.get_ports('any')
>          self.vm0_testpmd = PmdOutput(self.vm_dut_0)
>          self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
>          # Get VF's MAC
>          pmd_vf0_mac = self.vm0_testpmd.get_port_mac(0)
> -        vf0_wrongmac = "00:11:22:33:48:55"
>          self.vm0_testpmd.execute_cmd('set promisc all off')
>          self.vm0_testpmd.execute_cmd('set fwd mac')
>          self.vm0_testpmd.execute_cmd('start')
> @@ -147,18 +152,19 @@ class TestVfMacFilter(TestCase):
>          src_mac = self.tester.get_mac(tx_port)
>          pkt_param=[("ether", {'dst': dst_mac, 'src': src_mac})]
> 
> -        print "\nfirst send packets to the kernel PF set MAC, expected
> result is RX packets=TX packets\n"
> +        print "\nfirst send packets to the PF set MAC, expected result is
> RX packets=TX packets\n"
>          result1 = self.tester.check_random_pkts(tgen_ports, pktnum=100,
> allow_miss=False, params=pkt_param)
>  	print "\nshow port stats in testpmd for double check: \n",
> self.vm0_testpmd.execute_cmd('show port stats all')
>          self.verify(result1 != False, "VF0 failed to forward packets to
> VF1")
> 
>          print "\nSecondly, negative test, send packets to a wrong MAC,
> expected result is RX packets=0\n"
> -        dst_mac = vf0_wrongmac
> +        dst_mac = self.vf0_wrongmac
>          pkt_param=[("ether", {'dst': dst_mac, 'src': src_mac})]
>          result2 = self.tester.check_random_pkts(tgen_ports, pktnum=100,
> allow_miss=False, params=pkt_param)
>          print "\nshow port stats in testpmd for double check: \n",
> self.vm0_testpmd.execute_cmd('show port stats all')
>          self.verify(result2 != True, "VF0 failed to forward packets to VF1")
> 
> +
>  #######2. test case for kernel pf and dpdk vf 2pf_2vf_1vm MAC filter
> scenario.
>  ####### kernel pf will not set MAC address and the VF will get a random
> generated MAC  ####### in the testpmd in VM, and then add VF mac
> address in the testpmd,for example, VF_MAC1 @@ -170,17 +176,37 @@
> class TestVfMacFilter(TestCase):
> 
>          self.iplinkset = False
>          self.setup_2pf_2vf_1vm_env(driver='')
> +        self.send_packet_and_verify()
> +
> +#######3. test case for dpdk pf and dpdk vf 2pf_2vf_1vm MAC filter
> scenario.
> +####### kernel pf will not set MAC address and the VF will get a random
> +generated MAC ####### in the testpmd in VM, and then add VF mac
> address
> +in the testpmd,for example, VF_MAC1 ####### then send packets to the VF
> +with the random generated MAC and the new added VF_MAC1 #######
> and the
> +expected result is that all packets can be RXed and TXed. What's more, send
> ####### packets with a wrong MAC address to the VF will not received by
> the VF.
> +    def test_dpdk_2pf_2vf_1vm_mac_add_filter(self):
> +        self.iplinkset = False
> +        self.setup_2pf_2vf_1vm_env(driver='igb_uio')
> +        self.send_packet_and_verify()
> +
> +######4. test case for dpdk pf and dpdk vf 2pf_2vf_1vm MAC filter
> +scenario ###### dpdk pf will first run 'set vf mac addr 0 0
> +xx:xx:xx:xx:xx:xx, then ###### in the vm, send packets with this MAC to
> +VF, check if the MAC filter works. Also ###### send the packets with wrong
> MAC address to VF, check if the VF will not RX the packets.
> +    def test_dpdk_2pf_2vf_1vm_iplink_macfilter(self):
> +        self.iplinkset = False
> +        self.setup_2pf_2vf_1vm_env(driver='igb_uio')
> +        self.result_verify_iplink()
> 
> +    def send_packet_and_verify(self):
>          self.vm0_dut_ports = self.vm_dut_0.get_ports('any')
>          self.vm0_testpmd = PmdOutput(self.vm_dut_0)
>          self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
> 
>          # Get VF0 port MAC address
>          pmd_vf0_mac = self.vm0_testpmd.get_port_mac(0)
> -        vf0_setmac = "00:11:22:33:44:55"
> -        vf0_wrongmac = "00:11:22:33:48:55"
>          self.vm0_testpmd.execute_cmd('set promisc all off')
> -        ret = self.vm0_testpmd.execute_cmd('mac_addr add
> 0 %s' %vf0_setmac)
> +        ret = self.vm0_testpmd.execute_cmd('mac_addr add 0 %s'
> + %self.vf0_setmac)
>          # check the operation is supported or not.
>          print ret
> 
> @@ -203,14 +229,14 @@ class TestVfMacFilter(TestCase):
>          self.verify(result1 != False, "VF0 failed to forward packets to
> VF1")
> 
>          print "\nsecondly, send packets to the new added MAC, expected
> result is RX packets=TX packets\n"
> -        dst_mac = vf0_setmac
> +        dst_mac = self.vf0_setmac
>          pkt_param=[("ether", {'dst': dst_mac, 'src': src_mac})]
>          result2 = self.tester.check_random_pkts(tgen_ports, pktnum=100,
> allow_miss=False, params=pkt_param)
>          print "\nshow port stats in testpmd for double check: \n",
> self.vm0_testpmd.execute_cmd('show port stats all')
>          self.verify(result2 != False, "VF0 failed to forward packets to
> VF1")
> 
>          print "\nThirdly, negative test, send packets to a wrong MAC,
> expected result is RX packets=0\n"
> -        dst_mac = vf0_wrongmac
> +        dst_mac = self.vf0_wrongmac
>          pkt_param=[("ether", {'dst': dst_mac, 'src': src_mac})]
>          result3 = self.tester.check_random_pkts(tgen_ports, pktnum=100,
> allow_miss=False, params=pkt_param)
>          print "\nshow port stats in testpmd for double check: \n",
> self.vm0_testpmd.execute_cmd('show port stats all')
> --
> 2.17.2

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-28  3:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-23  8:49 [dts] [PATCH V1 1/2] tests/vf mackfilter: add dpdk pf test scenorio zhao,meijuan
2018-11-23  8:49 ` [dts] [PATCH V1 2/2] test_plans/vf pacfilter: " zhao,meijuan
2018-11-28  3:25 ` [dts] [PATCH V1 1/2] tests/vf mackfilter: " Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).