* [dts] [PATCH V1] tests/vf mackfilter: fix syntax error
@ 2018-11-30 4:54 zhao,meijuan
2018-12-03 12:00 ` Lijuan Tu
0 siblings, 1 reply; 2+ messages in thread
From: zhao,meijuan @ 2018-11-30 4:54 UTC (permalink / raw)
To: dts; +Cc: zhao,meijuan
Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
tests/TestSuite_vf_macfilter.py | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/TestSuite_vf_macfilter.py b/tests/TestSuite_vf_macfilter.py
index 9e6db42..12a08e8 100644
--- a/tests/TestSuite_vf_macfilter.py
+++ b/tests/TestSuite_vf_macfilter.py
@@ -37,7 +37,7 @@ class TestVfMacFilter(TestCase):
self.setup_2pf_2vf_1vm_env_flag = 0
- def setup_2pf_2vf_1vm_env(self, driver='default',set_mac):
+ def setup_2pf_2vf_1vm_env(self,set_mac,driver='default'):
self.used_dut_port_0 = self.dut_ports[0]
self.dut.generate_sriov_vfs_by_port(self.used_dut_port_0, 1, driver=driver)
@@ -128,7 +128,7 @@ class TestVfMacFilter(TestCase):
if the MAC filter works. Also send the packets with wrong MAC
address to VF, check if the VF will not RX the packets.
"""
- self.setup_2pf_2vf_1vm_env(driver='',True)
+ self.setup_2pf_2vf_1vm_env(True,driver='')
self.result_verify_iplink(True)
def result_verify_iplink(self,set_mac):
@@ -177,7 +177,7 @@ class TestVfMacFilter(TestCase):
What's more, send packets with a wrong MAC address to the VF will
not received by the VF.
"""
- self.setup_2pf_2vf_1vm_env(driver='',False)
+ self.setup_2pf_2vf_1vm_env(False,driver='')
self.send_packet_and_verify()
def test_dpdk_2pf_2vf_1vm_mac_add_filter(self):
@@ -191,7 +191,7 @@ class TestVfMacFilter(TestCase):
What's more, send packets with a wrong MAC address to the VF will
not received by the VF.
"""
- self.setup_2pf_2vf_1vm_env(driver='igb_uio',False)
+ self.setup_2pf_2vf_1vm_env(False,driver='igb_uio')
self.send_packet_and_verify()
def test_dpdk_2pf_2vf_1vm_iplink_macfilter(self):
@@ -203,7 +203,7 @@ class TestVfMacFilter(TestCase):
not RX the packets works. Also send the packets with wrong MAC
address to VF, check if the VF will not RX the packets.
"""
- self.setup_2pf_2vf_1vm_env(driver='igb_uio',False)
+ self.setup_2pf_2vf_1vm_env(False,driver='igb_uio')
self.result_verify_iplink(False)
def send_packet_and_verify(self):
--
2.17.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dts] [PATCH V1] tests/vf mackfilter: fix syntax error
2018-11-30 4:54 [dts] [PATCH V1] tests/vf mackfilter: fix syntax error zhao,meijuan
@ 2018-12-03 12:00 ` Lijuan Tu
0 siblings, 0 replies; 2+ messages in thread
From: Lijuan Tu @ 2018-12-03 12:00 UTC (permalink / raw)
To: zhao,meijuan, dts
Applied, thanks, appreciate if you could be more careful.
On 2018年11月30日 12:54, zhao,meijuan wrote:
> Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> ---
> tests/TestSuite_vf_macfilter.py | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tests/TestSuite_vf_macfilter.py b/tests/TestSuite_vf_macfilter.py
> index 9e6db42..12a08e8 100644
> --- a/tests/TestSuite_vf_macfilter.py
> +++ b/tests/TestSuite_vf_macfilter.py
> @@ -37,7 +37,7 @@ class TestVfMacFilter(TestCase):
>
> self.setup_2pf_2vf_1vm_env_flag = 0
>
> - def setup_2pf_2vf_1vm_env(self, driver='default',set_mac):
> + def setup_2pf_2vf_1vm_env(self,set_mac,driver='default'):
>
> self.used_dut_port_0 = self.dut_ports[0]
> self.dut.generate_sriov_vfs_by_port(self.used_dut_port_0, 1, driver=driver)
> @@ -128,7 +128,7 @@ class TestVfMacFilter(TestCase):
> if the MAC filter works. Also send the packets with wrong MAC
> address to VF, check if the VF will not RX the packets.
> """
> - self.setup_2pf_2vf_1vm_env(driver='',True)
> + self.setup_2pf_2vf_1vm_env(True,driver='')
> self.result_verify_iplink(True)
>
> def result_verify_iplink(self,set_mac):
> @@ -177,7 +177,7 @@ class TestVfMacFilter(TestCase):
> What's more, send packets with a wrong MAC address to the VF will
> not received by the VF.
> """
> - self.setup_2pf_2vf_1vm_env(driver='',False)
> + self.setup_2pf_2vf_1vm_env(False,driver='')
> self.send_packet_and_verify()
>
> def test_dpdk_2pf_2vf_1vm_mac_add_filter(self):
> @@ -191,7 +191,7 @@ class TestVfMacFilter(TestCase):
> What's more, send packets with a wrong MAC address to the VF will
> not received by the VF.
> """
> - self.setup_2pf_2vf_1vm_env(driver='igb_uio',False)
> + self.setup_2pf_2vf_1vm_env(False,driver='igb_uio')
> self.send_packet_and_verify()
>
> def test_dpdk_2pf_2vf_1vm_iplink_macfilter(self):
> @@ -203,7 +203,7 @@ class TestVfMacFilter(TestCase):
> not RX the packets works. Also send the packets with wrong MAC
> address to VF, check if the VF will not RX the packets.
> """
> - self.setup_2pf_2vf_1vm_env(driver='igb_uio',False)
> + self.setup_2pf_2vf_1vm_env(False,driver='igb_uio')
> self.result_verify_iplink(False)
>
> def send_packet_and_verify(self):
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-03 3:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-30 4:54 [dts] [PATCH V1] tests/vf mackfilter: fix syntax error zhao,meijuan
2018-12-03 12:00 ` Lijuan Tu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).