* [dts] [PATCH V2] tests/vf kernel : fix vf wrong action
@ 2018-12-21 8:25 zhao,meijuan
2018-12-29 3:06 ` Zhu, WenhuiX
2018-12-29 15:31 ` Lijuan Tu
0 siblings, 2 replies; 3+ messages in thread
From: zhao,meijuan @ 2018-12-21 8:25 UTC (permalink / raw)
To: dts; +Cc: zhao,meijuan
for fortville,tcpdump need add -p parameter to disable promisc mode;
for niantic, same result if has -p parameter or not
Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
tests/TestSuite_vf_kernel.py | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/tests/TestSuite_vf_kernel.py b/tests/TestSuite_vf_kernel.py
index a46a07b..a669a6f 100644
--- a/tests/TestSuite_vf_kernel.py
+++ b/tests/TestSuite_vf_kernel.py
@@ -417,15 +417,14 @@ class TestVfKernel(TestCase):
# Send packet from tester to VF MAC with not-matching vlan id, check
# the packet can't be received at the vlan device
+ # fortville nic need add -p parameter to disable promisc mode
wrong_vlan = vlan_ids % 4095 + 1
-
self.verify(self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0, vm0_vf0_mac,
- vlan_id='%d' % wrong_vlan) == False, "received wrong vlan packet")
-
+ vlan_id='%d' % wrong_vlan, param='-p') == False, "received wrong vlan packet")
# Send packet from tester to VF MAC with matching vlan id, check the packet can be received at the vlan device.
# check_result = self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0, self.vm0_vf0_mac, vlan_id='%d' %vlan_ids)
check_result = self.verify_vm_tcpdump(
- self.vm0_dut, self.vm0_intf0, vm0_vf0_mac, vlan_id='%d' % vlan_ids)
+ self.vm0_dut, self.vm0_intf0, vm0_vf0_mac, vlan_id='%d' % vlan_ids, param='-p')
self.verify(check_result, "can't received vlan_id=%d packet" % vlan_ids)
# Delete configured vlan device
@@ -436,12 +435,8 @@ class TestVfKernel(TestCase):
not in out, "vlan error")
# behavior is diffrent bettwn niantic and fortville ,because of kernel
# driver
- if self.nic.startswith('fortville'):
- self.verify(self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0,
- vm0_vf0_mac, vlan_id='%d' % vlan_ids) == True, "delete vlan error")
- else:
- self.verify(self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0,
- vm0_vf0_mac, vlan_id='%d' % vlan_ids) == False, "delete vlan error")
+ self.verify(self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0,
+ vm0_vf0_mac, vlan_id='%d' % vlan_ids, param='-p') == False, "delete vlan error")
self.dut_testpmd.execute_cmd("vlan set filter off 0")
def test_packet_statistic(self):
--
2.17.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dts] [PATCH V2] tests/vf kernel : fix vf wrong action
2018-12-21 8:25 [dts] [PATCH V2] tests/vf kernel : fix vf wrong action zhao,meijuan
@ 2018-12-29 3:06 ` Zhu, WenhuiX
2018-12-29 15:31 ` Lijuan Tu
1 sibling, 0 replies; 3+ messages in thread
From: Zhu, WenhuiX @ 2018-12-29 3:06 UTC (permalink / raw)
To: Zhao, MeijuanX, dts; +Cc: Zhao, MeijuanX
Tested-by: Zhu, WenhuiX <wenhuix.zhu@intel.com>
-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan
Sent: Friday, December 21, 2018 4:25 PM
To: dts@dpdk.org
Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
Subject: [dts] [PATCH V2] tests/vf kernel : fix vf wrong action
for fortville,tcpdump need add -p parameter to disable promisc mode; for niantic, same result if has -p parameter or not
Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
tests/TestSuite_vf_kernel.py | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/tests/TestSuite_vf_kernel.py b/tests/TestSuite_vf_kernel.py index a46a07b..a669a6f 100644
--- a/tests/TestSuite_vf_kernel.py
+++ b/tests/TestSuite_vf_kernel.py
@@ -417,15 +417,14 @@ class TestVfKernel(TestCase):
# Send packet from tester to VF MAC with not-matching vlan id, check
# the packet can't be received at the vlan device
+ # fortville nic need add -p parameter to disable promisc mode
wrong_vlan = vlan_ids % 4095 + 1
-
self.verify(self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0, vm0_vf0_mac,
- vlan_id='%d' % wrong_vlan) == False, "received wrong vlan packet")
-
+ vlan_id='%d' % wrong_vlan,
+ param='-p') == False, "received wrong vlan packet")
# Send packet from tester to VF MAC with matching vlan id, check the packet can be received at the vlan device.
# check_result = self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0, self.vm0_vf0_mac, vlan_id='%d' %vlan_ids)
check_result = self.verify_vm_tcpdump(
- self.vm0_dut, self.vm0_intf0, vm0_vf0_mac, vlan_id='%d' % vlan_ids)
+ self.vm0_dut, self.vm0_intf0, vm0_vf0_mac, vlan_id='%d' %
+ vlan_ids, param='-p')
self.verify(check_result, "can't received vlan_id=%d packet" % vlan_ids)
# Delete configured vlan device @@ -436,12 +435,8 @@ class TestVfKernel(TestCase):
not in out, "vlan error")
# behavior is diffrent bettwn niantic and fortville ,because of kernel
# driver
- if self.nic.startswith('fortville'):
- self.verify(self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0,
- vm0_vf0_mac, vlan_id='%d' % vlan_ids) == True, "delete vlan error")
- else:
- self.verify(self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0,
- vm0_vf0_mac, vlan_id='%d' % vlan_ids) == False, "delete vlan error")
+ self.verify(self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0,
+ vm0_vf0_mac, vlan_id='%d' %
+ vlan_ids, param='-p') == False, "delete vlan error")
self.dut_testpmd.execute_cmd("vlan set filter off 0")
def test_packet_statistic(self):
--
2.17.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dts] [PATCH V2] tests/vf kernel : fix vf wrong action
2018-12-21 8:25 [dts] [PATCH V2] tests/vf kernel : fix vf wrong action zhao,meijuan
2018-12-29 3:06 ` Zhu, WenhuiX
@ 2018-12-29 15:31 ` Lijuan Tu
1 sibling, 0 replies; 3+ messages in thread
From: Lijuan Tu @ 2018-12-29 15:31 UTC (permalink / raw)
To: zhao,meijuan, dts
Applied, thanks
On 2018年12月21日 16:25, zhao,meijuan wrote:
> for fortville,tcpdump need add -p parameter to disable promisc mode;
> for niantic, same result if has -p parameter or not
>
> Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> ---
> tests/TestSuite_vf_kernel.py | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/tests/TestSuite_vf_kernel.py b/tests/TestSuite_vf_kernel.py
> index a46a07b..a669a6f 100644
> --- a/tests/TestSuite_vf_kernel.py
> +++ b/tests/TestSuite_vf_kernel.py
> @@ -417,15 +417,14 @@ class TestVfKernel(TestCase):
>
> # Send packet from tester to VF MAC with not-matching vlan id, check
> # the packet can't be received at the vlan device
> + # fortville nic need add -p parameter to disable promisc mode
> wrong_vlan = vlan_ids % 4095 + 1
> -
> self.verify(self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0, vm0_vf0_mac,
> - vlan_id='%d' % wrong_vlan) == False, "received wrong vlan packet")
> -
> + vlan_id='%d' % wrong_vlan, param='-p') == False, "received wrong vlan packet")
> # Send packet from tester to VF MAC with matching vlan id, check the packet can be received at the vlan device.
> # check_result = self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0, self.vm0_vf0_mac, vlan_id='%d' %vlan_ids)
> check_result = self.verify_vm_tcpdump(
> - self.vm0_dut, self.vm0_intf0, vm0_vf0_mac, vlan_id='%d' % vlan_ids)
> + self.vm0_dut, self.vm0_intf0, vm0_vf0_mac, vlan_id='%d' % vlan_ids, param='-p')
> self.verify(check_result, "can't received vlan_id=%d packet" % vlan_ids)
>
> # Delete configured vlan device
> @@ -436,12 +435,8 @@ class TestVfKernel(TestCase):
> not in out, "vlan error")
> # behavior is diffrent bettwn niantic and fortville ,because of kernel
> # driver
> - if self.nic.startswith('fortville'):
> - self.verify(self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0,
> - vm0_vf0_mac, vlan_id='%d' % vlan_ids) == True, "delete vlan error")
> - else:
> - self.verify(self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0,
> - vm0_vf0_mac, vlan_id='%d' % vlan_ids) == False, "delete vlan error")
> + self.verify(self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0,
> + vm0_vf0_mac, vlan_id='%d' % vlan_ids, param='-p') == False, "delete vlan error")
> self.dut_testpmd.execute_cmd("vlan set filter off 0")
>
> def test_packet_statistic(self):
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-29 7:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-21 8:25 [dts] [PATCH V2] tests/vf kernel : fix vf wrong action zhao,meijuan
2018-12-29 3:06 ` Zhu, WenhuiX
2018-12-29 15:31 ` Lijuan Tu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).