From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 78A471B11A for ; Thu, 3 Jan 2019 13:39:31 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x03CYHoE022445 for ; Thu, 3 Jan 2019 04:39:30 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=0ham8xJN74qsZxcnZKr8U5GEAqa0GOCu9UjAs2AkMos=; b=feu10MYjYqaWDCgCQU8cz11TtdnqlbyxsTJHGMUGU2g7EAZiiNigEDsIxvzgW5r/vw44 ie8HgRej03HO+aj6QMsznvOaX2Mr15Zmx6/3248yOv33SRCnY/9jfTZpU695U5n+cZzs xuN3qK8WQ3dUoZMzbL2PUgV+GyA05PNmE1YnbUyCHIF/pvWEn+kpu8T5stxh+FllS1ko wmDeasa66+SVH9TUZV7EDLe1+08YCHY0wCrJlSg9lxntdFAG92RDbgKDZcFPFNhfG095 3JTaU9g8JwC3a1JC3syx2ZknukIpE7/Q6erQSBpvejDzIaVHCmnUw5U/0s+hAXwasq1f 6g== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2psh4b0d8p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Thu, 03 Jan 2019 04:39:30 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 3 Jan 2019 04:39:29 -0800 Received: from NAM05-BY2-obe.outbound.protection.outlook.com (104.47.50.50) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 3 Jan 2019 04:39:29 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ham8xJN74qsZxcnZKr8U5GEAqa0GOCu9UjAs2AkMos=; b=pBf5rjuEqrMnpYCG1wWE4Y4qkdmbFqF1l4xzai8mJfjcQTId8gxjhH32LRiK7lxQRmwMklyNtfam0ijdhzfBWACPmBpqSetYXLNpLcif/3tOWKkmNyN3chLu/L7bzjF5robrZm/6DZC4PTyTHpBSSKCynZVSb89iaKG3Ceng0CA= Received: from MN2PR18MB2704.namprd18.prod.outlook.com (20.178.255.93) by MN2PR18MB2846.namprd18.prod.outlook.com (20.179.21.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1495.6; Thu, 3 Jan 2019 12:39:27 +0000 Received: from MN2PR18MB2704.namprd18.prod.outlook.com ([fe80::f1b8:fc95:b6dd:7cce]) by MN2PR18MB2704.namprd18.prod.outlook.com ([fe80::f1b8:fc95:b6dd:7cce%7]) with mapi id 15.20.1495.005; Thu, 3 Jan 2019 12:39:27 +0000 From: Phanendra Vukkisala To: "dts@dpdk.org" CC: Vijaya Bhaskar Annayyolla , Faisal Masood , Phanendra Vukkisala Thread-Topic: [PATCH] disable-hw-vlan-filter: Removed flag in testpmd "--disable-hw-vlan-filter" Thread-Index: AQHUo2FdLZnehtHVwUKpKRKycdKzrw== Date: Thu, 3 Jan 2019 12:39:27 +0000 Message-ID: <1546519124-20339-1-git-send-email-pvukkisala@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BM1PR0101CA0067.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:19::29) To MN2PR18MB2704.namprd18.prod.outlook.com (2603:10b6:208:fd::29) x-originating-ip: [111.93.218.67] x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; MN2PR18MB2846; 20:0NqPKd+uifuWhr8uz0A22KNkEu6ClymBJeTvgGh0sg+yDwLbLOJS2Po3v1YmldpIlre8PlDVs8zI8WdpRGDfRozAhC8+iOqiLTxH7142xs1LMtF8N9vXPQkvKc2dbBOYUUgk2ZmV+35LQ4+jlacp+SD1xj8EwndRZY+xsxlExvs= x-ms-office365-filtering-correlation-id: 536e5b20-85ea-4bc8-b706-08d671787fd9 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(2017052603328)(7153060)(7193020); SRVR:MN2PR18MB2846; x-ms-traffictypediagnostic: MN2PR18MB2846: x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(8220060)(2401047)(8121501046)(3231475)(944501520)(52105112)(93006095)(93001095)(10201501046)(3002001)(6041310)(20161123562045)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:MN2PR18MB2846; BCL:0; PCL:0; RULEID:; SRVR:MN2PR18MB2846; x-forefront-prvs: 0906E83A25 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(396003)(346002)(376002)(136003)(189003)(199004)(8676002)(25786009)(81166006)(81156014)(4326008)(1730700003)(8936002)(14454004)(2616005)(476003)(486006)(6512007)(6916009)(256004)(86362001)(2501003)(575784001)(107886003)(52116002)(26005)(186003)(53936002)(102836004)(6506007)(386003)(7736002)(305945005)(78486014)(106356001)(105586002)(71190400001)(71200400001)(36756003)(97736004)(6116002)(3846002)(66066001)(316002)(54906003)(99286004)(6436002)(6486002)(5640700003)(478600001)(5660300001)(68736007)(2351001)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2846; H:MN2PR18MB2704.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 01wuUDCtFY1ofubzplReEM3SL8UqSvvDmE/MeX2RUHwt86WVzMinH6Lwuse3o4XzHJS7/QDDnyy2Gw/tVZrfjlGUHcdBvGbZsIdDWFVkueUPjalpGU2UOPOZ8YnVpPW6JL2KlaqTXL/PE8f9nBMqr1g9Mec5vaL5irnpLnmC+OzyQ8JohOXwSrnTGg0xAZ0BlxnfYk2TSvpn6Ja5JyAdnUPsIcHJMs3B8DX/nljKkPlFW0PQGQUOYbq8Xujg9Tqjrc1wLxh3rI0I20XGmBefavjr37XVD0UVQnEYeigJVm9yf5U8AbR9yyuSDfSBdD2J spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 536e5b20-85ea-4bc8-b706-08d671787fd9 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2019 12:39:27.8735 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2846 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-01-03_05:, , signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901030112 Subject: [dts] [PATCH] disable-hw-vlan-filter: Removed flag in testpmd "--disable-hw-vlan-filter" X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2019 12:39:31 -0000 From: pvukkisala For cavium devices this flag was added before, but now testpmd is not suppo= rting this flag, which is leading to failing tests on cavium devices. So removing unwanted flag Signed-off-by: phanendra,vukkisala --- framework/pmd_output.py | 4 ---- tests/TestSuite_dynamic_config.py | 6 ------ tests/TestSuite_pmdpcap.py | 4 ---- tests/TestSuite_unit_tests_dump.py | 9 --------- 4 files changed, 23 deletions(-) diff --git a/framework/pmd_output.py b/framework/pmd_output.py index aa9384d..80005e5 100644 --- a/framework/pmd_output.py +++ b/framework/pmd_output.py @@ -111,10 +111,6 @@ class PmdOutput(): self.coremask =3D create_mask(core_list) command =3D "./%s/app/testpmd -c %s -n %d %s -- -i %s" \ % (self.dut.target, self.coremask, self.dut.get_memory_channel= s(), eal_param, param) - if "cavium" in self.dut.nic_type: - # thunder nicvf does not support hw vlan filter, the applicati= on crashes - # without this option added - command +=3D " --disable-hw-vlan-filter" out =3D self.dut.send_expect(command, "testpmd> ", 120) self.command =3D command # wait 10s to ensure links getting up before test start. diff --git a/tests/TestSuite_dynamic_config.py b/tests/TestSuite_dynamic_co= nfig.py index 4df1291..d11a6b1 100644 --- a/tests/TestSuite_dynamic_config.py +++ b/tests/TestSuite_dynamic_config.py @@ -78,9 +78,6 @@ class TestDynamicConfig(TestCase): cmd =3D "./%s/app/testpmd -c %s -n 3 -- -i --rxpt=3D0 \ --rxht=3D0 --rxwt=3D0 --txpt=3D39 --txht=3D0 --txwt=3D0 --portmask= =3D%s" % (self.target, self.coreMask, self.portMask) =20 - if "cavium" in self.dut.nic_type: - cmd +=3D " --disable-hw-vlan-filter" - self.dut.send_expect("%s" % cmd, "testpmd> ", 120) =20 # get dest address from self.target port @@ -119,9 +116,6 @@ class TestDynamicConfig(TestCase): cmd =3D "./%s/app/testpmd -c %s -n 3 -- -i --rxpt=3D0 \ --rxht=3D0 --rxwt=3D0 --txpt=3D39 --txht=3D0 --txwt=3D0 --portmask= =3D%s" % (self.target, self.coreMask, self.portMask) =20 - if "cavium" in self.dut.nic_type: - cmd +=3D " --disable-hw-vlan-filter" - self.dut.send_expect("%s" % cmd, "testpmd> ", 120) time.sleep(5) self.dut.send_expect("start", "testpmd> ", 120) diff --git a/tests/TestSuite_pmdpcap.py b/tests/TestSuite_pmdpcap.py index eafd064..e0c4993 100644 --- a/tests/TestSuite_pmdpcap.py +++ b/tests/TestSuite_pmdpcap.py @@ -127,8 +127,6 @@ class TestPmdPcap(TestCase): command =3D ("./{}/app/testpmd -c {} -n {} " + "--vdev=3Deth_pcap0,rx_pcap=3D{},tx_pcap=3D{} " + "-- -i --port-topology=3Dchained --no-flush-rx") - if "cavium" in self.dut.nic_type: - command +=3D " --disable-hw-vlan-filter" =20 self.dut.send_expect(command.format(self.target, core_mask, self.memory_channel, @@ -163,8 +161,6 @@ class TestPmdPcap(TestCase): "--vdev=3Deth_pcap0,rx_pcap=3D{},tx_pcap=3D{} " + "--vdev=3Deth_pcap1,rx_pcap=3D{},tx_pcap=3D{} " + "-- -i --no-flush-rx") - if "cavium" in self.dut.nic_type: - command +=3D " --disable-hw-vlan-filter" =20 self.dut.send_expect(command.format(self.target, core_mask, self.memory_channel, diff --git a/tests/TestSuite_unit_tests_dump.py b/tests/TestSuite_unit_test= s_dump.py index 84ecce7..74dac56 100644 --- a/tests/TestSuite_unit_tests_dump.py +++ b/tests/TestSuite_unit_tests_dump.py @@ -90,9 +90,6 @@ class TestUnitTestsDump(TestCase): """ cmd =3D "./%s/app/testpmd -n 1 -c f -- -i" % self.target =20 - if "cavium_a034" in self.dut.nic_type: - cmd +=3D " --disable-hw-vlan-filter" - self.dut.send_expect("%s" % cmd, "testpmd>", self.start_test_time) out =3D self.dut.send_expect("dump_ring", "testpmd>", self.run_cmd= _time) self.dut.send_expect("quit", "# ") @@ -110,9 +107,6 @@ class TestUnitTestsDump(TestCase): """ cmd =3D "./%s/app/testpmd -n 1 -c f -- -i" % self.target =20 - if "cavium_a034" in self.dut.nic_type: - cmd +=3D " --disable-hw-vlan-filter" - self.dut.send_expect("%s" % cmd, "testpmd>", self.start_test_time) out =3D self.dut.send_expect("dump_mempool", "testpmd>", self.run_= cmd_time * 2) self.dut.send_expect("quit", "# ") @@ -148,9 +142,6 @@ class TestUnitTestsDump(TestCase): """ cmd =3D "./%s/app/testpmd -n 1 -c f -- -i" % self.target =20 - if "cavium_a034" in self.dut.nic_type: - cmd +=3D " --disable-hw-vlan-filter" - self.dut.send_expect("%s" % cmd, "testpmd>", self.start_test_time) out =3D self.dut.send_expect("dump_memzone", "testpmd>", self.run_= cmd_time * 2) self.dut.send_expect("quit", "# ") --=20 1.7.9.5