test suite reviews and discussions
 help / color / mirror / Atom feed
From: Xueqin Lin <xueqin.lin@intel.com>
To: dts@dpdk.org
Cc: "xueqin.lin" <xueqin.lin@intel.com>
Subject: [dts] [PATCH] tests/dynamic_flowtype: fix dynamic flowtype issues
Date: Mon,  7 Jan 2019 23:28:13 -0500	[thread overview]
Message-ID: <1546921693-168124-1-git-send-email-xueqin.lin@intel.com> (raw)

From: "xueqin.lin" <xueqin.lin@intel.com>

1. Dynamic flowtype could support FVL nic, not only fortville_25g.
2. RSS works also could receive packets from queue 0.
3. Restore original profile instead of core reset to avoid exception. 

Signed-off-by: Xueqin Lin <xueqin.lin@intel.com>

---
 tests/TestSuite_dynamic_flowtype.py | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/tests/TestSuite_dynamic_flowtype.py b/tests/TestSuite_dynamic_flowtype.py
index 05e6bcb..4652955 100644
--- a/tests/TestSuite_dynamic_flowtype.py
+++ b/tests/TestSuite_dynamic_flowtype.py
@@ -12,7 +12,7 @@ VM_CORES_MASK = 'all'
 class TestDynamicFlowtype(TestCase):
 
     def set_up_all(self):
-        self.verify(self.nic in ['fortville_25g'],
+        self.verify('fortville' in self.nic,
                     'dynamic flow type mapping can not support %s nic'
                     % self.nic)
         ports = self.dut.get_ports()
@@ -61,7 +61,7 @@ class TestDynamicFlowtype(TestCase):
         self.dut_testpmd.execute_cmd('port stop all')
         time.sleep(1)
         out = self.dut_testpmd.execute_cmd('ddp get list 0')
-        self.dut_testpmd.execute_cmd('ddp add 0 /tmp/gtp.pkgo')
+        self.dut_testpmd.execute_cmd('ddp add 0 /tmp/gtp.pkgo,/tmp/gtp.bak')
         out = self.dut_testpmd.execute_cmd('ddp get list 0')
         self.verify("Profile number is: 1" in out,
                     "Failed to load ddp profile!!!")
@@ -179,8 +179,6 @@ class TestDynamicFlowtype(TestCase):
             self.tester.scapy_execute()
             out = self.dut.get_session_output(timeout=2)
             if match_opt == 'matched':
-                self.verify("port 0/queue 0" not in out,
-                            "Failed to receive packet in rss queue!!!")
                 self.verify("PKT_RX_RSS_HASH" in out,
                             "Failed to receive packet in rss queue!!!")
             elif match_opt == 'not matched':
@@ -280,10 +278,17 @@ class TestDynamicFlowtype(TestCase):
         self.dynamic_flowtype_test(pctype=25, flowtype=25, reset=False)
 
     def tear_down(self):
-        if self.dut_testpmd:
-            self.dut_testpmd.execute_cmd('write reg 0 0xb8190 1')
-            self.dut_testpmd.execute_cmd('write reg 0 0xb8190 2')
-            self.dut_testpmd.quit()
+        self.dut_testpmd.execute_cmd('stop')
+        out = self.dut_testpmd.execute_cmd('ddp get list 0')
+        if "Profile number is: 0" not in out:
+            self.dut_testpmd.execute_cmd('port stop all')
+            time.sleep(1)
+            self.dut_testpmd.execute_cmd('ddp del 0 /tmp/gtp.bak')
+            out = self.dut_testpmd.execute_cmd('ddp get list 0')
+            self.verify("Profile number is: 0" in out,
+                        "Failed to delete ddp profile!!!")
+            self.dut_testpmd.execute_cmd('port start all')
+        self.dut_testpmd.quit()
 
     def tear_down_all(self):
         self.dut.kill_all()
-- 
2.7.5

             reply	other threads:[~2019-01-08 10:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-08  4:28 Xueqin Lin [this message]
2019-01-15  1:07 ` Zhu, WenhuiX
2019-01-15  4:55 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1546921693-168124-1-git-send-email-xueqin.lin@intel.com \
    --to=xueqin.lin@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).