From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 69A4B1B946 for ; Fri, 11 Jan 2019 08:42:30 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2019 23:42:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,464,1539673200"; d="scan'208";a="126820972" Received: from unknown (HELO localhost.localdomain.sh.intel.com) ([10.240.176.135]) by orsmga001.jf.intel.com with ESMTP; 10 Jan 2019 23:42:28 -0800 From: Wenjie Li To: dts@dpdk.org Cc: Wenjie Li Date: Fri, 11 Jan 2019 15:45:56 +0800 Message-Id: <1547192756-26241-1-git-send-email-wenjiex.a.li@intel.com> X-Mailer: git-send-email 1.9.3 Subject: [dts] [PATCH V1] fix crc strip only supports 2 ports env issue X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 07:42:30 -0000 Before update, crc_keep and crc_strip only support 2 ports env; now it could support all ports(not only 2). Signed-off-by: Wenjie Li --- tests/TestSuite_shutdown_api.py | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py index ba4c6cb..9f3f03f 100644 --- a/tests/TestSuite_shutdown_api.py +++ b/tests/TestSuite_shutdown_api.py @@ -268,7 +268,11 @@ class TestShutdownApi(TestCase): self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop --disable-crc-strip" % utils.create_mask(self.ports), socket=self.ports_socket) out = self.dut.send_expect("show config rxtx", "testpmd> ") Rx_offloads = re.compile('Rx offloads=(.*?)\s+?').findall(out, re.S) - crc_keep = int(Rx_offloads[0],16) & RX_OFFLOAD_KEEP_CRC and int(Rx_offloads[1],16) & RX_OFFLOAD_KEEP_CRC + crc_keep_temp = [] + for i in range(len(self.dut.get_ports())): + crc_keep_temp.append(int(Rx_offloads[i],16) & RX_OFFLOAD_KEEP_CRC) + crc_keep = crc_keep_temp[0] + crc_keep = crc_keep and crc_keep_temp[i] self.verify( crc_keep == RX_OFFLOAD_KEEP_CRC, "CRC keeping not enabled properly") @@ -278,7 +282,11 @@ class TestShutdownApi(TestCase): self.dut.send_expect("port start all", "testpmd> ", 100) out = self.dut.send_expect("show config rxtx", "testpmd> ") Rx_offloads = re.compile('Rx offloads=(.*?)\s+?').findall(out, re.S) - crc_strip = int(Rx_offloads[0],16) | ~RX_OFFLOAD_KEEP_CRC and int(Rx_offloads[1],16) | ~RX_OFFLOAD_KEEP_CRC + crc_strip_temp = [] + for i in range(len(self.dut.get_ports())): + crc_strip_temp.append(int(Rx_offloads[i],16) | ~RX_OFFLOAD_KEEP_CRC) + crc_strip = crc_strip_temp[0] + crc_strip = crc_strip and crc_strip_temp[i] self.verify( crc_strip == ~RX_OFFLOAD_KEEP_CRC, "CRC stripping not enabled properly") self.dut.send_expect("start", "testpmd> ") -- 2.17.2