test suite reviews and discussions
 help / color / mirror / Atom feed
From: Wenjie Li <wenjiex.a.li@intel.com>
To: dts@dpdk.org
Cc: Wenjie Li <wenjiex.a.li@intel.com>
Subject: [dts] [PATCH V1] tests/enable_package_download_in_ice_driver: align changes with dpdk
Date: Thu, 25 Jul 2019 19:25:28 +0800	[thread overview]
Message-ID: <1564053928-58365-1-git-send-email-wenjiex.a.li@intel.com> (raw)

1. In dpdk 603beeb970b5d87fa7, use parameter "-w PORT_PCI,safe-mode-support=1" to enter safe mode, align this change in dts.
2. Delete dupicated error message.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 .../TestSuite_enable_package_download_in_ice_driver.py | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_enable_package_download_in_ice_driver.py b/tests/TestSuite_enable_package_download_in_ice_driver.py
index b5e3e2f..4acc3fe 100644
--- a/tests/TestSuite_enable_package_download_in_ice_driver.py
+++ b/tests/TestSuite_enable_package_download_in_ice_driver.py
@@ -54,6 +54,9 @@ class TestEnable_Package_Download_In_Ice_Driver(TestCase):
         self.tester_p0_mac = self.tester.get_mac(localPort0)
         self.dut_testpmd = PmdOutput(self.dut)
 
+        self.dut_p0_pci = self.dut.get_port_pci(self.dut_ports[0])
+        self.dut_p1_pci = self.dut.get_port_pci(self.dut_ports[1])
+
         self.pkg_file = '/lib/firmware/intel/ice/ddp/ice.pkg'
         out = self.dut.send_expect("ls %s" % self.pkg_file, "#")
         self.verify("No such file or directory" not in out, "Cannot find %s, please check you system/driver." % self.pkg_file)
@@ -85,10 +88,13 @@ class TestEnable_Package_Download_In_Ice_Driver(TestCase):
             self.dut.send_expect("touch %s" % self.pkg_file, "#")
 
     def start_testpmd(self, flag="true"):
-        out = self.dut_testpmd.start_testpmd("all", "--nb-cores=8 --rxq=%s --txq=%s --port-topology=chained" % (self.PF_QUEUE, self.PF_QUEUE))
+        if flag != "true":
+            self.eal_param="-w %s,safe-mode-support=1 -w %s,safe-mode-support=1" % (self.dut_p0_pci, self.dut_p1_pci)
+        else:
+            self.eal_param=""
+        out = self.dut_testpmd.start_testpmd("all", "--nb-cores=8 --rxq=%s --txq=%s --port-topology=chained" % (self.PF_QUEUE, self.PF_QUEUE), eal_param=self.eal_param)
         if flag != "true":
             error_messages = ["ice_load_pkg(): failed to allocate buf of size 0 for package", \
-                    "ice_load_pkg(): failed to allocate buf of size 0 for package", \
                     "ice_dev_init(): Failed to load the DDP package,Entering Safe Mode", \
                     "ice_init_rss(): RSS is not supported in safe mode"]
             for error_message in error_messages:
-- 
2.17.1


                 reply	other threads:[~2019-07-25 11:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1564053928-58365-1-git-send-email-wenjiex.a.li@intel.com \
    --to=wenjiex.a.li@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).