test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1 0/2] dts/pktgen: fix missing parameter setting
@ 2019-08-06  7:16 yufengmx
  2019-08-06  7:16 ` [dts] [PATCH V1 1/2] framework/pktgen_base: fix measure_throughput missed option yufengmx
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: yufengmx @ 2019-08-06  7:16 UTC (permalink / raw)
  To: dts; +Cc: yufengmx

 These commits are internal bugs fixed, which are reported by ma,lihong 
 
 *. add missing rate percent key of stream config option in pktgen module. 
 *. add missing start traffic option input in measure_throughput method. 

yufengmx (2):
  framework/pktgen_base: fix measure_throughput missed option input
  framework/pktgen: fix PacketGeneratorHelper missed rate setting

 framework/pktgen.py      | 1 +
 framework/pktgen_base.py | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
1.9.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts] [PATCH V1 1/2] framework/pktgen_base: fix measure_throughput missed option
  2019-08-06  7:16 [dts] [PATCH V1 0/2] dts/pktgen: fix missing parameter setting yufengmx
@ 2019-08-06  7:16 ` yufengmx
  2019-08-06  7:16 ` [dts] [PATCH V1 2/2] framework/pktgen: fix PacketGeneratorHelper missed rate yufengmx
  2019-08-08  5:39 ` [dts] [PATCH V1 0/2] dts/pktgen: fix missing parameter setting Tu, Lijuan
  2 siblings, 0 replies; 5+ messages in thread
From: yufengmx @ 2019-08-06  7:16 UTC (permalink / raw)
  To: dts; +Cc: yufengmx

 input

add missing _start_transmission options input in measure_throughput method.

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 framework/pktgen_base.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/pktgen_base.py b/framework/pktgen_base.py
index 6bfc49a..eec4e6f 100644
--- a/framework/pktgen_base.py
+++ b/framework/pktgen_base.py
@@ -237,7 +237,7 @@ class PacketGenerator(object):
         # start warm up traffic
         self.__warm_up_pktgen(stream_ids, options, delay)
         # main traffic
-        self._start_transmission(stream_ids)
+        self._start_transmission(stream_ids, options)
         # keep traffic within a duration time and get throughput statistic
         if interval and duration:
             stats = self.__get_multi_throughput_statistic(
-- 
1.9.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts] [PATCH V1 2/2] framework/pktgen: fix PacketGeneratorHelper missed rate
  2019-08-06  7:16 [dts] [PATCH V1 0/2] dts/pktgen: fix missing parameter setting yufengmx
  2019-08-06  7:16 ` [dts] [PATCH V1 1/2] framework/pktgen_base: fix measure_throughput missed option yufengmx
@ 2019-08-06  7:16 ` yufengmx
  2019-08-08  5:39 ` [dts] [PATCH V1 0/2] dts/pktgen: fix missing parameter setting Tu, Lijuan
  2 siblings, 0 replies; 5+ messages in thread
From: yufengmx @ 2019-08-06  7:16 UTC (permalink / raw)
  To: dts; +Cc: yufengmx

 setting

add missing stream rate option in prepare_stream_from_tginput method.

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 framework/pktgen.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/framework/pktgen.py b/framework/pktgen.py
index 1c8acac..f87baa3 100644
--- a/framework/pktgen.py
+++ b/framework/pktgen.py
@@ -193,6 +193,7 @@ class PacketGeneratorHelper(object):
             stream_id = pktgen_inst.add_stream(*config)
             pcap = config[2]
             _options = deepcopy(self.default_opt)
+            _options['stream_config']['rate'] = ratePercent
             _options['pcap'] = pcap
             # if vm is set
             if vm_config:
-- 
1.9.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1 0/2] dts/pktgen: fix missing parameter setting
  2019-08-06  7:16 [dts] [PATCH V1 0/2] dts/pktgen: fix missing parameter setting yufengmx
  2019-08-06  7:16 ` [dts] [PATCH V1 1/2] framework/pktgen_base: fix measure_throughput missed option yufengmx
  2019-08-06  7:16 ` [dts] [PATCH V1 2/2] framework/pktgen: fix PacketGeneratorHelper missed rate yufengmx
@ 2019-08-08  5:39 ` Tu, Lijuan
  2019-08-08  5:42   ` Mo, YufengX
  2 siblings, 1 reply; 5+ messages in thread
From: Tu, Lijuan @ 2019-08-08  5:39 UTC (permalink / raw)
  To: Mo, YufengX, dts; +Cc: Mo, YufengX

The series applied failed, could you please rework them.
thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yufengmx
> Sent: Tuesday, August 6, 2019 3:17 PM
> To: dts@dpdk.org
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts] [PATCH V1 0/2] dts/pktgen: fix missing parameter setting
> 
>  These commits are internal bugs fixed, which are reported by ma,lihong
> 
>  *. add missing rate percent key of stream config option in pktgen module.
>  *. add missing start traffic option input in measure_throughput method.
> 
> yufengmx (2):
>   framework/pktgen_base: fix measure_throughput missed option input
>   framework/pktgen: fix PacketGeneratorHelper missed rate setting
> 
>  framework/pktgen.py      | 1 +
>  framework/pktgen_base.py | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> --
> 1.9.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1 0/2] dts/pktgen: fix missing parameter setting
  2019-08-08  5:39 ` [dts] [PATCH V1 0/2] dts/pktgen: fix missing parameter setting Tu, Lijuan
@ 2019-08-08  5:42   ` Mo, YufengX
  0 siblings, 0 replies; 5+ messages in thread
From: Mo, YufengX @ 2019-08-08  5:42 UTC (permalink / raw)
  To: Tu, Lijuan, dts

ok
> -----Original Message-----
> From: Tu, Lijuan
> Sent: Thursday, August 8, 2019 1:39 PM
> To: Mo, YufengX <yufengx.mo@intel.com>; dts@dpdk.org
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: RE: [dts] [PATCH V1 0/2] dts/pktgen: fix missing parameter setting
> 
> The series applied failed, could you please rework them.
> thanks
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yufengmx
> > Sent: Tuesday, August 6, 2019 3:17 PM
> > To: dts@dpdk.org
> > Cc: Mo, YufengX <yufengx.mo@intel.com>
> > Subject: [dts] [PATCH V1 0/2] dts/pktgen: fix missing parameter setting
> >
> >  These commits are internal bugs fixed, which are reported by ma,lihong
> >
> >  *. add missing rate percent key of stream config option in pktgen module.
> >  *. add missing start traffic option input in measure_throughput method.
> >
> > yufengmx (2):
> >   framework/pktgen_base: fix measure_throughput missed option input
> >   framework/pktgen: fix PacketGeneratorHelper missed rate setting
> >
> >  framework/pktgen.py      | 1 +
> >  framework/pktgen_base.py | 2 +-
> >  2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > --
> > 1.9.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-06  7:16 [dts] [PATCH V1 0/2] dts/pktgen: fix missing parameter setting yufengmx
2019-08-06  7:16 ` [dts] [PATCH V1 1/2] framework/pktgen_base: fix measure_throughput missed option yufengmx
2019-08-06  7:16 ` [dts] [PATCH V1 2/2] framework/pktgen: fix PacketGeneratorHelper missed rate yufengmx
2019-08-08  5:39 ` [dts] [PATCH V1 0/2] dts/pktgen: fix missing parameter setting Tu, Lijuan
2019-08-08  5:42   ` Mo, YufengX

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox