test suite reviews and discussions
 help / color / mirror / Atom feed
From: <thaq@marvell.com>
To: <dts@dpdk.org>
Cc: <fmasood@marvell.com>, <avijay@marvell.com>,
	Thanseerulhaq <thaq@marvell.com>
Subject: [dts] [PATCH] tests/TestSuite_userspace_ethtool.py: Corrected error in userspaceethtool ringparam testcase.
Date: Wed, 14 Aug 2019 19:43:08 +0530	[thread overview]
Message-ID: <1565791988-7842-1-git-send-email-thaq@marvell.com> (raw)

From: Thanseerulhaq <thaq@marvell.com>

Observed ethtool ringparam setting command is passed worngly.
EthApp> ringparam <port_id> <tx_param> <rx_param>
        Set ring parameters

Signed-off-by: Thanseerulhaq <thaq@marvell.com>
---
 tests/TestSuite_userspace_ethtool.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index 557a3ff..0a4b772 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -402,7 +402,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
             port = self.ports[index]
             ori_rx_pkts, ori_tx_pkts = self.strip_portstats(port)
             _, rx_max, _, tx_max = self.strip_ringparam(index)
-            self.dut.send_expect("ringparam %d %d %d" % (index, rx_max, tx_max), "EthApp>")
+            self.dut.send_expect("ringparam %d %d %d" % (index, tx_max, rx_max), "EthApp>")
             rx_ring, _, tx_ring, _ = self.strip_ringparam(index)
             self.verify(rx_ring == rx_max, "Userspace tool failed to set Rx ring parameter")
             self.verify(tx_ring == tx_max, "Userspace tool failed to set Tx ring parameter")
-- 
1.8.3.1


             reply	other threads:[~2019-08-14 14:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14 14:13 thaq [this message]
2019-08-28 10:06 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1565791988-7842-1-git-send-email-thaq@marvell.com \
    --to=thaq@marvell.com \
    --cc=avijay@marvell.com \
    --cc=dts@dpdk.org \
    --cc=fmasood@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).