From: Wenjie Li <wenjiex.a.li@intel.com>
To: dts@dpdk.org
Cc: Wenjie Li <wenjiex.a.li@intel.com>
Subject: [dts] [PATCH V2] tests/kni:del the ip before verify results
Date: Fri, 16 Aug 2019 11:52:58 +0000 [thread overview]
Message-ID: <1565956378-40658-1-git-send-email-wenjiex.a.li@intel.com> (raw)
Remove the ip from tester before verify results; otehrwise, if the case is fail, the ip is still existing on tester.
Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
V2: delete the dupicate "ip addr del..."
tests/TestSuite_kni.py | 24 ++++++++++--------------
1 file changed, 10 insertions(+), 14 deletions(-)
diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py
index f1f85df..0fa5113 100644
--- a/tests/TestSuite_kni.py
+++ b/tests/TestSuite_kni.py
@@ -579,20 +579,19 @@ class TestKni(TestCase):
virtual_interface = self.virtual_interface_name(port)
- out = self.dut.send_expect(
+ out1 = self.dut.send_expect(
"ping -w 2 -I %s 192.168.%d.2" % (virtual_interface, port), "# ", 10)
- self.verify("64 bytes from 192.168.%d.2:" %
- port in out, "ping not supported")
-
- out = self.tester.send_expect(
+ out2 = self.tester.send_expect(
"ping -w 1 -I %s 192.168.%d.1" % (tx_interface, port), "# ", 10)
- self.verify("64 bytes from 192.168.%d.1:" %
- port in out, "kni cannot reply ping packet")
-
- out = self.dut.send_expect(
+ out3 = self.dut.send_expect(
"ping -w 1 -I %s 192.168.%d.123" % (virtual_interface, port), "# ", 10)
- self.verify(
- "0 received, 100% packet loss" in out, "ping not supported")
+
+ # remove ip from tester
+ self.tester.send_expect("ip addr del 192.168.%d.2 dev %s" % (port, tx_interface), "# ")
+
+ self.verify("64 bytes from 192.168.%d.2:" %port in out1, "ping not supported")
+ self.verify("64 bytes from 192.168.%d.1:" %port in out2, "kni cannot reply ping packet")
+ self.verify("0 received, 100% packet loss" in out3, "ping not supported")
out = self.dut.send_expect(
"ip -family inet6 address show dev %s | awk '/inet6/ { print $2 }'| cut -d'/' -f1" % virtual_interface, "# ", 10)
@@ -622,9 +621,6 @@ class TestKni(TestCase):
(virtual_interface, ''.join(ipv6list)), "# ", 10)
self.verify(
"0 received, 100% packet loss" in out, "ping6 not supported")
- # remove ip from tester
- self.tester.send_expect(
- "ip addr del 192.168.%d.2 dev %s" % (port, tx_interface), "# ")
for port in self.config['ports']:
tx_port = self.tester.get_local_port(port)
--
2.17.1
next reply other threads:[~2019-08-16 2:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 11:52 Wenjie Li [this message]
2019-08-16 2:59 ` Li, WenjieX A
2019-08-28 10:45 ` Tu, Lijuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1565956378-40658-1-git-send-email-wenjiex.a.li@intel.com \
--to=wenjiex.a.li@intel.com \
--cc=dts@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).