From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C370A046B for ; Mon, 19 Aug 2019 12:15:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 49ACE1B994; Mon, 19 Aug 2019 12:15:03 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A0E2C1B994 for ; Mon, 19 Aug 2019 12:15:01 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Aug 2019 03:14:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,403,1559545200"; d="scan'208";a="261799713" Received: from unknown (HELO dpdk-wenjielx-KVM193.icx.intel.com) ([10.240.176.193]) by orsmga001.jf.intel.com with ESMTP; 19 Aug 2019 03:14:59 -0700 From: Wenjie Li To: dts@dpdk.org Cc: Wenjie Li Date: Mon, 19 Aug 2019 19:09:16 +0000 Message-Id: <1566241756-5557-1-git-send-email-wenjiex.a.li@intel.com> X-Mailer: git-send-email 1.9.3 Subject: [dts] [PATCH V1] tests/enable_package_download_in_ice_driver:add all ports with -w X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Should add ALL ports with -w parameter. If the nic has 4 ports, all ports should be bind with -w; otherwise, the ports will be down in testpmd. Signed-off-by: Wenjie Li --- tests/TestSuite_enable_package_download_in_ice_driver.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tests/TestSuite_enable_package_download_in_ice_driver.py b/tests/TestSuite_enable_package_download_in_ice_driver.py index 9197198..b225ef3 100644 --- a/tests/TestSuite_enable_package_download_in_ice_driver.py +++ b/tests/TestSuite_enable_package_download_in_ice_driver.py @@ -54,9 +54,6 @@ class TestEnable_Package_Download_In_Ice_Driver(TestCase): self.tester_p0_mac = self.tester.get_mac(localPort0) self.dut_testpmd = PmdOutput(self.dut) - self.dut_p0_pci = self.dut.get_port_pci(self.dut_ports[0]) - self.dut_p1_pci = self.dut.get_port_pci(self.dut_ports[1]) - self.pkg_file = '/lib/firmware/intel/ice/ddp/ice.pkg' out = self.dut.send_expect("ls %s" % self.pkg_file, "#") self.verify("No such file or directory" not in out, "Cannot find %s, please check you system/driver." % self.pkg_file) @@ -88,10 +85,10 @@ class TestEnable_Package_Download_In_Ice_Driver(TestCase): self.dut.send_expect("touch %s" % self.pkg_file, "#") def start_testpmd(self, ice_pkg="true", safe_mode_support="false"): + self.eal_param = "" if safe_mode_support == "true": - self.eal_param="-w %s,safe-mode-support=1 -w %s,safe-mode-support=1" % (self.dut_p0_pci, self.dut_p1_pci) - else: - self.eal_param="" + for i in range(len(self.dut_ports)): + self.eal_param = self.eal_param + "-w %s,safe-mode-support=1 " % self.dut.ports_info[i]['pci'] out = self.dut_testpmd.start_testpmd("all", "--nb-cores=8 --rxq=%s --txq=%s --port-topology=chained" % (self.PF_QUEUE, self.PF_QUEUE), eal_param=self.eal_param) if ice_pkg == "false": if safe_mode_support == "true": -- 2.17.1