From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B456FA2EDB for ; Fri, 6 Sep 2019 11:49:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AA3431F13D; Fri, 6 Sep 2019 11:49:00 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id EB5391F13B for ; Fri, 6 Sep 2019 11:48:58 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Sep 2019 02:48:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,472,1559545200"; d="scan'208";a="199486731" Received: from unknown (HELO dpdk-wenjielx-KVM193.icx.intel.com) ([10.240.176.193]) by fmsmga001.fm.intel.com with ESMTP; 06 Sep 2019 02:48:57 -0700 From: Wenjie Li To: dts@dpdk.org Cc: Wenjie Li Date: Fri, 6 Sep 2019 18:42:30 +0000 Message-Id: <1567795350-70617-1-git-send-email-wenjiex.a.li@intel.com> X-Mailer: git-send-email 1.9.3 Subject: [dts] [PATCH V1] tests/ipgre: optimize script X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" 1. could support cvl nic, add cvl to nic list 2. move dut.kill_all from tear_down_all to tear_down, since testpmd will be started in every case, if one case is failed, the testpmd is still runnning, this will affect the following cases. Signed-off-by: Wenjie Li --- tests/TestSuite_ipgre.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index 7fbddf1..e10b0e0 100644 --- a/tests/TestSuite_ipgre.py +++ b/tests/TestSuite_ipgre.py @@ -63,7 +63,7 @@ class TestIpgre(TestCase): """ self.printFlag = self._enable_debug ports = self.dut.get_ports() - self.verify(self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "carlsville"], + self.verify(self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "carlsville", "columbiaville_25g", "columbiaville_100g"], "GRE tunnel packet type only support by fortville and carlsville") self.verify(len(ports) >= 1, "Insufficient ports for testing") valports = [_ for _ in ports if self.tester.get_local_port(_) != -1] @@ -439,12 +439,11 @@ class TestIpgre(TestCase): Run after each test case. Nothing to do. """ - pass + self.dut.kill_all() def tear_down_all(self): """ Run after each test suite. Nothing to do. """ - self.dut.kill_all() pass -- 2.17.1