test suite reviews and discussions
 help / color / mirror / Atom feed
From: Xiao Qimai <qimaix.xiao@intel.com>
To: dts@dpdk.org
Cc: Xiao Qimai <qimaix.xiao@intel.com>
Subject: [dts] [PATCH V1] framework/utils: add verify subclazz.__bases__ is not None or empty
Date: Thu, 17 Oct 2019 03:26:44 -0400	[thread overview]
Message-ID: <1571297204-82266-1-git-send-email-qimaix.xiao@intel.com> (raw)

in scapy 2.4.3, when import scapy.all import * in testsuit will cause error, subclazz.__bases__ can't be None or empty in this if sentence

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
 framework/utils.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/utils.py b/framework/utils.py
index 8f5a233..516dc91 100644
--- a/framework/utils.py
+++ b/framework/utils.py
@@ -195,7 +195,7 @@ def get_subclasses(module, clazz):
     Get module attribute name and attribute.
     """
     for subclazz_name, subclazz in inspect.getmembers(module):
-        if hasattr(subclazz, '__bases__') and clazz in subclazz.__bases__:
+        if hasattr(subclazz, '__bases__') and subclazz.__bases__ and clazz in subclazz.__bases__:
             yield (subclazz_name, subclazz)
 
 
-- 
1.8.3.1


             reply	other threads:[~2019-10-17  7:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-17  7:26 Xiao Qimai [this message]
2019-10-17  7:48 ` Zeng, XiaoxiaoX
2019-10-22  9:26 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1571297204-82266-1-git-send-email-qimaix.xiao@intel.com \
    --to=qimaix.xiao@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).