* [dts] [PATCH V1] framework/utils: add verify subclazz.__bases__ is not None or empty
@ 2019-10-17 7:26 Xiao Qimai
2019-10-17 7:48 ` Zeng, XiaoxiaoX
2019-10-22 9:26 ` Tu, Lijuan
0 siblings, 2 replies; 3+ messages in thread
From: Xiao Qimai @ 2019-10-17 7:26 UTC (permalink / raw)
To: dts; +Cc: Xiao Qimai
in scapy 2.4.3, when import scapy.all import * in testsuit will cause error, subclazz.__bases__ can't be None or empty in this if sentence
Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
framework/utils.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/framework/utils.py b/framework/utils.py
index 8f5a233..516dc91 100644
--- a/framework/utils.py
+++ b/framework/utils.py
@@ -195,7 +195,7 @@ def get_subclasses(module, clazz):
Get module attribute name and attribute.
"""
for subclazz_name, subclazz in inspect.getmembers(module):
- if hasattr(subclazz, '__bases__') and clazz in subclazz.__bases__:
+ if hasattr(subclazz, '__bases__') and subclazz.__bases__ and clazz in subclazz.__bases__:
yield (subclazz_name, subclazz)
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dts] [PATCH V1] framework/utils: add verify subclazz.__bases__ is not None or empty
2019-10-17 7:26 [dts] [PATCH V1] framework/utils: add verify subclazz.__bases__ is not None or empty Xiao Qimai
@ 2019-10-17 7:48 ` Zeng, XiaoxiaoX
2019-10-22 9:26 ` Tu, Lijuan
1 sibling, 0 replies; 3+ messages in thread
From: Zeng, XiaoxiaoX @ 2019-10-17 7:48 UTC (permalink / raw)
To: Xiao, QimaiX, dts, Zeng, XiaoxiaoX; +Cc: Xiao, QimaiX
Tested-by: Zeng,xiaoxiaoX <xiaoxiaox.zeng@intel.com>
-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
Sent: Thursday, October 17, 2019 3:27 PM
To: dts@dpdk.org
Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
Subject: [dts] [PATCH V1] framework/utils: add verify subclazz.__bases__ is not None or empty
in scapy 2.4.3, when import scapy.all import * in testsuit will cause error, subclazz.__bases__ can't be None or empty in this if sentence
Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
framework/utils.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/framework/utils.py b/framework/utils.py index 8f5a233..516dc91 100644
--- a/framework/utils.py
+++ b/framework/utils.py
@@ -195,7 +195,7 @@ def get_subclasses(module, clazz):
Get module attribute name and attribute.
"""
for subclazz_name, subclazz in inspect.getmembers(module):
- if hasattr(subclazz, '__bases__') and clazz in subclazz.__bases__:
+ if hasattr(subclazz, '__bases__') and subclazz.__bases__ and clazz in subclazz.__bases__:
yield (subclazz_name, subclazz)
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dts] [PATCH V1] framework/utils: add verify subclazz.__bases__ is not None or empty
2019-10-17 7:26 [dts] [PATCH V1] framework/utils: add verify subclazz.__bases__ is not None or empty Xiao Qimai
2019-10-17 7:48 ` Zeng, XiaoxiaoX
@ 2019-10-22 9:26 ` Tu, Lijuan
1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-10-22 9:26 UTC (permalink / raw)
To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX
Applied, thanks
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Thursday, October 17, 2019 3:27 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1] framework/utils: add verify subclazz.__bases__ is
> not None or empty
>
> in scapy 2.4.3, when import scapy.all import * in testsuit will cause error,
> subclazz.__bases__ can't be None or empty in this if sentence
>
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
> framework/utils.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/framework/utils.py b/framework/utils.py index 8f5a233..516dc91
> 100644
> --- a/framework/utils.py
> +++ b/framework/utils.py
> @@ -195,7 +195,7 @@ def get_subclasses(module, clazz):
> Get module attribute name and attribute.
> """
> for subclazz_name, subclazz in inspect.getmembers(module):
> - if hasattr(subclazz, '__bases__') and clazz in subclazz.__bases__:
> + if hasattr(subclazz, '__bases__') and subclazz.__bases__ and clazz in
> subclazz.__bases__:
> yield (subclazz_name, subclazz)
>
>
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-22 9:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-17 7:26 [dts] [PATCH V1] framework/utils: add verify subclazz.__bases__ is not None or empty Xiao Qimai
2019-10-17 7:48 ` Zeng, XiaoxiaoX
2019-10-22 9:26 ` Tu, Lijuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).