test suite reviews and discussions
 help / color / Atom feed
From: Xiao Qimai <qimaix.xiao@intel.com>
To: dts@dpdk.org
Cc: Xiao Qimai <qimaix.xiao@intel.com>
Subject: [dts] [PATCH V1]tests/TestSuite_telemetry: use existed session instead of creating a new session
Date: Wed,  6 Nov 2019 15:40:37 +0800
Message-ID: <1573026037-87704-1-git-send-email-qimaix.xiao@intel.com> (raw)

optimize scripts, use existed session to send command

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
 tests/TestSuite_telemetry.py | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_telemetry.py b/tests/TestSuite_telemetry.py
index c6e7e08..13a0729 100644
--- a/tests/TestSuite_telemetry.py
+++ b/tests/TestSuite_telemetry.py
@@ -451,13 +451,12 @@ class TestTelemetry(TestCase):
     def change_run_fileprefix(self, out):
         if self.file_prefix:
-            self.dut_session2 = self.dut.new_session()
             cmd1 = "sed -i 's/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/.*\/telemetry\")/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/{0}\/telemetry\")/g' {1}".format(
                 self.file_prefix, os.path.join(self.target_dir, 'usertools/dpdk-telemetry-client.py'))
-            cmd = "sed -i 's/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/.*\/telemetry\")/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/{0}\/telemetry\")/g' {1}".format(
+            cmd2 = "sed -i 's/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/.*\/telemetry\")/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/{0}\/telemetry\")/g' {1}".format(
                 self.file_prefix, os.path.join(self.target_dir, 'dpdk_telemetry_client.py'))
-            self.dut_session2.send_expect(cmd1, "# ", 3)
-            self.dut_session2.send_expect(cmd, "# ", 3)
+            self.d_a_console(cmd1)
+            self.d_a_console(cmd2)
             self.change_flag = True
     def verify_basic_script(self):

             reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06  7:40 Xiao Qimai [this message]
2019-11-22  5:30 ` Tu, Lijuan

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1573026037-87704-1-git-send-email-qimaix.xiao@intel.com \
    --to=qimaix.xiao@intel.com \
    --cc=dts@dpdk.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
	public-inbox-index dts

Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/ public-inbox