test suite reviews and discussions
 help / color / mirror / Atom feed
From: Peng Yuan <yuan.peng@intel.com>
To: dts@dpdk.org
Cc: Peng Yuan <yuan.peng@intel.com>
Subject: [dts] [PATCH]test_plans: remove --tx-offload from commandline
Date: Mon,  9 Dec 2019 11:10:54 +0800	[thread overview]
Message-ID: <1575861054-55288-1-git-send-email-yuan.peng@intel.com> (raw)

remove --tx-offloads from testpmd commandline in macsec_test_plan.rst

Signed-off-by: Peng Yuan <yuan.peng@intel.com>

diff --git a/test_plans/macsec_for_ixgbe_test_plan.rst b/test_plans/macsec_for_ixgbe_test_plan.rst
index 79b7d57..997f921 100644
--- a/test_plans/macsec_for_ixgbe_test_plan.rst
+++ b/test_plans/macsec_for_ixgbe_test_plan.rst
@@ -151,7 +151,7 @@ Test Case 1: MACsec packets send and receive
   1. Start the testpmd of tx port::
 
       ./testpmd -c 0xf0 --socket-mem 1024,0 --file-prefix=tx -w 0000:07:00.0 \
-      -- -i --port-topology=chained --tx-offloads=0x00002000
+      -- -i --port-topology=chained
 
   2. Set MACsec offload on::
 
@@ -352,10 +352,7 @@ Test Case 5: normal packet send and MACsec receive
 Test Case 6: MACsec send and receive with wrong parameters
 ==========================================================
 
-1. Don't add "--tx-offloads=0x00002000" in the tx_port command line.
-   The MACsec offload can't work. The tx packets are normal packets.
-
-2. Set different pn on rx and tx port, then start the data transfer.
+1. Set different pn on rx and tx port, then start the data transfer.
 
   1. Set the parameters as test case 1, start and stop the data transfer.
      Check the result, rx port can receive and decrypt the packets normally.
@@ -368,7 +365,7 @@ Test Case 6: MACsec send and receive with wrong parameters
 
       out_pkts_encrypted = in_pkts_late + in_pkts_ok
 
-3. Set different keys on rx and tx port, then start the data transfer::
+2. Set different keys on rx and tx port, then start the data transfer::
 
       the RX-packets=0,
       in_octets_decrypted == out_octets_encrypted,
@@ -376,20 +373,23 @@ Test Case 6: MACsec send and receive with wrong parameters
       in_pkts_ok=0,
       rx_good_packets=0
 
-4. Set different pi on rx and tx port, then start the data transfer::
+3. Set different pi on rx and tx port, then start the data transfer::
 
       in_octets_decrypted == out_octets_encrypted,
       in_pkts_ok = 0,
       in_pkts_nosci == out_pkts_encrypted
 
-5. Set different an on rx and tx port, then start the data transfer::
+   note: pi only support changed on rx side, if change pi on tx side,
+         it will be omitted.
+
+4. Set different an on rx and tx port, then start the data transfer::
 
       rx_good_packets=0,
       in_octets_decrypted == out_octets_encrypted,
       in_pkts_notusingsa == out_pkts_encrypted,
       in_pkts_ok=0,
 
-6. Set different index on rx and tx port, then start the data transfer::
+5. Set different index on rx and tx port, then start the data transfer::
 
       in_octets_decrypted == out_octets_encrypted,
       in_pkts_ok == out_pkts_encrypted
@@ -404,7 +404,7 @@ Test Case 7: performance test of MACsec offload packets
    MACsec offload on, set fwd mac::
 
       ./testpmd -c 0xf --socket-mem 1024,0 -- -i \
-      --port-topology=chained --tx-offloads=0x00002000
+      --port-topology=chained
       testpmd> set macsec offload 0 on encrypt on replay-protect on
       testpmd> set fwd mac
       testpmd> start
@@ -423,7 +423,7 @@ Test Case 7: performance test of MACsec offload packets
    Start two testpmd::
 
       ./testpmd -c 0xf --socket-mem 1024,0 --file-prefix=rx -w 0000:07:00.1 \
-      -- -i --port-topology=chained --tx-offloads=0x00002000
+      -- -i --port-topology=chained
 
       testpmd> set macsec offload 0 on encrypt on replay-protect on
       testpmd> set macsec sc rx 0 00:00:00:00:00:01 0
@@ -433,7 +433,7 @@ Test Case 7: performance test of MACsec offload packets
       testpmd> set fwd rxonly
 
       ./testpmd -c 0xf0 --socket-mem 1024,0 --file-prefix=tx -b 0000:07:00.1 \
-      -- -i --port-topology=chained --tx-offloads=0x00002000
+      -- -i --port-topology=chained
 
       testpmd> set macsec offload 1 on encrypt on replay-protect on
       testpmd> set macsec sc rx 1 00:00:00:00:00:02 0
-- 
2.17.1


             reply	other threads:[~2019-12-09  3:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-09  3:10 Peng Yuan [this message]
2019-12-19  7:56 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1575861054-55288-1-git-send-email-yuan.peng@intel.com \
    --to=yuan.peng@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).